Skip to contentSkip to conversation

hwmon: (coretemp) Simplify package management

DISCUSSION Dave Jones 1 participant 1 message Dec 28, 2016 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Dave Jones

author
#1 lore raw
Quoted 33 lines · Linux Kernel
Web:        https://git.kernel.org/torvalds/c/712668460594294d74c13f2a023398a597fbe95f
Commit:     712668460594294d74c13f2a023398a597fbe95f
Parent:     2195c31b127def509c806fe8a9d3b4092a28ce31
Refname:    refs/heads/master
Author:     Thomas Gleixner <[email protected]>
AuthorDate: Tue Nov 22 17:42:06 2016 +0000
Committer:  Guenter Roeck <[email protected]>
CommitDate: Fri Dec 9 21:54:13 2016 -0800

hwmon: (coretemp) Simplify package management

Keeping track of the per package platform devices requires an extra object, which is held in a linked list.

The maximum number of packages is known at init() time. So the extra object and linked list management can be replaced by an array of platform device pointers in which the per package devices pointers can be stored. Lookup becomes a simple array lookup instead of a list walk.

The mutex protecting the list can be removed as well because the array is only accessed from cpu hotplug callbacks which are already serialized.

 1 file changed, 38 insertions(+), 82 deletions(-)
drivers/hwmon/coretemp.c +0 -0
index c364bfd..3ac4c03 100644

drivers/hwmon/coretemp.c static ssize_t show_label(struct device *dev, · line 128

Quoted 8 lines
drivers/hwmon/coretemp.c +1 -1
@@ -127,7 +122,7 @@ static ssize_t show_label(struct device *dev,
 	struct temp_data *tdata = pdata->core_data[attr->index];
 
 	if (tdata->is_pkg_data)
-		return sprintf(buf, "Physical id %u\n", pdata->phys_proc_id);
+		return sprintf(buf, "Package id %u\n", pdata->pkg_id);
 
 	return sprintf(buf, "Core %u\n", tdata->cpu_core_id);
 }

This is breakage of a userspace ABI.
Fixing up my mrtg config to cope was simple enough, but do we want to force everyone to have to do that if they upgrade their kernel ?

Dave