Skip to contentSkip to conversation

drm/amd/amdgpu: Widen mmio trace register address width

PATCH In review Tom St Denis 2 participants 2 messages Dec 14, 2016 – Dec 15, 2016 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/amdgpu: Widen mmio trace register address width

Support wider address spaces, make it 32-bit so we don't have to revisit this for a while.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h +2 -2
index 067e5e683bb3..82c3d5aaca2b 100644
@@ -24,7 +24,7 @@ TRACE_EVENT(amdgpu_mm_rreg,
 			   __entry->reg = reg;
 			   __entry->value = value;
 			   ),
-	    TP_printk("0x%04lx, 0x%04lx, 0x%08lx",
+	    TP_printk("0x%04lx, 0x%08lx, 0x%08lx",
 		      (unsigned long)__entry->did,
 		      (unsigned long)__entry->reg,
 		      (unsigned long)__entry->value)
@@ -43,7 +43,7 @@ TRACE_EVENT(amdgpu_mm_wreg,
 			   __entry->reg = reg;
 			   __entry->value = value;
 			   ),
-	    TP_printk("0x%04lx, 0x%04lx, 0x%08lx",
+	    TP_printk("0x%04lx, 0x%08lx, 0x%08lx",
 		      (unsigned long)__entry->did,
 		      (unsigned long)__entry->reg,
 		      (unsigned long)__entry->value)
Signature · 6 lines
2.11.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by Chunming Zhou
#2 lore raw
Quoted 4 lines · Tom St Denis

Support wider address spaces, make it 32-bit so we don't have to revisit this for a while.

Quoted 18 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h +1 -1
index 067e5e683bb3..82c3d5aaca2b 100644
@@ -24,7 +24,7 @@ TRACE_EVENT(amdgpu_mm_rreg,
  			   __entry->reg = reg;
  			   __entry->value = value;
  			   ),
-	    TP_printk("0x%04lx, 0x%04lx, 0x%08lx",
+	    TP_printk("0x%04lx, 0x%08lx, 0x%08lx",
  		      (unsigned long)__entry->did,
  		      (unsigned long)__entry->reg,
  		      (unsigned long)__entry->value)

drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h TRACE_EVENT(amdgpu_mm_wreg, · line 49

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h +1 -1
@@ -43,7 +43,7 @@ TRACE_EVENT(amdgpu_mm_wreg,
  			   __entry->reg = reg;
  			   __entry->value = value;
  			   ),
-	    TP_printk("0x%04lx, 0x%04lx, 0x%08lx",
+	    TP_printk("0x%04lx, 0x%08lx, 0x%08lx",
  		      (unsigned long)__entry->did,
  		      (unsigned long)__entry->reg,
  		      (unsigned long)__entry->value)

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx