Skip to contentSkip to conversation

kref: prefer atomic_inc_not_zero to atomic_add_unless

PATCH In review Jason A. Donenfeld 3 participants 4 messages Dec 15, 2016 – Dec 16, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kref: prefer atomic_inc_not_zero to atomic_add_unless

On most platforms, there exists this ifdef:

#define atomic_inc_not_zero(v) atomic_add_unless((v), 1, 0)

This makes this patch functionally useless. However, on PPC, there is actually an explicit definition of atomic_inc_not_zero with its own assembly that is slightly more optimized than atomic_add_unless. So, this patch changes kref to use atomic_inc_not_zero instead, for PPC and any future platforms that might provide an explicit implementation.

This also puts this usage of kref more in line with a verbatim reading of the examples in Paul McKenney's paper [1] in the section titled "2.4 Atomic Counting With Check and Release Memory Barrier", which uses atomic_inc_not_zero.

[1] http://open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2167.pdf

---
Sorry to submit this again, but people keep reviewing it saying it's fine, but then point to somebody else to actually merge this. At the end of the chain of fingerpointing is usually Greg. "Just have Greg do it." At this point I'm confused, but it's certainly been sufficiently reviewed and accepted. So can one of you just respond saying "I'll take it!"

 include/linux/kref.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/kref.h +1 -1
index e15828fd71f1..62f0a84ae94e 100644
@@ -133,6 +133,6 @@ static inline int kref_put_mutex(struct kref *kref,
  */
 static inline int __must_check kref_get_unless_zero(struct kref *kref)
 {
-	return atomic_add_unless(&kref->refcount, 1, 0);
+	return atomic_inc_not_zero(&kref->refcount);
 }
 #endif /* _KREF_H_ */
Signature · 1 line
2.11.0
#1 lore raw
Quoted 20 lines · Jason A. Donenfeld

On most platforms, there exists this ifdef:

#define atomic_inc_not_zero(v) atomic_add_unless((v), 1, 0)

This makes this patch functionally useless. However, on PPC, there is actually an explicit definition of atomic_inc_not_zero with its own assembly that is slightly more optimized than atomic_add_unless. So, this patch changes kref to use atomic_inc_not_zero instead, for PPC and any future platforms that might provide an explicit implementation.

This also puts this usage of kref more in line with a verbatim reading of the examples in Paul McKenney's paper [1] in the section titled "2.4 Atomic Counting With Check and Release Memory Barrier", which uses atomic_inc_not_zero.

[1] http://open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2167.pdf

Quoted 6 lines

---
Sorry to submit this again, but people keep reviewing it saying it's fine, but then point to somebody else to actually merge this. At the end of the chain of fingerpointing is usually Greg. "Just have Greg do it." At this point I'm confused, but it's certainly been sufficiently reviewed and accepted. So can one of you just respond saying "I'll take it!"

Well, the crazies over in drm land were the ones that merged this new api, so they should be the ones responsible for it. But that was way back in 2012, odds are they don't remember it given the lunacy that is their subsystem...

I'll take it after 4.10-rc1 is out, thanks.

greg k-h

#2 lore raw

Hi Greg,

Quoted 1 line · Greg KH

I'll take it after 4.10-rc1 is out, thanks.

Thank you!

Jason

#3 lore raw
In reply to Greg KH
Quoted 28 lines · Greg KH
Quoted 20 lines · Jason A. Donenfeld

On most platforms, there exists this ifdef:

#define atomic_inc_not_zero(v) atomic_add_unless((v), 1, 0)

This makes this patch functionally useless. However, on PPC, there is actually an explicit definition of atomic_inc_not_zero with its own assembly that is slightly more optimized than atomic_add_unless. So, this patch changes kref to use atomic_inc_not_zero instead, for PPC and any future platforms that might provide an explicit implementation.

This also puts this usage of kref more in line with a verbatim reading of the examples in Paul McKenney's paper [1] in the section titled "2.4 Atomic Counting With Check and Release Memory Barrier", which uses atomic_inc_not_zero.

[1] http://open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2167.pdf

Quoted 6 lines

---
Sorry to submit this again, but people keep reviewing it saying it's fine, but then point to somebody else to actually merge this. At the end of the chain of fingerpointing is usually Greg. "Just have Greg do it." At this point I'm confused, but it's certainly been sufficiently reviewed and accepted. So can one of you just respond saying "I'll take it!"

Quoted 4 lines

Well, the crazies over in drm land were the ones that merged this new api, so they should be the ones responsible for it. But that was way back in 2012, odds are they don't remember it given the lunacy that is their subsystem...

We do, it's just that I couldn't find Jason's patch when Thomas reviewed it and asked for a resend and it took Jason a while to do that ...

Maybe we even remember this api way too well, we're constantly adding new users of it in drm ;-)

Quoted 1 line

I'll take it after 4.10-rc1 is out, thanks.

Oh, here's another resubmission of this patch. I've already applied this to my 4.11 queue, will show up in linux-next as soon as -rc1 is out.

Thanks, Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel