Skip to contentSkip to conversation

platform/x86: fujitsu-laptop: set default trigger for radio LED to rfkill-any

PATCH In review Michał Kępień 3 participants 3 messages Dec 16, 2016 – Dec 27, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: fujitsu-laptop: set default trigger for radio LED to rfkill-any

The "radio components indicator" LED present in Lifebook E734/E744/E754 should be lit when any radio transmitter is enabled, so set its default trigger to rfkill-any.

---
Note: the rfkill-any trigger is currently only present in mac80211-next/master.

 drivers/platform/x86/fujitsu-laptop.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/fujitsu-laptop.c +1 -0
index 61f39ab..bfc0eb3 100644
@@ -202,6 +202,7 @@ static void radio_led_set(struct led_classdev *cdev,
 
 static struct led_classdev radio_led = {
  .name = "fujitsu::radio_led",
+ .default_trigger = "rfkill-any",
  .brightness_get = radio_led_get,
  .brightness_set = radio_led_set
 };
Signature · 1 line
2.10.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Micha?? K??pie??

The "radio components indicator" LED present in Lifebook E734/E744/E754 should be lit when any radio transmitter is enabled, so set its default trigger to rfkill-any.

This shouldn't cause any problems. At the end of the day it's only the default; if for some reason it's inappropriate for any systems we could do an override.

Quoted 20 lines

---
Note: the rfkill-any trigger is currently only present in mac80211-next/master.

 drivers/platform/x86/fujitsu-laptop.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/fujitsu-laptop.c +1 -0
index 61f39ab..bfc0eb3 100644
@@ -202,6 +202,7 @@ static void radio_led_set(struct led_classdev *cdev,
 
 static struct led_classdev radio_led = {
  .name = "fujitsu::radio_led",
+ .default_trigger = "rfkill-any",
  .brightness_get = radio_led_get,
  .brightness_set = radio_led_set
 };
#2 lore raw
In reply to Michał Kępień
Quoted 4 lines · Michał Kępień

The "radio components indicator" LED present in Lifebook E734/E744/E754 should be lit when any radio transmitter is enabled, so set its default trigger to rfkill-any.

Pushed to testing, thanks!

Quoted 23 lines

---
Note: the rfkill-any trigger is currently only present in mac80211-next/master.

 drivers/platform/x86/fujitsu-laptop.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/fujitsu-laptop.c +1 -1
index 61f39ab..bfc0eb3 100644
@@ -202,6 +202,7 @@ static void radio_led_set(struct led_classdev *cdev,
 
 static struct led_classdev radio_led = {
  .name = "fujitsu::radio_led",
+ .default_trigger = "rfkill-any",
  .brightness_get = radio_led_get,
  .brightness_set = radio_led_set
 };
--

2.10.2

Signature · 2 lines
With Best Regards,
Andy Shevchenko