igt_kms: Use const parameters for igt_assert_crc_equal
PATCH 1/1 igt_kms: Use const parameters for igt_assert_crc_equal
Since we're not modifying these anywhere, let's make them const so as to not break code doing comparisons against compile-time CRCs.
Signed-off-by Lyude <[email protected]>
--- lib/igt_debugfs.c | 2 +- lib/igt_debugfs.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
lib/igt_debugfs.c +1 -1
@@ -270,7 +270,7 @@ bool igt_debugfs_search(const char *filename, const char *substring)* be random testcase failures when different screen contents end up with the * same CRC by chance. */ -void igt_assert_crc_equal (igt_crc_t *a,igt_crc_t *b) +void igt_assert_crc_equal (const igt_crc_t *a,const igt_crc_t *b) {int i;
lib/igt_debugfs.h +1 -1
@@ -113,7 +113,7 @@ enum intel_pipe_crc_source { INTEL_PIPE_CRC_SOURCE_MAX, }; -void igt_assert_crc_equal (igt_crc_t *a,igt_crc_t *b); +void igt_assert_crc_equal (const igt_crc_t *a,const igt_crc_t *b);char *igt_crc_to_string (igt_crc_t *crc);void igt_require_pipe_crc (void );
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Looks good to me.
Added t-b and pushed upstream.
Rob.
Quoted 4 lines · Lyude
Since we're not modifying these anywhere, let's make them const so as to not break code doing comparisons against compile-time CRCs.
Signed-off-by Lyude <[email protected]>
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx