Skip to contentSkip to conversation

Revert NAT conversion to rhashtable

-stable 4.8.y Pablo Neira Ayuso 2 participants 4 messages Dec 19, 2016 – Jan 5, 2017

Subsystems (2)
Stable branch netfilter
lore
Share & tools
lore

Pablo Neira Ayuso

author maintainer
#0 lore raw

Hi Greg,

Please revert the following two patches from 4.8.y:

870190a9ec9075205c0fa795a09fa931694a3ff1 ("netfilter: nat: convert nat bysrc hash to rhashtable")

7c9664351980aaa6a4b8837a314360b3a4ad382a ("netfilter: move nat hlist_head to nf_conn")

There are incremental fixes in 4.9 to resolve the problems in these two, but they also require the new rhlist interface not available there.

Thanks!

maintainer
#1 lore raw
Quoted 7 lines · Pablo Neira Ayuso

Hi Greg,

Please revert the following two patches from 4.8.y:

870190a9ec9075205c0fa795a09fa931694a3ff1 ("netfilter: nat: convert nat bysrc hash to rhashtable")

Quoted 6 lines

7c9664351980aaa6a4b8837a314360b3a4ad382a ("netfilter: move nat hlist_head to nf_conn")

There are incremental fixes in 4.9 to resolve the problems in these two, but they also require the new rhlist interface not available there.

Now reverted, thanks!

greg k-h

author maintainer
#2 lore raw
Quoted 8 lines · Greg Kroah-Hartman
Quoted 7 lines · Pablo Neira Ayuso

Hi Greg,

Please revert the following two patches from 4.8.y:

870190a9ec9075205c0fa795a09fa931694a3ff1 ("netfilter: nat: convert nat bysrc hash to rhashtable")

Quoted 8 lines
Quoted 6 lines

7c9664351980aaa6a4b8837a314360b3a4ad382a ("netfilter: move nat hlist_head to nf_conn")

There are incremental fixes in 4.9 to resolve the problems in these two, but they also require the new rhlist interface not available there.

Now reverted, thanks!

thanks a lot Greg.

I have more updates for you, will be sending them asap.

maintainer
#3 lore raw
Quoted 16 lines · Pablo Neira Ayuso
Quoted 15 lines · Greg Kroah-Hartman
Quoted 13 lines · Pablo Neira Ayuso

Hi Greg,

Please revert the following two patches from 4.8.y:

870190a9ec9075205c0fa795a09fa931694a3ff1 ("netfilter: nat: convert nat bysrc hash to rhashtable")

7c9664351980aaa6a4b8837a314360b3a4ad382a ("netfilter: move nat hlist_head to nf_conn")

There are incremental fixes in 4.9 to resolve the problems in these two, but they also require the new rhlist interface not available there.

Quoted 5 lines
Quoted 1 line

Now reverted, thanks!

thanks a lot Greg.

I have more updates for you, will be sending them asap.

If they are for 4.8, don't worry too much about that kernel, it will go end-of-life in another release. But patches for 4.4 and 4.9 are greatly appreciated if you have them.

thanks,

greg k-h