Skip to contentSkip to conversation

kernel: sys: fix out of place EXPORT_SYMBOL call

PATCH In review Thomas Casey 2 participants 2 messages Dec 20, 2016 – Dec 21, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel: sys: fix out of place EXPORT_SYMBOL call

Fixes two instances of EXPORT_SYMBOL not being called immediately after the initialization of its argument

---
 kernel/sys.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
kernel/sys.c +2 -4
index 9758892a2d09..8afd3e341f9b 100644
@@ -110,9 +110,8 @@
  */
 
 int overflowuid = DEFAULT_OVERFLOWUID;
-int overflowgid = DEFAULT_OVERFLOWGID;
-
 EXPORT_SYMBOL(overflowuid);
+int overflowgid = DEFAULT_OVERFLOWGID;
 EXPORT_SYMBOL(overflowgid);
 
 /*
@@ -121,9 +120,8 @@ EXPORT_SYMBOL(overflowgid);
  */
 
 int fs_overflowuid = DEFAULT_FS_OVERFLOWUID;
-int fs_overflowgid = DEFAULT_FS_OVERFLOWUID;
-
 EXPORT_SYMBOL(fs_overflowuid);
+int fs_overflowgid = DEFAULT_FS_OVERFLOWUID;
 EXPORT_SYMBOL(fs_overflowgid);
 
 /*
Signature · 1 line
2.11.0
#1 lore raw
Quoted 2 lines · Thomas Casey

Fixes two instances of EXPORT_SYMBOL not being called immediately after the initialization of its argument

What does this fix actually?

Quoted 34 lines
---
 kernel/sys.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
kernel/sys.c +2 -4
index 9758892a2d09..8afd3e341f9b 100644
@@ -110,9 +110,8 @@
  */
 
 int overflowuid = DEFAULT_OVERFLOWUID;
-int overflowgid = DEFAULT_OVERFLOWGID;
-
 EXPORT_SYMBOL(overflowuid);
+int overflowgid = DEFAULT_OVERFLOWGID;
 EXPORT_SYMBOL(overflowgid);
 
 /*
@@ -121,9 +120,8 @@ EXPORT_SYMBOL(overflowgid);
  */
 
 int fs_overflowuid = DEFAULT_FS_OVERFLOWUID;
-int fs_overflowgid = DEFAULT_FS_OVERFLOWUID;
-
 EXPORT_SYMBOL(fs_overflowuid);
+int fs_overflowgid = DEFAULT_FS_OVERFLOWUID;
 EXPORT_SYMBOL(fs_overflowgid);
 
 /*
Signature · 1 line
2.11.0
Signature · 2 lines
Michal Hocko
SUSE Labs