Skip to contentSkip to conversation

ASoC: pcm5102a: Provide a menu selection text

PATCH Superseded Jörg Krause 2 participants 7 messages Dec 20, 2016 – Jan 6, 2017

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: pcm5102a: Provide a menu selection text

Provide a menu selection text so that users can enable, disable or mark it as module in menuconfig.

---
 sound/soc/codecs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/Kconfig +1 -1
index 084c2aa..9ee9591 100644
@@ -624,7 +624,7 @@ config SND_SOC_PCM3168A_SPI
 	select REGMAP_SPI
 
 config SND_SOC_PCM5102A
-	tristate
+	tristate "Texas Instruments PCM5102A CODEC"
 
 config SND_SOC_PCM512x
 	tristate
Signature · 6 lines
2.10.2

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
#1 lore raw
Quoted 3 lines · Jörg Krause

Provide a menu selection text so that users can enable, disable or mark it as module in menuconfig.

What's the reason to enable it at all? The codec entries are usually not user-selectable but enabled by the machine driver.

Takashi

Quoted 22 lines
---
 sound/soc/codecs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/Kconfig +1 -1
index 084c2aa..9ee9591 100644
@@ -624,7 +624,7 @@ config SND_SOC_PCM3168A_SPI
 	select REGMAP_SPI
 
 config SND_SOC_PCM5102A
-	tristate
+	tristate "Texas Instruments PCM5102A CODEC"
 
 config SND_SOC_PCM512x
 	tristate
Signature · 1 line
2.10.2

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#2 lore raw
Quoted 8 lines · Takashi Iwai
Quoted 3 lines · Jörg Krause

Provide a menu selection text so that users can enable, disable or mark it as module in menuconfig.

What's the reason to enable it at all?  The codec entries are usually not user-selectable but enabled by the machine driver.

To allow using it with the simple-card driver.

Quoted 7 lines
Quoted 7 lines

---
 sound/soc/codecs/Kconfig | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
Quoted 10 lines
sound/soc/codecs/Kconfig +0 -0
index 084c2aa..9ee9591 100644
@@ -624,7 +624,7 @@ config SND_SOC_PCM3168A_SPI

  select REGMAP_SPI

 config SND_SOC_PCM5102A

sound/soc/codecs/Kconfig +1 -1
-	tristate
+	tristate "Texas Instruments PCM5102A CODEC"
Quoted 6 lines


 config SND_SOC_PCM512x
  tristate
--
2.10.2

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#3 lore raw
Quoted 5 lines · Jörg Krause
Quoted 3 lines · Takashi Iwai
Quoted 1 line · Jörg Krause
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Provide a menu selection text so that users can enable, disable or mark it as module in menuconfig.

What's the reason to enable it at all?  The codec entries are usually not user-selectable but enabled by the machine driver.

To allow using it with the simple-card driver.

See, now you know what's missing in your patch :)

Takashi
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#4 lore raw
Quoted 11 lines · Takashi Iwai
Quoted 9 lines · Jörg Krause
Quoted 7 lines · Takashi Iwai
Quoted 4 lines · Jörg Krause

Provide a menu selection text so that users can enable, disable or
mark it as module in menuconfig.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

What's the reason to enable it at all?  The codec entries are usually
not user-selectable but enabled by the machine driver.

To allow using it with the simple-card driver.

See, now you know what's missing in your patch :)

Unforunately not. I adopted commit 465011fc5671 which does not has any dependency. Please enlighten me :)

Jörg
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#5 lore raw
Quoted 17 lines · Jörg Krause
Quoted 15 lines · Takashi Iwai
Quoted 13 lines · Jörg Krause
Quoted 10 lines · Takashi Iwai
Quoted 4 lines · Jörg Krause

Provide a menu selection text so that users can enable, disable or
mark it as module in menuconfig.

What's the reason to enable it at all?  The codec entries are usually
not user-selectable but enabled by the machine driver.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

To allow using it with the simple-card driver.

See, now you know what's missing in your patch :)

Unforunately not. I adopted commit 465011fc5671 which does not has any dependency. Please enlighten me :)

The missing piece is one of the most important things in writing a patch -- the proper information explaining "why" this change is needed, preferably in a form of changelog text. Instead, you wrote merely what you changed, which is pretty obvious and doesn't help understanding.

The commit you referred to is no good example in this manner at all, unfortunately.

Takashi
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#6 lore raw

Hi Takashi,

Quoted 28 lines · Takashi Iwai
Quoted 18 lines · Jörg Krause
Quoted 16 lines · Takashi Iwai
Quoted 14 lines · Jörg Krause
Quoted 11 lines · Takashi Iwai
Quoted 5 lines · Jörg Krause

Provide a menu selection text so that users can enable, disable
or
mark it as module in menuconfig.

What's the reason to enable it at all?  The codec entries are usually
not user-selectable but enabled by the machine driver.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

To allow using it with the simple-card driver.

See, now you know what's missing in your patch :)

Unforunately not. I adopted commit 465011fc5671 which does not has any
dependency. Please enlighten me :)

Quoted 8 lines

The missing piece is one of the most important things in writing a patch -- the proper information explaining "why" this change is needed, preferably in a form of changelog text.  Instead, you wrote merely what you changed, which is pretty obvious and doesn't help understanding.

The commit you referred to is no good example in this manner at all, unfortunately.

I see and I fully agree! I will send an updated version with a better commit log.

Jörg
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel