mpt3sas: disable ASPM for MPI2 controllers

PATCH Applied ojab 3 participants 19 messages Dec 28, 2016 – Feb 9, 2017

Subsystems (2)

SCSI LSI Logic MPT fusion drivers (FC/SAS/SPI)

lore

Share & tools

lore

Martin K. Petersen

2017-01-06 01:54 UTC #1 lore raw

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"ojab" == ojab <[email protected]> writes:

ojab> MPI2 controllers sometimes got lost (i. e. disappears from ojab> /sys/bus/pci/devices) if ASMP is enabled.

Broadcom folks: Please comment!

Signature · 1 line

Martin K. Petersen	Oracle Linux Engineering

Sreekanth Reddy

maintainer

2017-01-06 15:48 UTC #2 lore raw

Quoted 6 lines · Martin K. Petersen

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"ojab" == ojab <[email protected]> writes:
ojab> MPI2 controllers sometimes got lost (i. e. disappears from ojab> /sys/bus/pci/devices) if ASMP is enabled.
Broadcom folks: Please comment!

Matin, We need some time to review this patch. I will provide my review comments by end of next week.

Thanks,
Sreekanth

Quoted 7 lines

--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

ojab

author

2017-01-16 12:08 UTC #3 lore raw

Quoted 6 lines · Sreekanth Reddy

On Fri, Jan 6, 2017 at 7:24 AM, Martin K. Petersen <[email protected]> wrote:
Matin, We need some time to review this patch. I will provide my review comments by end of next week.

ping?

//wbr ojab

Quoted 2 lines

Thanks,
Sreekanth

Sreekanth Reddy

maintainer

2017-01-16 12:36 UTC #4 lore raw

Ojab,

I am checking internally with our FW team and Architect to known whether they aware/observed any issues similar to this (since this issue is nothing to do with driver).

Meanwhile is it possible to provide us the PCI config space and FW logs when issue occurs?

Thanks,
Sreekanth

Quoted 16 lines · ojab

Quoted 7 lines · Sreekanth Reddy
On Fri, Jan 6, 2017 at 7:24 AM, Martin K. Petersen <[email protected]> wrote:
Matin, We need some time to review this patch. I will provide my review comments by end of next week.
ping?
//wbr ojab
Quoted 3 lines
Thanks,
Sreekanth

ojab

author

2017-01-16 12:45 UTC #5 lore raw

Quoted 8 lines · Sreekanth Reddy

Ojab,
I am checking internally with our FW team and Architect to known whether they aware/observed any issues similar to this (since this issue is nothing to do with driver).
Meanwhile is it possible to provide us the PCI config space and FW logs when issue occurs?

AFAIU FW log is enabled when logging_level=0x3f8 is passed to the module, right? Where can I find info about PCI config space?

//wbr ojab

Quoted 26 lines

Thanks,
Sreekanth
Quoted 5 lines · ojab
Quoted 4 lines · Sreekanth Reddy
On Fri, Jan 6, 2017 at 7:24 AM, Martin K. Petersen <[email protected]> wrote:
Quoted 11 lines
Quoted 3 lines
Matin, We need some time to review this patch. I will provide my review comments by end of next week.
ping?
//wbr ojab
Quoted 3 lines
Thanks,
Sreekanth
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Sreekanth Reddy

maintainer

2017-01-16 13:31 UTC #6 lore raw

Quoted 8 lines · ojab

Quoted 7 lines · Sreekanth Reddy
Ojab,
I am checking internally with our FW team and Architect to known whether they aware/observed any issues similar to this (since this issue is nothing to do with driver).

Quoted 6 lines

Quoted 2 lines
Meanwhile is it possible to provide us the PCI config space and FW logs when issue occurs?
AFAIU FW log is enabled when logging_level=0x3f8 is passed to the module, right?

This is a driver logging_level. Firmware logs can be collected using UART logs.

Quoted 1 line

Where can I find info about PCI config space?

You can get PCI config space info from lspci command.

Quoted 34 lines

//wbr ojab
Quoted 31 lines
Thanks,
Sreekanth
Quoted 7 lines · ojab
Quoted 5 lines · Sreekanth Reddy
On Fri, Jan 6, 2017 at 7:24 AM, Martin K. Petersen <[email protected]> wrote:
Quoted 13 lines
Quoted 3 lines
Matin, We need some time to review this patch. I will provide my review comments by end of next week.
ping?
//wbr ojab
Quoted 4 lines
Thanks,
Sreekanth
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

ojab

author

2017-01-16 14:03 UTC #7 lore raw

Quoted 9 lines · Sreekanth Reddy

Quoted 8 lines · ojab
Quoted 7 lines · Sreekanth Reddy
Ojab,
I am checking internally with our FW team and Architect to known whether they aware/observed any issues similar to this (since this issue is nothing to do with driver).

Quoted 8 lines

Quoted 6 lines
Quoted 2 lines
Meanwhile is it possible to provide us the PCI config space and FW logs when issue occurs?
AFAIU FW log is enabled when logging_level=0x3f8 is passed to the module, right?
This is a driver logging_level. Firmware logs can be collected using UART logs.

According to the user guide (from https://www.broadcom.com/products/storage/host-bus-adapters/sas-9217-8i#documentation) my 9217-8i requires 1.8V UART which I don't have at hand, I'll try to do something on the weekend. Is anything needed except connecting UART to gather required info?

Anyway, right now various MPI2 HBAs doesn't work with ASPM enabled, so can this patch be applied in the meantime while we're debugging the issue further? Even if this issue can be properly fixed by FW update, this workaround will be needed for HBAs with affected FW versions.

//wbr ojab

Quoted 44 lines

Quoted 2 lines
Where can I find info about PCI config space?
You can get PCI config space info from lspci command.
Quoted 34 lines
//wbr ojab
Quoted 31 lines
Thanks,
Sreekanth
Quoted 7 lines · ojab
Quoted 5 lines · Sreekanth Reddy
On Fri, Jan 6, 2017 at 7:24 AM, Martin K. Petersen <[email protected]> wrote:
Quoted 13 lines
Quoted 3 lines
Matin, We need some time to review this patch. I will provide my review comments by end of next week.
ping?
//wbr ojab
Quoted 4 lines
Thanks,
Sreekanth
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

ojab

author

2017-01-16 22:44 UTC #8 lore raw

Quoted 18 lines · ojab

Quoted 17 lines · Sreekanth Reddy
Quoted 15 lines · ojab
Quoted 9 lines · Sreekanth Reddy
Ojab,
I am checking internally with our FW team and Architect to known whether they aware/observed any issues similar to this (since this issue is nothing to do with driver).
Meanwhile is it possible to provide us the PCI config space and FW logs when issue occurs?
AFAIU FW log is enabled when logging_level=0x3f8 is passed to the module,
right?

Quoted 8 lines

Quoted 2 lines
This is a driver logging_level. Firmware logs can be collected using UART logs.
According to the user guide (from
https://www.broadcom.com/products/storage/host-bus-adapters/sas-9217-8i#documentation)
my 9217-8i requires 1.8V UART which I don't have at hand, I'll try to do something on the weekend.
Is anything needed except connecting UART to gather required info?

…actually I have compatible USB UART here. What should be done to get FW log? I've tried to reboot with UART connected (9600N1) but got no output.

//wbr ojab

Quoted 60 lines

Anyway, right now various MPI2 HBAs doesn't work with ASPM enabled, so can this patch be applied in the meantime while we're debugging the issue further? Even if this issue can be properly fixed by FW update, this workaround will be needed for HBAs with affected FW versions.
//wbr ojab
Quoted 40 lines
Quoted 2 lines
Where can I find info about PCI config space?
You can get PCI config space info from lspci command.
Quoted 35 lines
//wbr ojab
Quoted 32 lines
Thanks,
Sreekanth
Quoted 7 lines · ojab
Quoted 5 lines · Sreekanth Reddy
On Fri, Jan 6, 2017 at 7:24 AM, Martin K. Petersen <[email protected]> wrote:
Quoted 13 lines
Quoted 3 lines
Matin, We need some time to review this patch. I will provide my review comments by end of next week.
ping?
//wbr ojab
Quoted 4 lines
Thanks,
Sreekanth
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 5 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Sreekanth Reddy

maintainer

2017-01-17 14:17 UTC #9 lore raw

Quoted 31 lines · ojab

Quoted 30 lines · ojab
Quoted 17 lines · Sreekanth Reddy
Quoted 15 lines · ojab
Quoted 10 lines · Sreekanth Reddy
Ojab,
I am checking internally with our FW team and Architect to known whether they aware/observed any issues similar to this (since this issue is nothing to do with driver).
Meanwhile is it possible to provide us the PCI config space and FW logs when issue occurs?
Quoted 7 lines
Quoted 3 lines
AFAIU FW log is enabled when logging_level=0x3f8 is passed to the module,
right?
This is a driver logging_level. Firmware logs can be collected using UART logs.
According to the user guide (from

Quoted 7 lines

Quoted 4 lines
https://www.broadcom.com/products/storage/host-bus-adapters/sas-9217-8i#documentation)
my 9217-8i requires 1.8V UART which I don't have at hand, I'll try to do something on the weekend.
Is anything needed except connecting UART to gather required info?
…actually I have compatible USB UART here. What should be done to get FW log? I've tried to reboot with UART connected (9600N1) but got no output.

You have to use, 115200 instead of 9600 baud rate.

Thanks,
Sreekanth

Quoted 71 lines

//wbr ojab
Quoted 66 lines
Anyway, right now various MPI2 HBAs doesn't work with ASPM enabled, so can this patch be applied in the meantime while we're debugging the issue further? Even if this issue can be properly fixed by FW update, this workaround will be needed for HBAs with affected FW versions.
//wbr ojab
Quoted 46 lines
Quoted 2 lines
Where can I find info about PCI config space?
You can get PCI config space info from lspci command.
Quoted 40 lines
//wbr ojab
Quoted 37 lines
Thanks,
Sreekanth
Quoted 9 lines · ojab
Quoted 6 lines · Sreekanth Reddy
On Fri, Jan 6, 2017 at 7:24 AM, Martin K. Petersen <[email protected]> wrote:
Quoted 15 lines
Quoted 3 lines
Matin, We need some time to review this patch. I will provide my review comments by end of next week.
ping?
//wbr ojab
Quoted 5 lines
Thanks,
Sreekanth
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 5 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

ojab

author

2017-01-17 19:19 UTC #10 lore raw

Quoted 37 lines · Sreekanth Reddy

Quoted 36 lines · ojab
Quoted 34 lines · ojab
Quoted 17 lines · Sreekanth Reddy
Quoted 15 lines · ojab
Quoted 10 lines · Sreekanth Reddy
Ojab,
I am checking internally with our FW team and Architect to known whether they aware/observed any issues similar to this (since this issue is nothing to do with driver).
Meanwhile is it possible to provide us the PCI config space and FW logs when issue occurs?
Quoted 7 lines
Quoted 3 lines
AFAIU FW log is enabled when logging_level=0x3f8 is passed to the module,
right?
This is a driver logging_level. Firmware logs can be collected using UART logs.
According to the user guide (from
https://www.broadcom.com/products/storage/host-bus-adapters/sas-9217-8i#documentation)
my 9217-8i requires 1.8V UART which I don't have at hand, I'll try to do something on the weekend.
Is anything needed except connecting UART to gather required info?

Quoted 4 lines

Quoted 2 lines
…actually I have compatible USB UART here. What should be done to get FW log? I've tried to reboot with UART connected (9600N1) but got no output.
You have to use, 115200 instead of 9600 baud rate.

No output using 115200 8N1 either.
If I connect Bus Pirate to the pins and enable baud autodetect, I see something like

Quoted 2 lines

Calculated: 	117647 bps
Estimated:  	115200 bps

on reboot and firmware/bios upgrade, but there is no text at all. Right now I have IT firmware installed, sas2flash -list shows

Quoted 18 lines

Adapter Selected is a LSI SAS: SAS2308_2(D1)
Controller Number : 0
Controller : SAS2308_2(D1)
PCI Address : 00:02:00:00
SAS Address : 500605b-0-05a6-c320
NVDATA Version (Default) : 14.01.00.06
NVDATA Version (Persistent) : 14.01.00.06
Firmware Product ID : 0x2214 (IT)
Firmware Version : 20.00.07.00
NVDATA Vendor : LSI
NVDATA Product ID : SAS9207-8i
BIOS Version : 07.39.02.00
UEFI BSD Version : 07.27.01.01
FCODE Version : N/A
Board Name : SAS9207-8i
Board Assembly : N/A
Board Tracer Number : N/A

//wbr ojab

Quoted 80 lines

Thanks,
Sreekanth
Quoted 71 lines
//wbr ojab
Quoted 66 lines
Anyway, right now various MPI2 HBAs doesn't work with ASPM enabled, so can this patch be applied in the meantime while we're debugging the issue further? Even if this issue can be properly fixed by FW update, this workaround will be needed for HBAs with affected FW versions.
//wbr ojab
Quoted 46 lines
Quoted 2 lines
Where can I find info about PCI config space?
You can get PCI config space info from lspci command.
Quoted 40 lines
//wbr ojab
Quoted 37 lines
Thanks,
Sreekanth
Quoted 9 lines · ojab
Quoted 6 lines · Sreekanth Reddy
On Fri, Jan 6, 2017 at 7:24 AM, Martin K. Petersen <[email protected]> wrote:
Quoted 15 lines
Quoted 3 lines
Matin, We need some time to review this patch. I will provide my review comments by end of next week.
ping?
//wbr ojab
Quoted 5 lines
Thanks,
Sreekanth
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 5 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

ojab

author

2017-01-23 15:59 UTC #11 lore raw

In reply to ojab

Quoted 5 lines · ojab

MPI2 controllers sometimes got lost (i. e. disappears from /sys/bus/pci/devices) if ASMP is enabled.
Signed-off-by Slava Kardakov <[email protected]>
Fixes https://bugzilla.kernel.org/show_bug.cgi?id=60644

Can I haz Reviewed-by?

//wbr ojab

ojab

author

2017-01-30 10:59 UTC #12 lore raw

Quoted 9 lines · ojab

Quoted 5 lines · ojab
MPI2 controllers sometimes got lost (i. e. disappears from /sys/bus/pci/devices) if ASMP is enabled.
Signed-off-by Slava Kardakov <[email protected]>
Fixes https://bugzilla.kernel.org/show_bug.cgi?id=60644
Can I haz Reviewed-by?

ping?

//wbr ojab

ojab

author

2017-02-06 08:52 UTC #13 lore raw

Quoted 5 lines · ojab

Quoted 4 lines · ojab
Quoted 3 lines · ojab
MPI2 controllers sometimes got lost (i. e. disappears from /sys/bus/pci/devices) if ASMP is enabled.

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
Signed-off-by Slava Kardakov <[email protected]>
Fixes https://bugzilla.kernel.org/show_bug.cgi?id=60644
Can I haz Reviewed-by?
ping?

Humble ping.

//wbr ojab

Sreekanth Reddy

maintainer

2017-02-06 12:02 UTC #14 lore raw

Hi Ojab,

Can I get output of 'lspci -vvv -s' for LSI SAS2 card?

On my Supermicro system, I have enabled ASPM in system BIOS but still in lspci output I see this ASPM was disabled for my SAS2 HBA card which has Phase19 firmware (i.e. 19.00.00.00) as shown below,

# lspci -vvv -s 83:00.0
83:00.0 Serial Attached SCSI controller: LSI Logic / Symbios Logic
SAS2308 PCI-Express Fusion-MPT SAS-2 (rev 05)
    Subsystem: LSI Logic / Symbios Logic SAS2308 PCI-Express Fusion-MPT SAS-2
    Physical Slot: 1-1
    Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR+ FastB2B- DisINTx+
    Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0, Cache Line Size: 32 bytes
    Interrupt: pin A routed to IRQ 40
    Region 0: I/O ports at f000 [size=256]
    Region 1: Memory at fbe40000 (64-bit, non-prefetchable) [size=64K]
    Region 3: Memory at fbe00000 (64-bit, non-prefetchable) [size=256K]
    Expansion ROM at fbd00000 [disabled] [size=1M]
    Capabilities: [50] Power Management version 3
        Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot-,D3cold-)
        Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [68] Express (v2) Endpoint, MSI 00
        DevCap:    MaxPayload 4096 bytes, PhantFunc 0, Latency L0s
<64ns, L1 <1us
            ExtTag+ AttnBtn- AttnInd- PwrInd- RBE+ FLReset+
        DevCtl:    Report errors: Correctable+ Non-Fatal+ Fatal+ Unsupported+
            RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop+ FLReset-
            MaxPayload 256 bytes, MaxReadReq 512 bytes
        DevSta:    CorrErr+ UncorrErr- FatalErr- UnsuppReq+ AuxPwr- TransPend-
        LnkCap:    Port #0, Speed 8GT/s, Width x8, ASPM L0s, Exit
Latency L0s <64ns, L1 <1us
            ClockPM- Surprise- LLActRep- BwNot- ASPMOptComp+
        LnkCtl:    ASPM Disabled; RCB 64 bytes Disabled- CommClk+
            ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
        LnkSta:    Speed 8GT/s, Width x8, TrErr- Train- SlotClk+
DLActive- BWMgmt- ABWMgmt-
        DevCap2: Completion Timeout: Range BC, TimeoutDis+, LTR-, OBFF
Not Supported
        DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis-, LTR-,
OBFF Disabled
        LnkCtl2: Target Link Speed: 8GT/s, EnterCompliance- SpeedDis-
             Transmit Margin: Normal Operating Range,
EnterModifiedCompliance- ComplianceSOS-
             Compliance De-emphasis: -6dB
        LnkSta2: Current De-emphasis Level: -6dB,
EqualizationComplete+, EqualizationPhase1+
             EqualizationPhase2+, EqualizationPhase3+, LinkEqualizationRequest+
    Capabilities: [d0] Vital Product Data
pcilib: sysfs_read_vpd: read failed: Input/output error
        Not readable
    Capabilities: [a8] MSI: Enable- Count=1/1 Maskable- 64bit+
        Address: 0000000000000000  Data: 0000
    Capabilities: [c0] MSI-X: Enable+ Count=16 Masked-
        Vector table: BAR=1 offset=0000e000
        PBA: BAR=1 offset=0000f000
    Capabilities: [100 v2] Advanced Error Reporting
        UESta:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UEMsk:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt-
RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
        UESvrt:    DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt-
RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol-
        CESta:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- NonFatalErr-
        CEMsk:    RxErr- BadTLP- BadDLLP- Rollover- Timeout- NonFatalErr+
        AERCap:    First Error Pointer: 00, GenCap- CGenEn- ChkCap- ChkEn-
    Capabilities: [1e0 v1] #19
    Capabilities: [1c0 v1] Power Budgeting <?>
    Capabilities: [190 v1] #16
    Capabilities: [148 v1] Alternative Routing-ID Interpretation (ARI)
        ARICap:    MFVC- ACS-, Next Function: 0
        ARICtl:    MFVC- ACS-, Function Group: 0
    Kernel driver in use: mpt3sas
    Kernel modules: mpt3sas

So, Can you also try once with Phase19 firmware.

Thanks,
Sreekanth

Quoted 22 lines · ojab

Quoted 8 lines · ojab
Quoted 6 lines · ojab
Quoted 4 lines · ojab
MPI2 controllers sometimes got lost (i. e. disappears from /sys/bus/pci/devices) if ASMP is enabled.
Quoted 9 lines
Quoted 6 lines
Quoted 2 lines
Signed-off-by Slava Kardakov <[email protected]>
Fixes https://bugzilla.kernel.org/show_bug.cgi?id=60644
Can I haz Reviewed-by?
ping?
Humble ping.
//wbr ojab

ojab

author

2017-02-06 12:55 UTC #15 lore raw

Quoted 8 lines · Sreekanth Reddy

Hi Ojab,
Can I get output of 'lspci -vvv -s' for LSI SAS2 card?
On my Supermicro system, I have enabled ASPM in system BIOS but still in lspci output I see this ASPM was disabled for my SAS2 HBA card which has Phase19 firmware (i.e. 19.00.00.00) as shown below,

[snip]

Quoted 2 lines

So, Can you also try once with Phase19 firmware.

How can I downgrade firmware? Right now I have FW 20.00.07.00 installed (lspci output can be found in the attached file), sas2flash -fwall [P19_firmaware.bin] tells me:

Quoted 4 lines

ERROR: Cannot downgrade NVDATA version 14.01.00.06
      to 11.00.110000.00.
ERROR: Failed to get valid NVDATA image from File!

and sas2flash -e 6 tells me

Quoted 1 line

ERROR: Erase Flash Operation Failed!

//wbr ojab

02:00.0 Serial Attached SCSI controller: LSI Logic / Symbios Logic SAS2308 PCI-Express Fusion-MPT SAS-2 (rev 05)
Subsystem: LSI Logic / Symbios Logic Device 3020
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx+
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
Latency: 0, Cache Line Size: 64 bytes
Interrupt: pin A routed to IRQ 19
Region 0: I/O ports at c000 [size=256]
Region 1: Memory at fe7f0000 (64-bit, non-prefetchable) [size=64K]
Region 3: Memory at fe780000 (64-bit, non-prefetchable) [size=256K]
Expansion ROM at fe600000 [disabled] [size=1M]
Capabilities: [50] Power Management version 3
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
Capabilities: [68] Express (v2) Endpoint, MSI 00
DevCap: MaxPayload 4096 bytes, PhantFunc 0, Latency L0s <64ns, L1 <1us
ExtTag+ AttnBtn- AttnInd- PwrInd- RBE+ FLReset+
DevCtl: Report errors: Correctable+ Non-Fatal+ Fatal+ Unsupported+
RlxdOrd- ExtTag+ PhantFunc- AuxPwr- NoSnoop+ FLReset-
MaxPayload 128 bytes, MaxReadReq 512 bytes
DevSta: CorrErr+ UncorrErr- FatalErr- UnsuppReq+ AuxPwr- TransPend-
LnkCap: Port #0, Speed 8GT/s, Width x8, ASPM L0s, Exit Latency L0s <64ns, L1 <1us
ClockPM- Surprise- LLActRep- BwNot-
LnkCtl: ASPM L0s Enabled; RCB 64 bytes Disabled- CommClk+
ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
LnkSta: Speed 5GT/s, Width x8, TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
DevCap2: Completion Timeout: Range BC, TimeoutDis+, LTR-, OBFF Not Supported
DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis-, LTR-, OBFF Disabled
LnkCtl2: Target Link Speed: 8GT/s, EnterCompliance- SpeedDis-
Transmit Margin: Normal Operating Range, EnterModifiedCompliance- ComplianceSOS- Compliance De-emphasis: -6dB
LnkSta2: Current De-emphasis Level: -3.5dB, EqualizationComplete-, EqualizationPhase1-
EqualizationPhase2-, EqualizationPhase3-, LinkEqualizationRequest-
Capabilities: [d0] Vital Product Data
Not readable
Capabilities: [a8] MSI: Enable- Count=1/1 Maskable- 64bit+
Address: 0000000000000000 Data: 0000
Capabilities: [c0] MSI-X: Enable+ Count=16 Masked-
Vector table: BAR=1 offset=0000e000
PBA: BAR=1 offset=0000f000
Capabilities: [100 v2] Advanced Error Reporting
UESta: DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
UEMsk: DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
UESvrt: DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt- RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol-
CESta: RxErr+ BadTLP- BadDLLP+ Rollover- Timeout+ NonFatalErr-
CEMsk: RxErr- BadTLP- BadDLLP- Rollover- Timeout- NonFatalErr+
AERCap: First Error Pointer: 00, GenCap- CGenEn- ChkCap- ChkEn-
Capabilities: [1e0 v1] #19
Capabilities: [1c0 v1] Power Budgeting <?>
Capabilities: [190 v1] #16
Capabilities: [148 v1] Alternative Routing-ID Interpretation (ARI)
ARICap: MFVC- ACS-, Next Function: 0
ARICtl: MFVC- ACS-, Function Group: 0
Kernel driver in use: mpt3sas
Kernel modules: mpt3sas

Sreekanth Reddy

maintainer Acked-by on v2 1/1

2017-02-09 05:09 UTC #16 lore raw

In reply to ojab

Quoted 7 lines · ojab

MPI2 controllers sometimes got lost (i. e. disappears from /sys/bus/pci/devices) if ASMP is enabled.
Signed-off-by Slava Kardakov <[email protected]>
Fixes https://bugzilla.kernel.org/show_bug.cgi?id=60644
From some of our system engineers team, I came to known that ASPM

needs to be disabled.
So this patch looks good. Please consider this patch as

Acked-by Sreekanth Reddy <[email protected]>

Thanks,
Sreekanth

Quoted 38 lines

---
V2: use name in Signed-off-by

Not sure if it's a complete fix, but at least I can't reproduce the issue locally with it applied.

Also it's my first patch, so I've surely screwed up some formatting etc.

 drivers/scsi/mpt3sas/mpt3sas_scsih.c | 3 +++
 1 file changed, 3 insertions(+)

drivers/scsi/mpt3sas/mpt3sas_scsih.c +3 -1

index b5c966e..203651a 100644
@@ -51,6 +51,7 @@
 #include <linux/workqueue.h>
 #include <linux/delay.h>
 #include <linux/pci.h>
+#include <linux/pci-aspm.h>
 #include <linux/interrupt.h>
 #include <linux/aer.h>
 #include <linux/raid_class.h>

@@ -8734,6 +8735,8 @@ _scsih_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 
        switch (hba_mpi_version) {
        case MPI2_VERSION:
+               pci_disable_link_state(pdev, PCIE_LINK_STATE_L0S |
+                       PCIE_LINK_STATE_L1 | PCIE_LINK_STATE_CLKPM);
                /* Use mpt2sas driver host template for SAS 2.0 HBA's */
                shost = scsi_host_alloc(&mpt2sas_driver_template,
                  sizeof(struct MPT3SAS_ADAPTER));
--

2.10.0
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

ojab

author

2017-02-09 10:00 UTC #17 lore raw

Quoted 4 lines · Sreekanth Reddy

Quoted 3 lines · ojab
MPI2 controllers sometimes got lost (i. e. disappears from /sys/bus/pci/devices) if ASMP is enabled.

Quoted 8 lines

Quoted 2 lines
Signed-off-by Slava Kardakov <[email protected]>
Fixes https://bugzilla.kernel.org/show_bug.cgi?id=60644
From some of our system engineers team, I came to known that ASPM needs to be disabled.
So this patch looks good. Please consider this patch as
Acked-by Sreekanth Reddy <[email protected]>

Yay, thanks!

I assume that this patch should also be CC: stable@, since it's clearly a rather critical bugfix.

Is it too late for 4.10.0?

//wbr ojab

Quoted 3 lines

Thanks,
Sreekanth

Martin K. Petersen

Applied

2017-02-09 23:56 UTC #18 lore raw

Quoted 3 lines

Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
"ojab" == ojab <[email protected]> writes:
Acked-by Sreekanth Reddy <[email protected]>

Applied to 4.10/scsi-fixes.

ojab> Is it too late for 4.10.0?

We'll see. Worst case I'll shuffle it over to the 4.11 tree.

Signature · 1 line

Martin K. Petersen	Oracle Linux Engineering