Skip to contentSkip to conversation

Staging: fbtft: hx8340bn: Style fix, octal not decimal permissions

PATCH In review Derek Robson 2 participants 2 messages Jan 4, 2017

Subsystems (2)
Staging Fbtft Framebuffer drivers
lore
Share & tools
lore

Derek Robson

author
#0 lore raw

PATCH 1/1 Staging: fbtft: hx8340bn: Style fix, octal not decimal permissions

Fixed coding style issue, found with Checkpatch.pl changed permissions to octal style.

---
 drivers/staging/fbtft/fb_hx8340bn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fb_hx8340bn.c +1 -1
index 9970ed74bb38..c24331cc179c 100644
@@ -37,7 +37,7 @@
 			"3 3 17 8 4 7 05 7 6 0 3 1 6 0 0 "
 
 static bool emulate;
-module_param(emulate, bool, 0);
+module_param(emulate, bool, 0000);
 MODULE_PARM_DESC(emulate, "Force emulation in 9-bit mode");
 
 static int init_display(struct fbtft_par *par)
Signature · 1 line
2.11.0
#1 lore raw
Quoted 2 lines · Derek Robson

Fixed coding style issue, found with Checkpatch.pl changed permissions to octal style.

You missed SoB.

drivers/staging/fbtft/fb_hx8340bn.c line 40

Quoted 6 lines
drivers/staging/fbtft/fb_hx8340bn.c +1 -1
@@ -37,7 +37,7 @@
                        "3 3 17 8 4 7 05 7 6 0 3 1 6 0 0 "
 
 static bool emulate;
-module_param(emulate, bool, 0);
+module_param(emulate, bool, 0000);

Why not to allow reading as well?

Quoted 1 line
drivers/staging/fbtft/fb_hx8340bn.c +0 -0
 MODULE_PARM_DESC(emulate, "Force emulation in 9-bit mode");
Signature · 2 lines
With Best Regards,
Andy Shevchenko