ata: sata_mv: Convert to devm_ioremap_resource()
PATCH 1/1 ata: sata_mv: Convert to devm_ioremap_resource()
Convert to devm_ioremap_resource() which provides more consistent error handling.
Note that devm_ioremap_resource() provides its own error messages.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/ata/sata_mv.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)
drivers/ata/sata_mv.c +5 -8
@@ -4067,6 +4067,7 @@ static int mv_platform_probe(struct platform_device *pdev)struct ata_host *host;struct mv_host_priv *hpriv;struct resource *res; +void __iomem *mmio;int n_ports =0 , irq =0 ;int rc;int port;
@@ -4085,8 +4086,9 @@ static int mv_platform_probe(struct platform_device *pdev)* Get the register base first */ res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); -if (res ==NULL ) -return -EINVAL ; + mmio =devm_ioremap_resource (&pdev->dev, res); +if (IS_ERR (mmio)) +return PTR_ERR (mmio);/* allocate host */ if (pdev->dev.of_node) {
@@ -4130,12 +4132,7 @@ static int mv_platform_probe(struct platform_device *pdev) hpriv->board_idx = chip_soc; host->iomap =NULL ; - hpriv->base =devm_ioremap (&pdev->dev, res->start, -resource_size (res)); -if (!hpriv->base) -return -ENOMEM ; - - hpriv->base -=SATAHC0_REG_BASE ; + hpriv->base = mmio -SATAHC0_REG_BASE ; hpriv->clk =clk_get (&pdev->dev,NULL );if (IS_ERR (hpriv->clk))
Signature · 1 line
2.11.0
Tejun Heo
AppliedQuoted 6 lines · Andy Shevchenko
Convert to
devm_ioremap_resource()which provides more consistent error handling.Note that
devm_ioremap_resource()provides its own error messages.Signed-off-by Andy Shevchenko <[email protected]>
Applied to libata/for-4.11.
Thanks.
Signature · 1 line
tejun