Skip to contentSkip to conversation

MAINTAINERS: Add maintainer for TI security related files

PATCH In review Andrew F. Davis 3 participants 4 messages Jan 11, 2017 – Jan 15, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: Add maintainer for TI security related files

Changes involving High-Security boards should be CC'd for additional assessment of the security implications.

---
Recently some fastboot additions have been made that may effect security on our HS boards by letting some boot methods work around our chain-of- trust. It would be nice to get a CC for changes that directly effect these HS boards so I have a chance to check for this kind of thing.

 MAINTAINERS | 11 +++++++++++
 1 file changed, 11 insertions(+)
MAINTAINERS +11 -0
index 793ff49f68..1ea7ae013a 100644
@@ -434,6 +434,17 @@ S:	Maintained
 F:	drivers/spmi/
 F:	include/spmi/
 
+TI SYSTEM SECURITY
+M:	Andrew F. Davis <[email protected]>
+S:	Supported
+F:	arch/arm/mach-omap2/omap5/sec_entry_cpu1.S
+F:	arch/arm/mach-omap2/omap5/sec-fxns.c
+F:	arch/arm/mach-omap2/sec-common.c
+F:	arch/arm/mach-omap2/config_secure.mk
+F:	configs/am43xx_hs_evm_defconfig
+F:	configs/am57xx_hs_evm_defconfig
+F:	configs/dra7xx_hs_evm_defconfig
+
 TQ GROUP
 #M:	Martin Krause <[email protected]>
 S:	Orphaned (Since 2016-02)
Signature · 1 line
2.11.0
#1 lore raw
Quoted 4 lines · Andrew F. Davis

Changes involving High-Security boards should be CC'd for additional assessment of the security implications.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170115/8c652124/attachment.sig>
#2 lore raw

PATCH 1/1 MAINTAINERS: Add maintainer for TI security related files

In reply to Andrew F. Davis
Quoted 21 lines · Andrew F. Davis

Changes involving High-Security boards should be CC'd for additional assessment of the security implications.

---
Recently some fastboot additions have been made that may effect security on our HS boards by letting some boot methods work around our chain-of- trust. It would be nice to get a CC for changes that directly effect these HS boards so I have a chance to check for this kind of thing.

 MAINTAINERS | 11 +++++++++++
 1 file changed, 11 insertions(+)
MAINTAINERS +0 -0
index 793ff49f68..1ea7ae013a 100644
@@ -434,6 +434,17 @@ S: Maintained
 F:     drivers/spmi/
 F:     include/spmi/
 

MAINTAINERS S: Maintained · line 446

Quoted 10 lines
MAINTAINERS +10 -0
+TI SYSTEM SECURITY
+M:     Andrew F. Davis <[email protected]>
+S:     Supported
+F:     arch/arm/mach-omap2/omap5/sec_entry_cpu1.S
+F:     arch/arm/mach-omap2/omap5/sec-fxns.c
+F:     arch/arm/mach-omap2/sec-common.c
+F:     arch/arm/mach-omap2/config_secure.mk
+F:     configs/am43xx_hs_evm_defconfig
+F:     configs/am57xx_hs_evm_defconfig
+F:     configs/dra7xx_hs_evm_defconfig

I thought of commenting this but some how missed, configs/*_defconfig files shouldn't be part of MAINTAINERS it has a separate file in respective boards.

thanks!

Signature · 4 lines
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
#3 lore raw

PATCH 1/1 MAINTAINERS: Add maintainer for TI security related files

Quoted 22 lines · Jagan Teki
Quoted 21 lines · Andrew F. Davis

Changes involving High-Security boards should be CC'd for additional assessment of the security implications.

---
Recently some fastboot additions have been made that may effect security on our HS boards by letting some boot methods work around our chain-of- trust. It would be nice to get a CC for changes that directly effect these HS boards so I have a chance to check for this kind of thing.

 MAINTAINERS | 11 +++++++++++
 1 file changed, 11 insertions(+)
MAINTAINERS +0 -0
index 793ff49f68..1ea7ae013a 100644
@@ -434,6 +434,17 @@ S: Maintained
 F:     drivers/spmi/
 F:     include/spmi/
 
Quoted 14 lines

MAINTAINERS S: Maintained · line 446

Quoted 10 lines
MAINTAINERS +10 -0
+TI SYSTEM SECURITY
+M:     Andrew F. Davis <[email protected]>
+S:     Supported
+F:     arch/arm/mach-omap2/omap5/sec_entry_cpu1.S
+F:     arch/arm/mach-omap2/omap5/sec-fxns.c
+F:     arch/arm/mach-omap2/sec-common.c
+F:     arch/arm/mach-omap2/config_secure.mk
+F:     configs/am43xx_hs_evm_defconfig
+F:     configs/am57xx_hs_evm_defconfig
+F:     configs/dra7xx_hs_evm_defconfig

I thought of commenting this but some how missed, configs/*_defconfig files shouldn't be part of MAINTAINERS it has a separate file in respective boards.

I'm indifferent in cases like this. For example, dra7xx_hs_evm has two maintainers, Andrew (due to the security side) and Lokesh (who owns the TI ref platforms in general). Making Andrew edit 3 (4 with the am335x_hs_evm_defconfig coming soon) MAINTAINERS files to add 4 lines each won't add to the clarity of things as get_maintainer.pl should do the correct thing and list both, today.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170115/f7195501/attachment.sig>