staging:r8188eu: remove unused (GET|PUT)U32 macros
PATCH 1/7 staging:r8188eu: remove unused (GET|PUT)U32 macros
(GET|PUT)U32 macros are unused, remove it.
--- drivers/staging/rtl8188eu/include/rtw_security.h | 7 ------- 1 file changed, 7 deletions(-)
drivers/staging/rtl8188eu/include/rtw_security.h +0 -7
@@ -255,13 +255,6 @@ static inline u32 rotr(u32 val, int bits)#define TE2 (i) rotr(Te0[((i) >> 8) & 0xff], 16)#define TE3 (i) rotr(Te0[(i) & 0xff], 24) -#define GETU32 (pt) (((u32)(pt)[0] << 24) ^ ((u32)(pt)[1] << 16) ^ \ - ((u32)(pt)[2] << 8) ^ ((u32)(pt)[3])) - -#define PUTU32 (ct, st) { \ -(ct)[0] = (u8)((st) >> 24); (ct)[1] = (u8)((st) >> 16); \ -(ct)[2] = (u8)((st) >> 8); (ct)[3] = (u8)(st); } -#define WPA_GET_BE32 (a) ((((u32)(a)[0]) << 24) | (((u32)(a)[1]) << 16) | \ (((u32)(a)[2]) << 8) | ((u32)(a)[3]))
Signature · 1 line
2.10.2
PATCH 2/7 staging:r8188eu: remove unused WPA_(GET|PUT)_(BE|LE)_xx macro
WPA_(GET|PUT)_(BE|LE)_xx macros are unused, remove it.
--- drivers/staging/rtl8188eu/include/rtw_security.h | 29 ------------------------ 1 file changed, 29 deletions(-)
drivers/staging/rtl8188eu/include/rtw_security.h +0 -29
@@ -255,35 +255,6 @@ static inline u32 rotr(u32 val, int bits)#define TE2 (i) rotr(Te0[((i) >> 8) & 0xff], 16)#define TE3 (i) rotr(Te0[(i) & 0xff], 24) -#define WPA_GET_BE32 (a) ((((u32)(a)[0]) << 24) | (((u32)(a)[1]) << 16) | \ - (((u32)(a)[2]) << 8) | ((u32)(a)[3])) - -#define WPA_PUT_LE16 (a, val) \ - do { \ - (a)[1] = ((u16)(val)) >> 8; \ - (a)[0] = ((u16)(val)) & 0xff; \ - } while (0) - -#define WPA_PUT_BE32 (a, val) \ - do { \ - (a)[0] = (u8)((((u32)(val)) >> 24) & 0xff); \ - (a)[1] = (u8)((((u32)(val)) >> 16) & 0xff); \ - (a)[2] = (u8)((((u32)(val)) >> 8) & 0xff); \ - (a)[3] = (u8)(((u32)(val)) & 0xff); \ - } while (0) - -#define WPA_PUT_BE64 (a, val) \ - do { \ - (a)[0] = (u8)(((u64)(val)) >> 56); \ - (a)[1] = (u8)(((u64)(val)) >> 48); \ - (a)[2] = (u8)(((u64)(val)) >> 40); \ - (a)[3] = (u8)(((u64)(val)) >> 32); \ - (a)[4] = (u8)(((u64)(val)) >> 24); \ - (a)[5] = (u8)(((u64)(val)) >> 16); \ - (a)[6] = (u8)(((u64)(val)) >> 8); \ - (a)[7] = (u8)(((u64)(val)) & 0xff); \ - } while (0) -/* ===== start - public domain SHA256 implementation ===== */ /* This is based on SHA256 implementation in LibTomCrypt that was released into
Signature · 1 line
2.10.2
PATCH 3/7 staging:r8188eu: remove unused EOR macro
In reply to Ivan SafonovEOR macro is not unused, remove it.
--- drivers/staging/rtl8188eu/include/rtw_recv.h | 2 -- 1 file changed, 2 deletions(-)
drivers/staging/rtl8188eu/include/rtw_recv.h +0 -2
@@ -151,8 +151,6 @@ struct recv_stat {__le32 rxdw5; }; -#define EOR BIT(30) -/* accesser of recv_priv: rtw_recv_entry(dispatch / passive level); recv_thread(passive) ; returnpkt(dispatch)
Signature · 1 line
2.10.2
PATCH 4/7 staging:r8188eu: remove unused get_rxmem()
In reply to Ivan Safonovget_rxmem() is not unused, remove it.
--- drivers/staging/rtl8188eu/include/rtw_recv.h | 8 -------- 1 file changed, 8 deletions(-)
drivers/staging/rtl8188eu/include/rtw_recv.h +0 -8
@@ -254,14 +254,6 @@ u32 rtw_free_uc_swdec_pending_queue(struct adapter *adapter);void rtw_reordering_ctrl_timeout_handler (unsigned long data); -static inline u8 *get_rxmem (struct recv_frame *precvframe) -{ -/* always return rx_head... */ -if (precvframe ==NULL ) -return NULL ; -return precvframe->rx_head; -} -static inline u8 *recvframe_pull (struct recv_frame *precvframe,int sz) {/* rx_data += sz; move rx_data sz bytes hereafter */
Signature · 1 line
2.10.2
PATCH 5/7 staging:r8188eu: remove unused struct wifidirect_info and all corresponding code
In reply to Ivan Safonovwifidirect_info structure is unused.
Big amount of another definitions used only for wifidirect_info definition. Remove all.
--- drivers/staging/rtl8188eu/include/rtw_mlme.h | 177 --------------------------- drivers/staging/rtl8188eu/include/wifi.h | 84 ------------- 2 files changed, 261 deletions(-)
drivers/staging/rtl8188eu/include/rtw_mlme.h +0 -177
@@ -107,183 +107,6 @@ struct rt_link_detect {* to Tx traffic. */ }; -struct profile_info { -u8 ssidlen; -u8 ssid[WLAN_SSID_MAXLEN ]; -u8 peermac[ETH_ALEN ]; -}; - -struct tx_invite_req_info { -u8 token; -u8 benable; -u8 go_ssid[WLAN_SSID_MAXLEN ]; -u8 ssidlen; -u8 go_bssid[ETH_ALEN ]; -u8 peer_macaddr[ETH_ALEN ]; -u8 operating_ch;/* This information will be set by using the -* p2p_set op_ch=x */ -u8 peer_ch;/* The listen channel for peer P2P device */ -}; - -struct tx_invite_resp_info { -u8 token;/* Used to record the dialog token of p2p invitation -* request frame. */ -}; - -struct tx_provdisc_req_info { -u16 wps_config_method_request;/* Used when sending the -* provisioning request frame*/ -u16 peer_channel_num[2 ];/* The channel number which the -* receiver stands. */ -struct ndis_802_11_ssid ssid; -u8 peerDevAddr[ETH_ALEN ];/* Peer device address */ -u8 peerIFAddr[ETH_ALEN ];/* Peer interface address */ -u8 benable;/* This provision discovery -* request frame is trigger -* to send or not */ -}; - -/* When peer device issue prov_disc_req first, we should store the following -* information */ -/* The UI must know this information to know which config method the -* remote p2p device needs. */ -struct rx_provdisc_req_info { -u8 peerDevAddr[ETH_ALEN ];/* Peer device address */ -u8 strconfig_method_desc_of_prov_disc_req[4 ];/* description -* for the config method located in the provisioning -* discovery request frame. */ -}; - -struct tx_nego_req_info { -u16 peer_channel_num[2 ];/* The channel number. */ -u8 peerDevAddr[ETH_ALEN ];/* Peer device address */ -u8 benable;/* This negotiation request frame is -* trigger to send or not */ -}; - -struct group_id_info { -u8 go_device_addr[ETH_ALEN ];/* The GO's device address of -* this P2P group */ -u8 ssid[WLAN_SSID_MAXLEN ];/* The SSID of this P2P group */ -}; - -struct scan_limit_info { -u8 scan_op_ch_only;/* When this flag is set, the driver -* should only scan the op. channel */ -u8 operation_ch[2 ];/* Store the op. chan of invitation */ -}; - -struct wifidirect_info { -struct adapter *padapter; -struct timer_list find_phase_timer; -struct timer_list restore_p2p_state_timer; - -/* Used to do the scanning. After confirming the peer is availalble, -* the driver transmits the P2P frame to peer. */ -struct timer_list pre_tx_scan_timer; -struct timer_list reset_ch_sitesurvey; -struct timer_list reset_ch_sitesurvey2;/* Just for resetting the scan -* limit function by using p2p nego */ -struct tx_provdisc_req_info tx_prov_disc_info; -struct rx_provdisc_req_info rx_prov_disc_info; -struct tx_invite_req_info invitereq_info; -/* Store the profile information of persistent group */ -struct profile_info profileinfo[P2P_MAX_PERSISTENT_GROUP_NUM ]; -struct tx_invite_resp_info inviteresp_info; -struct tx_nego_req_info nego_req_info; -/* Store the group id info when doing the group negot handshake. */ -struct group_id_info groupid_info; -/* Used for get the limit scan channel from the Invitation procedure */ -struct scan_limit_info rx_invitereq_info; -/* Used for get the limit scan chan from the P2P negotiation handshake*/ -struct scan_limit_info p2p_info; -enum P2P_ROLE role; -enum P2P_STATE pre_p2p_state; -enum P2P_STATE p2p_state; -/* The device address should be the mac address of this device. */ -u8 device_addr[ETH_ALEN ]; -u8 interface_addr[ETH_ALEN ]; -u8 social_chan[4 ]; -u8 listen_channel; -u8 operating_channel; -u8 listen_dwell;/* This value should be between 1 and 3 */ -u8 support_rate[8 ]; -u8 p2p_wildcard_ssid[P2P_WILDCARD_SSID_LEN ]; -u8 intent;/* should only include the intent value. */ -u8 p2p_peer_interface_addr[ETH_ALEN ]; -u8 p2p_peer_device_addr[ETH_ALEN ]; -u8 peer_intent;/* Included the intent value and tie breaker value. */ -/* Device name for displaying on searching device screen */ -u8 device_name[WPS_MAX_DEVICE_NAME_LEN ]; -u8 device_name_len; -u8 profileindex;/* Used to point to the index of profileinfo array */ -u8 peer_operating_ch; -u8 find_phase_state_exchange_cnt; -/* The device password ID for group negotiation */ -u16 device_password_id_for_nego; -u8 negotiation_dialog_token; -/* SSID information for group negotitation */ -u8 nego_ssid[WLAN_SSID_MAXLEN ]; -u8 nego_ssidlen; -u8 p2p_group_ssid[WLAN_SSID_MAXLEN ]; -u8 p2p_group_ssid_len; -/* Flag to know if the persistent function should be supported or not.*/ -u8 persistent_supported; -/* In the Sigma test, the Sigma will provide this enable from the -* sta_set_p2p CAPI. */ -/* 0: disable */ -/* 1: enable */ -u8 session_available;/* Flag to set the WFD session available to -* enable or disable "by Sigma" */ -/* In the Sigma test, the Sigma will disable the session available -* by using the sta_preset CAPI. */ -/* 0: disable */ -/* 1: enable */ -u8 wfd_tdls_enable;/* Flag to enable or disable the TDLS by WFD Sigma*/ -/* 0: disable */ -/* 1: enable */ -u8 wfd_tdls_weaksec;/* Flag to enable or disable the weak security -* function for TDLS by WFD Sigma */ -/* 0: disable */ -/* In this case, the driver can't issue the tdsl -* setup request frame. */ -/* 1: enable */ -/* In this case, the driver can issue the tdls -* setup request frame */ -/* even the current security is weak security. */ - -/* This field will store the WPS value (PIN value or PBC) that UI had -* got from the user. */ -enum P2P_WPSINFO ui_got_wps_info; -u16 supported_wps_cm;/* This field describes the WPS config method -* which this driver supported. */ -/* The value should be the combination of config -* method defined in page104 of WPS v2.0 spec.*/ -/* This field will contain the length of body of P2P Channel List -* attribute of group negotiation response frame. */ -uint channel_list_attr_len; -/* This field will contain the body of P2P Channel List attribute of -* group negotitation response frame. */ -/* We will use the channel_cnt and channel_list fields when constructing -* the group negotiation confirm frame. */ -u8 channel_list_attr[100 ]; -enum P2P_PS_MODE p2p_ps_mode;/* indicate p2p ps mode */ -enum P2P_PS_STATE p2p_ps_state;/* indicate p2p ps state */ -u8 noa_index;/* Identifies and instance of Notice of Absence timing. */ -u8 ctwindow;/* Client traffic window. A period of time in TU after TBTT. */ -u8 opp_ps;/* opportunistic power save. */ -u8 noa_num;/* number of NoA descriptor in P2P IE. */ -u8 noa_count[P2P_MAX_NOA_NUM ];/* Count for owner, Type of client. */ -/* Max duration for owner, preferred or min acceptable duration for -* client. */ -u32 noa_duration[P2P_MAX_NOA_NUM ]; -/* Length of interval for owner, preferred or max acceptable interval -* of client. */ -u32 noa_interval[P2P_MAX_NOA_NUM ]; -/* schedule expressed in terms of the lower 4 bytes of the TSF timer. */ -u32 noa_start_time[P2P_MAX_NOA_NUM ]; -}; -struct mlme_priv {spinlock_t lock;int fw_state;/* shall we protect this variable? maybe not necessarily... */
drivers/staging/rtl8188eu/include/wifi.h +0 -84
122 lines not on this page · raw message
Signature · 1 line
2.10.2
PATCH 6/7 staging:r8188eu: remove unnecessary trace output in rtw_recv_indicatepkt()
In reply to Ivan SafonovTrace output for each received packet in rtw_recv_indicatepkt() is redudant. Remove it.
--- drivers/staging/rtl8188eu/os_dep/recv_linux.c | 15 --------------- 1 file changed, 15 deletions(-)
drivers/staging/rtl8188eu/os_dep/recv_linux.c +0 -15
@@ -88,27 +88,12 @@ int rtw_recv_indicatepkt(struct adapter *padapter, goto _recv_indicatepkt_drop; } -RT_TRACE (_module_recv_osdep_c_, _drv_info_, - ("rtw_recv_indicatepkt():skb != NULL !!!\n" )); -RT_TRACE (_module_recv_osdep_c_, _drv_info_, - ("rtw_recv_indicatepkt():precv_frame->rx_head =%p precv_frame->hdr.rx_data =%p\n" , - precv_frame->rx_head, precv_frame->rx_data)); -RT_TRACE (_module_recv_osdep_c_, _drv_info_, - ("precv_frame->hdr.rx_tail =%p precv_frame->rx_end =%p precv_frame->hdr.len =%d\n" , - precv_frame->rx_tail, precv_frame->rx_end, - precv_frame->len)); - skb->data = precv_frame->rx_data;skb_set_tail_pointer (skb, precv_frame->len); skb->len = precv_frame->len; -RT_TRACE (_module_recv_osdep_c_, _drv_info_, - ("skb->head =%p skb->data =%p skb->tail =%p skb->end =%p skb->len =%d\n" , - skb->head, skb->data,skb_tail_pointer (skb), -skb_end_pointer (skb), skb->len)); -if (check_fwstate (pmlmepriv,WIFI_AP_STATE )) {struct sk_buff *pskb2 =NULL ;struct sta_info *psta =NULL ;
Signature · 1 line
2.10.2
PATCH 7/7 staging:r8188eu: remove unused rx_head member of struct recv_frame
In reply to Ivan SafonovValue of rx_head member of struct recv_frame does not used. Remove it.
--- drivers/staging/rtl8188eu/include/rtw_recv.h | 1 - drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 - 2 files changed, 2 deletions(-)
drivers/staging/rtl8188eu/include/rtw_recv.h +0 -1
@@ -229,7 +229,6 @@ struct recv_frame {struct adapter *adapter;struct rx_pkt_attrib attrib;uint len; -u8 *rx_head;u8 *rx_data;u8 *rx_tail;u8 *rx_end;
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c +0 -1
@@ -125,7 +125,6 @@ static int recvbuf2recvframe(struct adapter *adapt, struct sk_buff *pskb)if (pkt_copy) { pkt_copy->dev = adapt->pnetdev; precvframe->pkt = pkt_copy; - precvframe->rx_head = pkt_copy->data; precvframe->rx_end = pkt_copy->data + alloc_sz;skb_reserve (pkt_copy,8 - ((size_t )(pkt_copy->data) &7 ));/* force pkt_copy->data at 8-byte alignment address */ skb_reserve (pkt_copy, shift_sz);/* force ip_hdr at 8-byte alignment address according to shift_sz. */
Signature · 1 line
2.10.2