Skip to contentSkip to conversation

drm/atomic: make release_crtc_commit() static

PATCH In review Wei Yongjun 3 participants 3 messages Jan 12, 2017 – Jan 23, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/atomic: make release_crtc_commit() static

From: Wei Yongjun <[email protected]>

Fixes the following sparse warning:

drivers/gpu/drm/drm_atomic_helper.c:1360:6: warning:
symbol 'release_crtc_commit' was not declared. Should it be static?

---
 drivers/gpu/drm/drm_atomic_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_atomic_helper.c +1 -1
index 7b71ac4..e2e5a74 100644
@@ -1357,7 +1357,7 @@ static int stall_checks(struct drm_crtc *crtc, bool nonblock)
 	return ret < 0 ? ret : 0;
 }
 
-void release_crtc_commit(struct completion *completion)
+static void release_crtc_commit(struct completion *completion)
 {
 	struct drm_crtc_commit *commit = container_of(completion,
 						      typeof(*commit),
Reviewed-by on v1 1/1
#1 lore raw

Hi Wei,

2017-01-12 Wei Yongjun <[email protected]>:

Quoted 11 lines

From: Wei Yongjun <[email protected]>

Fixes the following sparse warning:

drivers/gpu/drm/drm_atomic_helper.c:1360:6: warning:
symbol 'release_crtc_commit' was not declared. Should it be static?

---
 drivers/gpu/drm/drm_atomic_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Gustavo

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw
Quoted 11 lines · Gustavo Padovan

Hi Wei,

2017-01-12 Wei Yongjun <[email protected]>:

Quoted 7 lines

From: Wei Yongjun <[email protected]>

Fixes the following sparse warning:

drivers/gpu/drm/drm_atomic_helper.c:1360:6: warning:
symbol 'release_crtc_commit' was not declared. Should it be static?

Quoted 6 lines
Quoted 4 lines
---
 drivers/gpu/drm/drm_atomic_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for the patch, applied to drm-misc.

Gustavo, for next time around please just use your commit rights when reviewing a simple patch like this :-)
-Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch