Skip to contentSkip to conversation

soc: ti: wkup_m3_ipc: Fix error return code in wkup_m3_ipc_probe()

PATCH In review Wei Yongjun 2 participants 2 messages Jan 12, 2017 TI Keystone multicore navigator drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: ti: wkup_m3_ipc: Fix error return code in wkup_m3_ipc_probe()

From: Wei Yongjun <[email protected]>

Fix to return a negative error code from the kthread_run() error handling case instead of 0, as done elsewhere in this function.

Fixes cdd5de500b2c ("soc: ti: Add wkup_m3_ipc driver")
---
 drivers/soc/ti/wkup_m3_ipc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/soc/ti/wkup_m3_ipc.c +1 -0
index 8bfa44b..369aef5 100644
@@ -457,6 +457,7 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev)
 
 	if (IS_ERR(task)) {
 		dev_err(dev, "can't create rproc_boot thread\n");
+		ret = PTR_ERR(task);
 		goto err_put_rproc;
 	}
#1 lore raw
Quoted 17 lines · Wei Yongjun

From: Wei Yongjun <[email protected]>

Fix to return a negative error code from the kthread_run() error handling case instead of 0, as done elsewhere in this function.

Fixes cdd5de500b2c ("soc: ti: Add wkup_m3_ipc driver")
---
 drivers/soc/ti/wkup_m3_ipc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/soc/ti/wkup_m3_ipc.c +0 -0
index 8bfa44b..369aef5 100644

drivers/soc/ti/wkup_m3_ipc.c static int wkup_m3_ipc_probe(struct platform_device *pdev) · line 463

Quoted 7 lines
drivers/soc/ti/wkup_m3_ipc.c +1 -0
@@ -457,6 +457,7 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev)
 
 	if (IS_ERR(task)) {
 		dev_err(dev, "can't create rproc_boot thread\n");
+		ret = PTR_ERR(task);
 		goto err_put_rproc;
 	}
 

Applying into omap-for-v4.10/fixes thanks.

Tony