Nokia N900: mixers changed between 4.6 and 4.10, no longer can use in-call speaker
Hi!
In v4.10 (and probably v4.9, too) I can no longer use the in-call speaker. I can no longer use the wired headset, either.
v4.4 (and probably v4.6) works ok.
Any ideas? Does wired headset / in-call speaker work for you?
"Mono" and "Mono DAC" options are still there.. but something else changed, as alsamixer now shows way many more options (meaning they are shorter?) and I get complains from alsactl:
alsactl: set_control:1328: failed to obtain info for control #49 (No such file or directory)
...
alsactl: set_control:1328: failed to obtain info for control #229 (No such file or directory)
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 21 lines · On Thursday 12 January 2017 19:18:26 Pavel Machek wrote:
Hi!
In v4.10 (and probably v4.9, too) I can no longer use the in-call speaker. I can no longer use the wired headset, either.
v4.4 (and probably v4.6) works ok.
Any ideas? Does wired headset / in-call speaker work for you?
"Mono" and "Mono DAC" options are still there.. but something else changed, as alsamixer now shows way many more options (meaning they are shorter?) and I get complains from alsactl:
alsactl: set_control:1328: failed to obtain info for control #49 (No such file or directory)
...
alsactl: set_control:1328: failed to obtain info for control #229 (No such file or directory)
Quoted 1 line
Pavel
Looks like there are not so much commits related to sound/soc/omap/rx51.c Maybe it can be one of these twos?
cb7e62256e99d285e415cf75db67558f0f8bb1076d2de5ab4328718302c54b20222c6b1a574c3fce
Signature · 2 lines
Pali Rohár [email protected]
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: Nokia N900: mixers changed between 4.9 and 4.10-rc3, no longer can use in-call speaker
Hi!
Quoted 17 lines
Quoted 11 lines
In v4.10 (and probably v4.9, too) I can no longer use the in-call speaker. I can no longer use the wired headset, either.
v4.4 (and probably v4.6) works ok.
Any ideas? Does wired headset / in-call speaker work for you?
"Mono" and "Mono DAC" options are still there.. but something else changed, as alsamixer now shows way many more options (meaning they are shorter?) and I get complains from alsactl:
Quoted 5 lines
alsactl: set_control:1328: failed to obtain info for control #49 (No such file or directory)
...
alsactl: set_control:1328: failed to obtain info for control #229 (No such file or directory)
Quoted 5 lines
Looks like there are not so much commits related to
sound/soc/omap/rx51.cMaybe it can be one of these twos?
cb7e62256e99d285e415cf75db67558f0f8bb1076d2de5ab4328718302c54b20222c6b1a574c3fce
Both are based on v4.7-rc1. v4.6 worked ok for me.
Lets test mini-v4.7: in-call speaker works ok there, and no alsactl warnings.
mini-v4.7+cb7e62256e99d285e415cf75db67558f0f8bb107+6d2de5ab4328718302c54b20222c6b1a574c3fce : something seems to be broken there already.
alsactl: set_control:1464: Cannot write control '2:0:0:TPA6130A2 Headphone Playback Volume:0' : Remote I/O error
But in-call speakers and wired headset still seems to work.
Lets test mini-v4.9... works ok. I don't even get the remote i/o error. Interesting.
So regression seems to be between v4.9 and v4.10. Any ideas?
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Re: Nokia N900: mixers changed between 4.9 and 4.10-rc3, no longer can use in-call speaker
Quoted 38 lines · On Saturday 14 January 2017 23:56:15 Pavel Machek wrote:
Hi!
Quoted 17 lines
Quoted 11 lines
In v4.10 (and probably v4.9, too) I can no longer use the in-call speaker. I can no longer use the wired headset, either.
v4.4 (and probably v4.6) works ok.
Any ideas? Does wired headset / in-call speaker work for you?
"Mono" and "Mono DAC" options are still there.. but something else changed, as alsamixer now shows way many more options (meaning they are shorter?) and I get complains from alsactl:
Quoted 5 lines
alsactl: set_control:1328: failed to obtain info for control #49 (No such file or directory)
...
alsactl: set_control:1328: failed to obtain info for control #229 (No such file or directory)Quoted 5 lines
Looks like there are not so much commits related to
sound/soc/omap/rx51.cMaybe it can be one of these twos?
cb7e62256e99d285e415cf75db67558f0f8bb1076d2de5ab4328718302c54b20222c6b1a574c3fceBoth are based on v4.7-rc1. v4.6 worked ok for me.
Lets test mini-v4.7: in-call speaker works ok there, and no alsactl warnings.
mini-v4.7+cb7e62256e99d285e415cf75db67558f0f8bb107+6d2de5ab4328718302
c54b20222c6b1a574c3fce: something seems to be broken there already.
alsactl: set_control:1464: Cannot write control '2:0:0:TPA6130A2 Headphone Playback Volume:0' : Remote I/O error
Quoted 6 lines
But in-call speakers and wired headset still seems to work.
Lets test mini-v4.9... works ok. I don't even get the remote i/o error. Interesting.
So regression seems to be between v4.9 and v4.10. Any ideas?
Interesting... seems there are no sound relevant changes after v4.9.
Looks like there are only three commits after v4.9 for sound/soc which are built for Nokia N900:
e411b0b5eb9b65257a050eac333d181d6e00e2c6e7aa450fe17890e59db7d3c2d8eff5b6b41fc53163c3194b82530bd71fd49db84eb7ab656b8d404a
Maybe something not related to sound/soc could broke it?
Signature · 2 lines
Pali Rohár [email protected]
Re: Nokia N900: mixers changed between 4.9 and 4.10-rc3, no longer can use in-call speaker
Hi!
Quoted 22 lines
Quoted 13 lines
Both are based on v4.7-rc1. v4.6 worked ok for me.
Lets test mini-v4.7: in-call speaker works ok there, and no alsactl warnings.
mini-v4.7+cb7e62256e99d285e415cf75db67558f0f8bb107+6d2de5ab4328718302
c54b20222c6b1a574c3fce: something seems to be broken there already.
alsactl: set_control:1464: Cannot write control '2:0:0:TPA6130A2 Headphone Playback Volume:0' : Remote I/O error
Quoted 6 lines
But in-call speakers and wired headset still seems to work.
Lets test mini-v4.9... works ok. I don't even get the remote i/o error. Interesting.
So regression seems to be between v4.9 and v4.10. Any ideas?
Interesting... seems there are no sound relevant changes after v4.9.
Quoted 8 lines
Looks like there are only three commits after v4.9 for
sound/socwhich are built for Nokia N900:
e411b0b5eb9b65257a050eac333d181d6e00e2c6e7aa450fe17890e59db7d3c2d8eff5b6b41fc53163c3194b82530bd71fd49db84eb7ab656b8d404aMaybe something not related to
sound/soccould broke it?
Lets see.
a9042defa29a01cc538b742eab047848e9b5ae14 -- works ok. ce38207f161513ee3d2bd3860489f07ebe65bc78 --
alsactl: set_control:1328: failed to obtain info for control #229 (No such file or directory)
and broken in-call speaker. So this merge breaks stuff:
commit ce38207f161513ee3d2bd3860489f07ebe65bc78
Merge: a9042de 995c6a7
Author: Linus Torvalds <[email protected]>
Date: Wed Dec 14 11:14:28 2016 -0800
Merge tag 'sound-4.10-rc1' of
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound...
Below are some highlights:
ASoC:
- support for stereo DAPM controls
- some initial work on the of-graph sound card
- regmap conversions of the remaining AC'97
drivers
- a new version of the topology ABI; this should be
backward
compatible
- updates / cleanups of rsnd, sunxi, sti,
nau8825, samsung, arizona,
Intel skylake, atom-sst
- new drivers for Cirrus Logic CS42L42, Qualcomm
MSM8916-WCD, and
Realtek RT5665
...
Best regards,
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Re: Nokia N900: mixers changed between 4.9 and 4.10-rc3, no longer can use in-call speaker
Quoted 13 lines · Pavel Machek
Quoted 4 lines
Quoted 1 line
So regression seems to be between v4.9 and v4.10. Any ideas?
Interesting... seems there are no sound relevant changes after v4.9.
Quoted 8 lines
Looks like there are only three commits after v4.9 for
sound/socwhich are built for Nokia N900:
e411b0b5eb9b65257a050eac333d181d6e00e2c6e7aa450fe17890e59db7d3c2d8eff5b6b41fc53163c3194b82530bd71fd49db84eb7ab656b8d404aMaybe something not related to
sound/soccould broke it?
Quoted 8 lines
Lets see.
a9042defa29a01cc538b742eab047848e9b5ae14-- works ok.ce38207f161513ee3d2bd3860489f07ebe65bc78--alsactl: set_control:1328: failed to obtain info for control #229 (No such file or directory)
I'm unable to test older kernels at the moment since modules don't load by some reason (bluetooth: Unknown symbol _GLOBAL_OFFSET_TABLE_ (err 0)). Probably some recent regression in my debian/testing installation since the same configs were working before.
However v4.9.4 works and with it I can see there is an issue with these aic3x controls:
amixer: Unable to find simple control 'Left DAC_L1 Mixer Line',0
amixer: Unable to find simple control 'Right DAC_R1 Mixer Line',0
At quick look I don't see why above commits could cause it. Maybe regression happened earlier between v4.6 and v4.9?
Signature · 1 line
Jarkko
Re: Nokia N900: mixers changed between 4.9 and 4.10-rc3, no longer can use in-call speaker
Quoted 27 lines · Jarkko Nikula
Quoted 13 lines · Pavel Machek
Quoted 4 lines
Quoted 1 line
So regression seems to be between v4.9 and v4.10. Any ideas?
Interesting... seems there are no sound relevant changes after v4.9.
Quoted 8 lines
Looks like there are only three commits after v4.9 for
sound/socwhich are built for Nokia N900:
e411b0b5eb9b65257a050eac333d181d6e00e2c6e7aa450fe17890e59db7d3c2d8eff5b6b41fc53163c3194b82530bd71fd49db84eb7ab656b8d404aMaybe something not related to
sound/soccould broke it?Quoted 8 lines
Lets see.
a9042defa29a01cc538b742eab047848e9b5ae14-- works ok.ce38207f161513ee3d2bd3860489f07ebe65bc78--alsactl: set_control:1328: failed to obtain info for control #229 (No such file or directory)
I'm unable to test older kernels at the moment since modules don't load by some reason (bluetooth: Unknown symbol _GLOBAL_OFFSET_TABLE_ (err 0)). Probably some recent regression in my debian/testing installation since the same configs were working before.
Quoted 8 lines
However v4.9.4 works and with it I can see there is an issue with these aic3x controls:
amixer: Unable to find simple control 'Left
DAC_L1Mixer Line',0amixer: Unable to find simple control 'Right
DAC_R1Mixer Line',0
These are certainly not the regression between 4.6 and 4.9, more like more like regression since 2.6:
'Line Switch' -> 'LineL Switch':54f01916297bafc18bd7df4e2300a0544a84fce3
'LineL Switch' -> 'DACL1 Switch':c3b79e05b4d9ab2e7c3ba281261ea87ab5b71a92
Quoted 2 lines
At quick look I don't see why above commits could cause it. Maybe regression happened earlier between v4.6 and v4.9?
It might be that there were some work to fix control names for different aic versions to match with the HW or support for new codec is added and some control gone missing for 3x?
I would compare the 'amixer controls' for the working and regressed kernel to see what differs. From there git blame or smthing will for sure point to the correct commit.
Signature · 1 line
Péter
Re: Nokia N900: mixers changed between 4.9 and 4.10-rc3, no longer can use in-call speaker
Quoted 10 lines · Peter Ujfalusi
Quoted 8 lines · Jarkko Nikula
However v4.9.4 works and with it I can see there is an issue with these aic3x controls:
amixer: Unable to find simple control 'Left
DAC_L1Mixer Line',0amixer: Unable to find simple control 'Right
DAC_R1Mixer Line',0
Quoted 8 lines
These are certainly not the regression between 4.6 and 4.9, more like more like regression since 2.6:
'Line Switch' -> 'LineL Switch':54f01916297bafc18bd7df4e2300a0544a84fce3'LineL Switch' -> 'DACL1 Switch':
c3b79e05b4d9ab2e7c3ba281261ea87ab5b71a92
You are right. Those mixer scripts were for Maemo 2.6.28 kernel and dated 2009... grr, looks like I've overwritten my N900 mixer scripts at some point.
Fortunately the issue seems to be fixed in v4.10-rc4.
Signature · 1 line
Jarkko
Nokia N900: microphone mixers
Hi!
Do you have any idea how to control the microphone? I'd like the audio source to be microphone on headset (not the built in one). So I run alsamixer, set everything in "capture" section to zero... and I still get the audio from the internal microphone :-(.
Tested with arecord | aplay.
Any ideas?
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Re: Nokia N900: microphone mixers
Quoted 10 lines · On Friday 20 January 2017 14:31:59 Pavel Machek wrote:
Hi!
Do you have any idea how to control the microphone? I'd like the audio source to be microphone on headset (not the built in one). So I run alsamixer, set everything in "capture" section to zero... and I still get the audio from the internal microphone :-(.
Tested with arecord | aplay.
Any ideas?
Hi! Try to set Jack Function to Headset or enable b HS Mic.
Signature · 2 lines
Pali Rohár [email protected]
Re: Nokia N900: microphone mixers
Quoted 8 lines · Pali Rohár
Quoted 7 lines · On Friday 20 January 2017 14:31:59 Pavel Machek wrote:
Hi!
Do you have any idea how to control the microphone? I'd like the audio source to be microphone on headset (not the built in one). So I run alsamixer, set everything in "capture" section to zero... and I still get the audio from the internal microphone :-(.
Quoted 5 lines
Quoted 3 lines
Tested with arecord | aplay.
Any ideas?
Hi! Try to set Jack Function to Headset or enable b HS Mic.
I can't find "b HS Mic" function. I can set "Input Select" to "ADC", and ten internal microphone is off, but I can't get any audio on input. I tried with "Jack function" both "headset" and "headphone".
Do I need to enable microphone bias voltage somewhere?
Best regards,
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Re: Nokia N900: microphone mixers
Quoted 13 lines · On Friday 20 January 2017 15:00:47 Pavel Machek wrote:
Quoted 12 lines · Pali Rohár
Quoted 10 lines · On Friday 20 January 2017 14:31:59 Pavel Machek wrote:
Hi!
Do you have any idea how to control the microphone? I'd like the audio source to be microphone on headset (not the built in one). So I run alsamixer, set everything in "capture" section to zero... and I still get the audio from the internal microphone :-(.
Tested with arecord | aplay.
Any ideas?
Quoted 7 lines
Quoted 1 line
Hi! Try to set Jack Function to Headset or enable b HS Mic.
I can't find "b HS Mic" function. I can set "Input Select" to "ADC", and ten internal microphone is off, but I can't get any audio on input. I tried with "Jack function" both "headset" and "headphone".
Do I need to enable microphone bias voltage somewhere?
When you set Jack function to headset it automatically enable HS Mic control which controls mic bias.
If Jack function in headset mode does not work, then there is bug. Try older versions of kernel...
Signature · 7 lines
Pali Rohár [email protected] _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: Nokia N900: microphone mixers
Quoted 20 lines · Pali Rohár
Quoted 19 lines · On Friday 20 January 2017 15:00:47 Pavel Machek wrote:
Quoted 8 lines · Pali Rohár
Quoted 7 lines · On Friday 20 January 2017 14:31:59 Pavel Machek wrote:
Hi!
Do you have any idea how to control the microphone? I'd like the audio source to be microphone on headset (not the built in one). So I run alsamixer, set everything in "capture" section to zero... and I still get the audio from the internal microphone :-(.
Quoted 5 lines
Quoted 3 lines
Tested with arecord | aplay.
Any ideas?
Hi! Try to set Jack Function to Headset or enable b HS Mic.
I can't find "b HS Mic" function. I can set "Input Select" to "ADC", and ten internal microphone is off, but I can't get any audio on input. I tried with "Jack function" both "headset" and "headphone".
Quoted 7 lines
Quoted 1 line
Do I need to enable microphone bias voltage somewhere?
When you set Jack function to headset it automatically enable HS Mic control which controls mic bias.
If Jack function in headset mode does not work, then there is bug. Try older versions of kernel...
Would you know which mainline kernel version is "known good"?
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Re: Nokia N900: mixers changed between 4.9 and 4.10-rc3, no longer can use in-call speaker
In reply to Pali RohárHi!
Quoted 6 lines
Quoted 1 line
So regression seems to be between v4.9 and v4.10. Any ideas?
Interesting... seems there are no sound relevant changes after v4.9.
Looks like there are only three commits after v4.9 for
sound/socwhich are built for Nokia N900:
I'm at ce38207f161513ee3d2bd3860489f07ebe65bc78, which is already broken, and first broken commit by Linus.
Quoted 1 line
e411b0b5eb9b65257a050eac333d181d6e00e2c6
Can't revert that easily.
Quoted 1 line
e7aa450fe17890e59db7d3c2d8eff5b6b41fc531
This can be reverted. Lets try. Did not help.
Quoted 1 line
63c3194b82530bd71fd49db84eb7ab656b8d404a
Commit older than this one fails, IIRC.
Quoted 1 line
Maybe something not related to
sound/soccould broke it?
Its definitely caused by something merged here:
commit ce38207f161513ee3d2bd3860489f07ebe65bc78
Merge: a9042de 995c6a7
Author: Linus Torvalds <[email protected]>
Date: Wed Dec 14 11:14:28 2016 -0800
So it should be easy to find out..
Best regards,
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: Nokia N900: mixers changed between 4.9 and 4.10-rc3, no longer can use in-call speaker
Hi!
Quoted 6 lines
Quoted 6 lines
Quoted 1 line
So regression seems to be between v4.9 and v4.10. Any ideas?
Interesting... seems there are no sound relevant changes after v4.9.
Looks like there are only three commits after v4.9 for
sound/socwhich are built for Nokia N900:
...
Quoted 8 lines
Its definitely caused by something merged here:
commit
ce38207f161513ee3d2bd3860489f07ebe65bc78
Merge: a9042de 995c6a7
Author: Linus Torvalds <[email protected]>
Date: Wed Dec 14 11:14:28 2016 -0800So it should be easy to find out..
Doing git bisect now. Hmmm.
pavel@amd:/data/l/linux-n900$ git bisect bad 1a653aa44725668590b36bbe2d7fe4736a69f055 is the first bad commit commit 1a653aa44725668590b36bbe2d7fe4736a69f055 Author: Kuninori Morimoto <[email protected]> Date: Wed Nov 30 06:22:55 2016 +0000
ASoC: core: replace aux_comp_list to component_dev_list
Now, Card has component_dev_list, we can replace aux_comp_list
to component_dev_list with new auxiliary flags
Signed-off-by: Kuninori Morimoto
<[email protected]>
:040000 040000 a571fa05e5ce8e00b73bbc3f1e30e26775d619e8e9336929cacf2d7bc94da99acfc10c9a7f513b8b M include
:040000 040000 87976e9406d452e791870cc12e27cb67ba04fd1260d36f685642621c0e3ebb61ba7a14186d8b3eb0 M sound
pavel@amd:/data/l/linux-n900$
I'll try reverting this patch on top of 4.10-rc, next. Any other ideas?
Best regards,
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: Nokia N900: mixers changed between 4.9 and 4.10-rc3, no longer can use in-call speaker
Hi!
Quoted 33 lines
Quoted 6 lines
Quoted 6 lines
Quoted 1 line
So regression seems to be between v4.9 and v4.10. Any ideas?
Interesting... seems there are no sound relevant changes after v4.9.
Looks like there are only three commits after v4.9 for
sound/socwhich are built for Nokia N900:...
Quoted 8 lines
Its definitely caused by something merged here:
commit
ce38207f161513ee3d2bd3860489f07ebe65bc78
Merge: a9042de 995c6a7
Author: Linus Torvalds <[email protected]>
Date: Wed Dec 14 11:14:28 2016 -0800So it should be easy to find out..
Doing git bisect now. Hmmm.
pavel@amd:/data/l/linux-n900$ git bisect bad 1a653aa44725668590b36bbe2d7fe4736a69f055 is the first bad commit commit 1a653aa44725668590b36bbe2d7fe4736a69f055 Author: Kuninori Morimoto <[email protected]> Date: Wed Nov 30 06:22:55 2016 +0000ASoC: core: replace
aux_comp_listtocomponent_dev_listNow, Card has
component_dev_list, we can replaceaux_comp_list
tocomponent_dev_listwith new auxiliary flagsSigned-off-by: Kuninori Morimoto
<[email protected]>Signed-off-by Mark Brown <[email protected]>
Quoted 7 lines
:040000 040000
a571fa05e5ce8e00b73bbc3f1e30e26775d619e8e9336929cacf2d7bc94da99acfc10c9a7f513b8bM include
:040000 04000087976e9406d452e791870cc12e27cb67ba04fd1260d36f685642621c0e3ebb61ba7a14186d8b3eb0M sound
pavel@amd:/data/l/linux-n900$I'll try reverting this patch on top of 4.10-rc, next. Any other ideas?
Reverting that fixed the issue, but when I re-checked current -rc4, it seems it has similar fix there, too. GOod.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: Nokia N900: mixers changed between 4.9 and 4.10-rc3, no longer can use in-call speaker
Hi Pavel
Quoted 21 lines
Quoted 21 lines
pavel@amd:/data/l/linux-n900$ git bisect bad 1a653aa44725668590b36bbe2d7fe4736a69f055 is the first bad commit commit 1a653aa44725668590b36bbe2d7fe4736a69f055 Author: Kuninori Morimoto <[email protected]> Date: Wed Nov 30 06:22:55 2016 +0000ASoC: core: replace
aux_comp_listtocomponent_dev_listNow, Card has
component_dev_list, we can replaceaux_comp_list
tocomponent_dev_listwith new auxiliary flagsSigned-off-by: Kuninori Morimoto
<[email protected]>Signed-off-by Mark Brown <[email protected]>:040000 040000
a571fa05e5ce8e00b73bbc3f1e30e26775d619e8e9336929cacf2d7bc94da99acfc10c9a7f513b8bM include
:040000 04000087976e9406d452e791870cc12e27cb67ba04fd1260d36f685642621c0e3ebb61ba7a14186d8b3eb0M sound
pavel@amd:/data/l/linux-n900$
Quoted 4 lines
Quoted 1 line
I'll try reverting this patch on top of 4.10-rc, next. Any other ideas?
Reverting that fixed the issue, but when I re-checked current -rc4, it seems it has similar fix there, too. GOod.
Sorry about my fault, thanks to Sylwester for fixing it
Best regards
---
Kuninori Morimoto