Skip to contentSkip to conversation

defconfig: Add a config for AM335x High Security EVM

PATCH Superseded Andrew F. Davis 3 participants 11 messages Jan 16, 2017 – Jan 22, 2017

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 defconfig: Add a config for AM335x High Security EVM

Add a new defconfig file for the AM335x High Security EVM. This config is specific for the case of memory device booting. Memory device booting is handled separatly from peripheral booting on HS devices as the load address changes.

This defconfig is the same as for the non-secure part, except for:
CONFIG_TI_SECURE_DEVICE option set to 'y' CONFIG_ISW_ENTRY_ADDR updated for secure images. CONFIG_FIT_IMAGE_POST_PROCESS option set to 'y' CONFIG_SPL_FIT_IMAGE_POST_PROCESS option set to 'y' CONFIG_USE_TINY_PRINTF option set to 'y' to reduce SPL size CONFIG_SPL_SYS_MALLOC_SIMPLE set to 'y' to reduce SPL size

---

Changes from v1:
- Add to MAINTAINERS file

 MAINTAINERS                     |  1 +
 configs/am335x_hs_evm_defconfig | 62 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+)
 create mode 100644 configs/am335x_hs_evm_defconfig
MAINTAINERS +1 -0
index 1ea7ae013a..788e16a391 100644
@@ -441,6 +441,7 @@ F:	arch/arm/mach-omap2/omap5/sec_entry_cpu1.S
 F:	arch/arm/mach-omap2/omap5/sec-fxns.c
 F:	arch/arm/mach-omap2/sec-common.c
 F:	arch/arm/mach-omap2/config_secure.mk
+F:	configs/am335x_hs_evm_defconfig
 F:	configs/am43xx_hs_evm_defconfig
 F:	configs/am57xx_hs_evm_defconfig
 F:	configs/dra7xx_hs_evm_defconfig
configs/am335x_hs_evm_defconfig new file +62 -0

62 lines not on this page · raw message

Signature · 1 line
2.11.0
#1 lore raw

PATCH v2 1/1 defconfig: Add a config for AM335x High Security EVM

Quoted 13 lines · Andrew F. Davis

Add a new defconfig file for the AM335x High Security EVM. This config is specific for the case of memory device booting. Memory device booting is handled separatly from peripheral booting on HS devices as the load address changes.

This defconfig is the same as for the non-secure part, except for:
CONFIG_TI_SECURE_DEVICE option set to 'y' CONFIG_ISW_ENTRY_ADDR updated for secure images. CONFIG_FIT_IMAGE_POST_PROCESS option set to 'y' CONFIG_SPL_FIT_IMAGE_POST_PROCESS option set to 'y' CONFIG_USE_TINY_PRINTF option set to 'y' to reduce SPL size CONFIG_SPL_SYS_MALLOC_SIMPLE set to 'y' to reduce SPL size

Quoted 1 line
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170116/c028be3c/attachment.sig>
#2 lore raw

PATCH v2 1/1 defconfig: Add a config for AM335x High Security EVM

In reply to Andrew F. Davis
Quoted 68 lines · Andrew F. Davis

Add a new defconfig file for the AM335x High Security EVM. This config is specific for the case of memory device booting. Memory device booting is handled separatly from peripheral booting on HS devices as the load address changes.

This defconfig is the same as for the non-secure part, except for:
CONFIG_TI_SECURE_DEVICE option set to 'y' CONFIG_ISW_ENTRY_ADDR updated for secure images. CONFIG_FIT_IMAGE_POST_PROCESS option set to 'y' CONFIG_SPL_FIT_IMAGE_POST_PROCESS option set to 'y' CONFIG_USE_TINY_PRINTF option set to 'y' to reduce SPL size CONFIG_SPL_SYS_MALLOC_SIMPLE set to 'y' to reduce SPL size

---

Changes from v1:
- Add to MAINTAINERS file

 MAINTAINERS                     |  1 +
 configs/am335x_hs_evm_defconfig | 62 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+)
 create mode 100644 configs/am335x_hs_evm_defconfig
MAINTAINERS +1 -0
index 1ea7ae013a..788e16a391 100644
@@ -441,6 +441,7 @@ F:	arch/arm/mach-omap2/omap5/sec_entry_cpu1.S
 F:	arch/arm/mach-omap2/omap5/sec-fxns.c
 F:	arch/arm/mach-omap2/sec-common.c
 F:	arch/arm/mach-omap2/config_secure.mk
+F:	configs/am335x_hs_evm_defconfig
 F:	configs/am43xx_hs_evm_defconfig
 F:	configs/am57xx_hs_evm_defconfig
 F:	configs/dra7xx_hs_evm_defconfig
configs/am335x_hs_evm_defconfig new file +26 -0
new file mode 100644
index 0000000000..f8445c3249
@@ -0,0 +1,62 @@
+CONFIG_ARM=y
+CONFIG_AM33XX=y
+CONFIG_TI_SECURE_DEVICE=y
+# CONFIG_SPL_EXT_SUPPORT is not set
+# CONFIG_SPL_NAND_SUPPORT is not set
+CONFIG_TARGET_AM335X_EVM=y
+CONFIG_ISW_ENTRY_ADDR=0x40300350
+CONFIG_SPL_STACK_R_ADDR=0x82000000
+# CONFIG_SPL_YMODEM_SUPPORT is not set
+CONFIG_DEFAULT_DEVICE_TREE="am335x-evm"
+CONFIG_DISTRO_DEFAULTS=y
+CONFIG_FIT=y
+CONFIG_SYS_EXTRA_OPTIONS="NAND"
+CONFIG_SPL_LOAD_FIT=y
+CONFIG_SPL_FIT_IMAGE_POST_PROCESS=y
+CONFIG_FIT_IMAGE_POST_PROCESS=y
+CONFIG_SYS_CONSOLE_INFO_QUIET=y
+CONFIG_VERSION_VARIABLE=y
+CONFIG_SPL=y
+CONFIG_SPL_SYS_MALLOC_SIMPLE=y
+CONFIG_SPL_STACK_R=y
+CONFIG_SPL_MTD_SUPPORT=y
+# CONFIG_CMD_IMLS is not set
+CONFIG_CMD_ASKENV=y
+# CONFIG_CMD_FLASH is not set
+CONFIG_CMD_MMC=y

configs/am335x_hs_evm_defconfig line 36

Quoted 10 lines
configs/am335x_hs_evm_defconfig new file +10 -0
+CONFIG_CMD_SF=y
+CONFIG_CMD_SPI=y
+CONFIG_CMD_I2C=y
+CONFIG_CMD_USB=y
+CONFIG_CMD_DFU=y
+CONFIG_CMD_GPIO=y
+# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_OF_CONTROL=y
+CONFIG_OF_LIST="am335x-evm am335x-bone am335x-boneblack am335x-evmsk am335x-bonegreen am335x-icev2"

Just wondering, do we have HS variants of all these boards? If not we can just keep am335x-evm.

Thanks and regards,
Lokesh

#3 lore raw

PATCH v2 1/1 defconfig: Add a config for AM335x High Security EVM

Quoted 76 lines · Lokesh Vutla
Quoted 73 lines · Andrew F. Davis

Add a new defconfig file for the AM335x High Security EVM. This config is specific for the case of memory device booting. Memory device booting is handled separatly from peripheral booting on HS devices as the load address changes.

This defconfig is the same as for the non-secure part, except for:
CONFIG_TI_SECURE_DEVICE option set to 'y' CONFIG_ISW_ENTRY_ADDR updated for secure images. CONFIG_FIT_IMAGE_POST_PROCESS option set to 'y' CONFIG_SPL_FIT_IMAGE_POST_PROCESS option set to 'y' CONFIG_USE_TINY_PRINTF option set to 'y' to reduce SPL size CONFIG_SPL_SYS_MALLOC_SIMPLE set to 'y' to reduce SPL size

---

Changes from v1:
- Add to MAINTAINERS file

 MAINTAINERS                     |  1 +
 configs/am335x_hs_evm_defconfig | 62 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+)
 create mode 100644 configs/am335x_hs_evm_defconfig
MAINTAINERS +1 -0
index 1ea7ae013a..788e16a391 100644
@@ -441,6 +441,7 @@ F:	arch/arm/mach-omap2/omap5/sec_entry_cpu1.S
 F:	arch/arm/mach-omap2/omap5/sec-fxns.c
 F:	arch/arm/mach-omap2/sec-common.c
 F:	arch/arm/mach-omap2/config_secure.mk
+F:	configs/am335x_hs_evm_defconfig
 F:	configs/am43xx_hs_evm_defconfig
 F:	configs/am57xx_hs_evm_defconfig
 F:	configs/dra7xx_hs_evm_defconfig
configs/am335x_hs_evm_defconfig new file +31 -0
new file mode 100644
index 0000000000..f8445c3249
@@ -0,0 +1,62 @@
+CONFIG_ARM=y
+CONFIG_AM33XX=y
+CONFIG_TI_SECURE_DEVICE=y
+# CONFIG_SPL_EXT_SUPPORT is not set
+# CONFIG_SPL_NAND_SUPPORT is not set
+CONFIG_TARGET_AM335X_EVM=y
+CONFIG_ISW_ENTRY_ADDR=0x40300350
+CONFIG_SPL_STACK_R_ADDR=0x82000000
+# CONFIG_SPL_YMODEM_SUPPORT is not set
+CONFIG_DEFAULT_DEVICE_TREE="am335x-evm"
+CONFIG_DISTRO_DEFAULTS=y
+CONFIG_FIT=y
+CONFIG_SYS_EXTRA_OPTIONS="NAND"
+CONFIG_SPL_LOAD_FIT=y
+CONFIG_SPL_FIT_IMAGE_POST_PROCESS=y
+CONFIG_FIT_IMAGE_POST_PROCESS=y
+CONFIG_SYS_CONSOLE_INFO_QUIET=y
+CONFIG_VERSION_VARIABLE=y
+CONFIG_SPL=y
+CONFIG_SPL_SYS_MALLOC_SIMPLE=y
+CONFIG_SPL_STACK_R=y
+CONFIG_SPL_MTD_SUPPORT=y
+# CONFIG_CMD_IMLS is not set
+CONFIG_CMD_ASKENV=y
+# CONFIG_CMD_FLASH is not set
+CONFIG_CMD_MMC=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_SPI=y
+CONFIG_CMD_I2C=y
+CONFIG_CMD_USB=y
+CONFIG_CMD_DFU=y
Quoted 9 lines

configs/am335x_hs_evm_defconfig line 36

Quoted 5 lines
configs/am335x_hs_evm_defconfig new file +5 -0
+CONFIG_CMD_GPIO=y
+# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_OF_CONTROL=y
+CONFIG_OF_LIST="am335x-evm am335x-bone am335x-boneblack am335x-evmsk am335x-bonegreen am335x-icev2"

Just wondering, do we have HS variants of all these boards? If not we can just keep am335x-evm.

We don't "technically" have HS vs non-HS versions of any board, the boards are the same, the non-HS ones simply have the security features locked out. If the silicon they put on any of these boards is not locked out then it becomes an HS board.

But, yes, I only know of unlocked AM335x's currently being placed on the standard EVMs for now.

Andrew

#4 lore raw

PATCH v2 1/1 defconfig: Add a config for AM335x High Security EVM

Quoted 87 lines · Andrew F. Davis
Quoted 76 lines · Lokesh Vutla
Quoted 73 lines · Andrew F. Davis

Add a new defconfig file for the AM335x High Security EVM. This config is specific for the case of memory device booting. Memory device booting is handled separatly from peripheral booting on HS devices as the load address changes.

This defconfig is the same as for the non-secure part, except for:
CONFIG_TI_SECURE_DEVICE option set to 'y' CONFIG_ISW_ENTRY_ADDR updated for secure images. CONFIG_FIT_IMAGE_POST_PROCESS option set to 'y' CONFIG_SPL_FIT_IMAGE_POST_PROCESS option set to 'y' CONFIG_USE_TINY_PRINTF option set to 'y' to reduce SPL size CONFIG_SPL_SYS_MALLOC_SIMPLE set to 'y' to reduce SPL size

---

Changes from v1:
- Add to MAINTAINERS file

 MAINTAINERS                     |  1 +
 configs/am335x_hs_evm_defconfig | 62 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+)
 create mode 100644 configs/am335x_hs_evm_defconfig
MAINTAINERS +1 -0
index 1ea7ae013a..788e16a391 100644
@@ -441,6 +441,7 @@ F:	arch/arm/mach-omap2/omap5/sec_entry_cpu1.S
 F:	arch/arm/mach-omap2/omap5/sec-fxns.c
 F:	arch/arm/mach-omap2/sec-common.c
 F:	arch/arm/mach-omap2/config_secure.mk
+F:	configs/am335x_hs_evm_defconfig
 F:	configs/am43xx_hs_evm_defconfig
 F:	configs/am57xx_hs_evm_defconfig
 F:	configs/dra7xx_hs_evm_defconfig
configs/am335x_hs_evm_defconfig new file +31 -0
new file mode 100644
index 0000000000..f8445c3249
@@ -0,0 +1,62 @@
+CONFIG_ARM=y
+CONFIG_AM33XX=y
+CONFIG_TI_SECURE_DEVICE=y
+# CONFIG_SPL_EXT_SUPPORT is not set
+# CONFIG_SPL_NAND_SUPPORT is not set
+CONFIG_TARGET_AM335X_EVM=y
+CONFIG_ISW_ENTRY_ADDR=0x40300350
+CONFIG_SPL_STACK_R_ADDR=0x82000000
+# CONFIG_SPL_YMODEM_SUPPORT is not set
+CONFIG_DEFAULT_DEVICE_TREE="am335x-evm"
+CONFIG_DISTRO_DEFAULTS=y
+CONFIG_FIT=y
+CONFIG_SYS_EXTRA_OPTIONS="NAND"
+CONFIG_SPL_LOAD_FIT=y
+CONFIG_SPL_FIT_IMAGE_POST_PROCESS=y
+CONFIG_FIT_IMAGE_POST_PROCESS=y
+CONFIG_SYS_CONSOLE_INFO_QUIET=y
+CONFIG_VERSION_VARIABLE=y
+CONFIG_SPL=y
+CONFIG_SPL_SYS_MALLOC_SIMPLE=y
+CONFIG_SPL_STACK_R=y
+CONFIG_SPL_MTD_SUPPORT=y
+# CONFIG_CMD_IMLS is not set
+CONFIG_CMD_ASKENV=y
+# CONFIG_CMD_FLASH is not set
+CONFIG_CMD_MMC=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_SPI=y
+CONFIG_CMD_I2C=y
+CONFIG_CMD_USB=y
+CONFIG_CMD_DFU=y
Quoted 9 lines

configs/am335x_hs_evm_defconfig line 36

Quoted 5 lines
configs/am335x_hs_evm_defconfig new file +5 -0
+CONFIG_CMD_GPIO=y
+# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_OF_CONTROL=y
+CONFIG_OF_LIST="am335x-evm am335x-bone am335x-boneblack am335x-evmsk am335x-bonegreen am335x-icev2"

Just wondering, do we have HS variants of all these boards? If not we can just keep am335x-evm.

Quoted 4 lines

We don't "technically" have HS vs non-HS versions of any board, the boards are the same, the non-HS ones simply have the security features locked out. If the silicon they put on any of these boards is not locked out then it becomes an HS board.

Thanks.

Quoted 4 lines

But, yes, I only know of unlocked AM335x's currently being placed on the standard EVMs for now.

okay. Then drop all the other dtbs from the list.

Thanks and regards,
Lokesh

Quoted 2 lines

Andrew

#5 lore raw

PATCH v2 1/1 defconfig: Add a config for AM335x High Security EVM

Quoted 95 lines · Lokesh Vutla
Quoted 87 lines · Andrew F. Davis
Quoted 76 lines · Lokesh Vutla
Quoted 73 lines · Andrew F. Davis

Add a new defconfig file for the AM335x High Security EVM. This config is specific for the case of memory device booting. Memory device booting is handled separatly from peripheral booting on HS devices as the load address changes.

This defconfig is the same as for the non-secure part, except for:
CONFIG_TI_SECURE_DEVICE option set to 'y' CONFIG_ISW_ENTRY_ADDR updated for secure images. CONFIG_FIT_IMAGE_POST_PROCESS option set to 'y' CONFIG_SPL_FIT_IMAGE_POST_PROCESS option set to 'y' CONFIG_USE_TINY_PRINTF option set to 'y' to reduce SPL size CONFIG_SPL_SYS_MALLOC_SIMPLE set to 'y' to reduce SPL size

---

Changes from v1:
- Add to MAINTAINERS file

 MAINTAINERS                     |  1 +
 configs/am335x_hs_evm_defconfig | 62 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+)
 create mode 100644 configs/am335x_hs_evm_defconfig
MAINTAINERS +1 -0
index 1ea7ae013a..788e16a391 100644
@@ -441,6 +441,7 @@ F:	arch/arm/mach-omap2/omap5/sec_entry_cpu1.S
 F:	arch/arm/mach-omap2/omap5/sec-fxns.c
 F:	arch/arm/mach-omap2/sec-common.c
 F:	arch/arm/mach-omap2/config_secure.mk
+F:	configs/am335x_hs_evm_defconfig
 F:	configs/am43xx_hs_evm_defconfig
 F:	configs/am57xx_hs_evm_defconfig
 F:	configs/dra7xx_hs_evm_defconfig
configs/am335x_hs_evm_defconfig new file +31 -0
new file mode 100644
index 0000000000..f8445c3249
@@ -0,0 +1,62 @@
+CONFIG_ARM=y
+CONFIG_AM33XX=y
+CONFIG_TI_SECURE_DEVICE=y
+# CONFIG_SPL_EXT_SUPPORT is not set
+# CONFIG_SPL_NAND_SUPPORT is not set
+CONFIG_TARGET_AM335X_EVM=y
+CONFIG_ISW_ENTRY_ADDR=0x40300350
+CONFIG_SPL_STACK_R_ADDR=0x82000000
+# CONFIG_SPL_YMODEM_SUPPORT is not set
+CONFIG_DEFAULT_DEVICE_TREE="am335x-evm"
+CONFIG_DISTRO_DEFAULTS=y
+CONFIG_FIT=y
+CONFIG_SYS_EXTRA_OPTIONS="NAND"
+CONFIG_SPL_LOAD_FIT=y
+CONFIG_SPL_FIT_IMAGE_POST_PROCESS=y
+CONFIG_FIT_IMAGE_POST_PROCESS=y
+CONFIG_SYS_CONSOLE_INFO_QUIET=y
+CONFIG_VERSION_VARIABLE=y
+CONFIG_SPL=y
+CONFIG_SPL_SYS_MALLOC_SIMPLE=y
+CONFIG_SPL_STACK_R=y
+CONFIG_SPL_MTD_SUPPORT=y
+# CONFIG_CMD_IMLS is not set
+CONFIG_CMD_ASKENV=y
+# CONFIG_CMD_FLASH is not set
+CONFIG_CMD_MMC=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_SPI=y
+CONFIG_CMD_I2C=y
+CONFIG_CMD_USB=y
+CONFIG_CMD_DFU=y
Quoted 9 lines

configs/am335x_hs_evm_defconfig line 36

Quoted 5 lines
configs/am335x_hs_evm_defconfig new file +5 -0
+CONFIG_CMD_GPIO=y
+# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_OF_CONTROL=y
+CONFIG_OF_LIST="am335x-evm am335x-bone am335x-boneblack am335x-evmsk am335x-bonegreen am335x-icev2"

Just wondering, do we have HS variants of all these boards? If not we can just keep am335x-evm.

Quoted 4 lines

We don't "technically" have HS vs non-HS versions of any board, the boards are the same, the non-HS ones simply have the security features locked out. If the silicon they put on any of these boards is not locked out then it becomes an HS board.

Quoted 8 lines

Thanks.

Quoted 4 lines

But, yes, I only know of unlocked AM335x's currently being placed on the standard EVMs for now.

okay. Then drop all the other dtbs from the list.

I'm not sure what that would get us, the differences between non-HS and HS have nothing to do with the devices on the boards. This will only create a support burden if someone gets an unlocked Beaglebone for instance. Why limit the *more* feature-full chip? HS chips needs to be thought of as they are, a superset of the non-HS chips, not as a different kind of chip.

Andrew

Quoted 5 lines

Thanks and regards,
Lokesh

Quoted 2 lines

Andrew

#6 lore raw

PATCH v2 1/1 defconfig: Add a config for AM335x High Security EVM

[..snip..]

Quoted 20 lines
Quoted 11 lines
Quoted 10 lines
Quoted 5 lines
Quoted 1 line

+CONFIG_OF_LIST="am335x-evm am335x-bone am335x-boneblack am335x-evmsk am335x-bonegreen am335x-icev2"

Just wondering, do we have HS variants of all these boards? If not we can just keep am335x-evm.

We don't "technically" have HS vs non-HS versions of any board, the boards are the same, the non-HS ones simply have the security features locked out. If the silicon they put on any of these boards is not locked out then it becomes an HS board.

Quoted 8 lines

Thanks.

Quoted 4 lines

But, yes, I only know of unlocked AM335x's currently being placed on the standard EVMs for now.

okay. Then drop all the other dtbs from the list.

Quoted 6 lines

I'm not sure what that would get us, the differences between non-HS and HS have nothing to do with the devices on the boards. This will only create a support burden if someone gets an unlocked Beaglebone for instance. Why limit the *more* feature-full chip? HS chips needs to be thought of as they are, a superset of the non-HS chips, not as a different kind of chip.

Is this officially supported? Have you tested before posting?

If no then there should not be any argument for adding this support assuming this can possibly be useful or experimental.

Thanks and regards,
Lokesh

#7 lore raw

PATCH v2 1/1 defconfig: Add a config for AM335x High Security EVM

In reply to Andrew F. Davis

[..snip..]

Quoted 20 lines
Quoted 11 lines
Quoted 10 lines
Quoted 5 lines
Quoted 1 line

+CONFIG_OF_LIST="am335x-evm am335x-bone am335x-boneblack am335x-evmsk am335x-bonegreen am335x-icev2"

Just wondering, do we have HS variants of all these boards? If not we can just keep am335x-evm.

We don't "technically" have HS vs non-HS versions of any board, the boards are the same, the non-HS ones simply have the security features locked out. If the silicon they put on any of these boards is not locked out then it becomes an HS board.

Quoted 8 lines

Thanks.

Quoted 4 lines

But, yes, I only know of unlocked AM335x's currently being placed on the standard EVMs for now.

okay. Then drop all the other dtbs from the list.

Quoted 6 lines

I'm not sure what that would get us, the differences between non-HS and HS have nothing to do with the devices on the boards. This will only create a support burden if someone gets an unlocked Beaglebone for instance. Why limit the *more* feature-full chip? HS chips needs to be thought of as they are, a superset of the non-HS chips, not as a different kind of chip.

Is this officially supported? Have you tested before posting? If no then there should not be any argument for adding this support assuming this can possibly be useful or experimental.

Thanks and regards,
Lokesh

#8 lore raw

PATCH v2 1/1 defconfig: Add a config for AM335x High Security EVM

Quoted 30 lines · Lokesh Vutla

[..snip..]

Quoted 20 lines
Quoted 11 lines
Quoted 10 lines
Quoted 5 lines
Quoted 1 line

+CONFIG_OF_LIST="am335x-evm am335x-bone am335x-boneblack am335x-evmsk am335x-bonegreen am335x-icev2"

Just wondering, do we have HS variants of all these boards? If not we can just keep am335x-evm.

We don't "technically" have HS vs non-HS versions of any board, the boards are the same, the non-HS ones simply have the security features locked out. If the silicon they put on any of these boards is not locked out then it becomes an HS board.

Quoted 8 lines

Thanks.

Quoted 4 lines

But, yes, I only know of unlocked AM335x's currently being placed on the standard EVMs for now.

okay. Then drop all the other dtbs from the list.

Quoted 6 lines

I'm not sure what that would get us, the differences between non-HS and HS have nothing to do with the devices on the boards. This will only create a support burden if someone gets an unlocked Beaglebone for instance. Why limit the *more* feature-full chip? HS chips needs to be thought of as they are, a superset of the non-HS chips, not as a different kind of chip.

Quoted 4 lines

Is this officially supported? Have you tested before posting? If no then there should not be any argument for adding this support assuming this can possibly be useful or experimental.

I have tested this on the -EVM and will not test this on other boards. The type of board used is unrelated to adding boot authentication. This is not a new chip or board, it is a configuration change defconfig only. (If we could include other defconfigs like we can DTB files then this defconfig would include the regular defconfig and add a few lines. This would be useful for merging all the am335x/am43xx defconfig variations that have started to get rather out of sync with each other).

Think if I added an I2C driver, there would be no need to test it on every board U-Boot supports, just one, and if it didn't work on some board that would be a bug against the board, not against the driver.

I hope to at some point merge the HS and non-HS defconfigs, adding any delta between the two, without a specific reason, only delays this and will create a future support burden.

Andrew

Quoted 3 lines

Thanks and regards,
Lokesh

#9 lore raw

PATCH v2 1/1 defconfig: Add a config for AM335x High Security EVM

Quoted 44 lines · Andrew F. Davis
Quoted 30 lines · Lokesh Vutla

[..snip..]

Quoted 20 lines
Quoted 11 lines
Quoted 10 lines
Quoted 5 lines
Quoted 1 line

+CONFIG_OF_LIST="am335x-evm am335x-bone am335x-boneblack am335x-evmsk am335x-bonegreen am335x-icev2"

Just wondering, do we have HS variants of all these boards? If not we can just keep am335x-evm.

We don't "technically" have HS vs non-HS versions of any board, the boards are the same, the non-HS ones simply have the security features locked out. If the silicon they put on any of these boards is not locked out then it becomes an HS board.

Quoted 8 lines

Thanks.

Quoted 4 lines

But, yes, I only know of unlocked AM335x's currently being placed on the standard EVMs for now.

okay. Then drop all the other dtbs from the list.

Quoted 6 lines

I'm not sure what that would get us, the differences between non-HS and HS have nothing to do with the devices on the boards. This will only create a support burden if someone gets an unlocked Beaglebone for instance. Why limit the *more* feature-full chip? HS chips needs to be thought of as they are, a superset of the non-HS chips, not as a different kind of chip.

Quoted 4 lines

Is this officially supported? Have you tested before posting? If no then there should not be any argument for adding this support assuming this can possibly be useful or experimental.

I have tested this on the -EVM and will not test this on other boards. The type of board used is unrelated to adding boot authentication. This is not a new chip or board, it is a configuration change defconfig only. (If we could include other defconfigs like we can DTB files then this defconfig would include the regular defconfig and add a few lines. This would be useful for merging all the am335x/am43xx defconfig variations that have started to get rather out of sync with each other).

Quoted 3 lines

Think if I added an I2C driver, there would be no need to test it on every board U-Boot supports, just one, and if it didn't work on some board that would be a bug against the board, not against the driver.

The point here is what is being officially supported. Even the $subject says only *AM335x High security evm* but the patch adds support for all boards with HS silicon. Also look at the size of the image that is getting bloated when you know you are using only 1 evm.

I understand that it is good to have but I am saying that it can be added easily when someone *really* needs it.

Thanks and regards,
Lokesh

#10 lore raw

PATCH v2 1/1 defconfig: Add a config for AM335x High Security EVM

Quoted 51 lines · Lokesh Vutla
Quoted 44 lines · Andrew F. Davis
Quoted 30 lines · Lokesh Vutla

[..snip..]

Quoted 20 lines
Quoted 11 lines
Quoted 10 lines
Quoted 5 lines
Quoted 1 line

+CONFIG_OF_LIST="am335x-evm am335x-bone am335x-boneblack am335x-evmsk am335x-bonegreen am335x-icev2"

Just wondering, do we have HS variants of all these boards? If not we can just keep am335x-evm.

We don't "technically" have HS vs non-HS versions of any board, the boards are the same, the non-HS ones simply have the security features locked out. If the silicon they put on any of these boards is not locked out then it becomes an HS board.

Quoted 8 lines

Thanks.

Quoted 4 lines

But, yes, I only know of unlocked AM335x's currently being placed on the standard EVMs for now.

okay. Then drop all the other dtbs from the list.

Quoted 6 lines

I'm not sure what that would get us, the differences between non-HS and HS have nothing to do with the devices on the boards. This will only create a support burden if someone gets an unlocked Beaglebone for instance. Why limit the *more* feature-full chip? HS chips needs to be thought of as they are, a superset of the non-HS chips, not as a different kind of chip.

Quoted 4 lines

Is this officially supported? Have you tested before posting? If no then there should not be any argument for adding this support assuming this can possibly be useful or experimental.

I have tested this on the -EVM and will not test this on other boards. The type of board used is unrelated to adding boot authentication. This is not a new chip or board, it is a configuration change defconfig only. (If we could include other defconfigs like we can DTB files then this defconfig would include the regular defconfig and add a few lines. This would be useful for merging all the am335x/am43xx defconfig variations that have started to get rather out of sync with each other).

Quoted 3 lines

Think if I added an I2C driver, there would be no need to test it on every board U-Boot supports, just one, and if it didn't work on some board that would be a bug against the board, not against the driver.

Quoted 8 lines

The point here is what is being officially supported. Even the $subject says only *AM335x High security evm* but the patch adds support for all boards with HS silicon. Also look at the size of the image that is getting bloated when you know you are using only 1 evm.

I understand that it is good to have but I am saying that it can be added easily when someone *really* needs it.

Okay, I will deferred to your judgment on this for now, I'll remove them for v2.

Thanks,
Andrew

Quoted 3 lines

Thanks and regards,
Lokesh