Skip to contentSkip to conversation

Update configs for the firefly-rk3288

PATCH New Romain Perier 2 participants 8 messages Jan 17, 2017 – Feb 8, 2017

lore
Share & tools
lore
#0 lore raw

cover Update configs for the firefly-rk3288

This set of patches enables SPL_BACK_TO_BROM feature that has been tested on this board. That is preferable if all rk3288-based boards use the same configuration and boot in the same way. Then, it enables ethernet address randomization.

Romain Perier (2):
Enable ROCKCHIP_SPL_BACK_TO_BROM for firefly-rk3288 board
rockchip: Enable ETH address randomization for the firefly-rk3288

 configs/firefly-rk3288_defconfig | 3 +++
 include/configs/firefly-rk3288.h | 9 +++++++++
 2 files changed, 12 insertions(+)
Signature · 1 line
2.9.3
#1 lore raw

PATCH 1/2 Enable ROCKCHIP_SPL_BACK_TO_BROM for firefly-rk3288 board

Like the rock2, this board has been tested with back to brom feature. This commits adjusts environment offset regarding if back_to_brom is enabled or not and uses this feature by default.

---
 configs/firefly-rk3288_defconfig | 2 ++
 include/configs/firefly-rk3288.h | 9 +++++++++
 2 files changed, 11 insertions(+)
configs/firefly-rk3288_defconfig +2 -0
index 3ed17b4..3aa8bcf 100644
@@ -2,6 +2,8 @@ CONFIG_ARM=y
 CONFIG_ARCH_ROCKCHIP=y
 CONFIG_SYS_MALLOC_F_LEN=0x2000
 CONFIG_ROCKCHIP_RK3288=y
+# CONFIG_SPL_MMC_SUPPORT is not set
+CONFIG_ROCKCHIP_SPL_BACK_TO_BROM=y
 CONFIG_TARGET_FIREFLY_RK3288=y
 CONFIG_SPL_STACK_R_ADDR=0x80000
 CONFIG_DEFAULT_DEVICE_TREE="rk3288-firefly"
include/configs/firefly-rk3288.h +9 -0
index 14fdead..b9c2290 100644
@@ -16,11 +16,20 @@
 
 #define CONFIG_ENV_IS_IN_MMC
 #define CONFIG_SYS_MMC_ENV_DEV 0
+
+#ifdef CONFIG_ROCKCHIP_SPL_BACK_TO_BROM
+/* SPL @ 32k for 34k
+ * u-boot directly after @ 68k for 400k or so
+ * ENV @ 992k
+ */
+#define CONFIG_ENV_OFFSET ((1024-32) * 1024)
+#else
 /* SPL @ 32k for ~36k
  * ENV @ 96k
  * u-boot @ 128K
  */
 #define CONFIG_ENV_OFFSET (96 * 1024)
+#endif
 
 #define CONFIG_SYS_WHITE_ON_BLACK
 
Signature · 1 line
2.9.3
#2 lore raw

PATCH 1/2 Enable ROCKCHIP_SPL_BACK_TO_BROM for firefly-rk3288 board

Quoted 9 lines · Romain Perier

Like the rock2, this board has been tested with back to brom feature. This commits adjusts environment offset regarding if back_to_brom is enabled or not and uses this feature by default.

---
 configs/firefly-rk3288_defconfig | 2 ++
 include/configs/firefly-rk3288.h | 9 +++++++++
 2 files changed, 11 insertions(+)

We need at least one board that does not use this option. Also, doesn't this mean that we need to change how the image is written to the board?

Should we use binman to create a suitable image?

Regards,
Simon

#3 lore raw

PATCH 1/2 Enable ROCKCHIP_SPL_BACK_TO_BROM for firefly-rk3288 board

Hi,

Le 21/01/2017 ? 04:51, Simon Glass a ?crit :

Quoted 10 lines · Romain Perier
Quoted 9 lines

Like the rock2, this board has been tested with back to brom feature. This commits adjusts environment offset regarding if back_to_brom is enabled or not and uses this feature by default.

---
 configs/firefly-rk3288_defconfig | 2 ++
 include/configs/firefly-rk3288.h | 9 +++++++++
 2 files changed, 11 insertions(+)
Quoted 8 lines

We need at least one board that does not use this option. Also, doesn't this mean that we need to change how the image is written to the board?

Should we use binman to create a suitable image?

Regards,
Simon

Why do you want at least one board without this option ? for testing that it's still working without back_to_brom ? That's weird because all rk3288-based board has the same limitations regarding the SPL, no ?

Regards,
Romain

#4 lore raw

PATCH 1/2 Enable ROCKCHIP_SPL_BACK_TO_BROM for firefly-rk3288 board

Hi Romain,

Quoted 18 lines · Romain Perier

Hi,

Le 21/01/2017 ? 04:51, Simon Glass a ?crit :

Quoted 14 lines · Romain Perier
Quoted 9 lines

Like the rock2, this board has been tested with back to brom feature. This commits adjusts environment offset regarding if back_to_brom is enabled or not and uses this feature by default.

---
 configs/firefly-rk3288_defconfig | 2 ++
 include/configs/firefly-rk3288.h | 9 +++++++++
 2 files changed, 11 insertions(+)

We need at least one board that does not use this option. Also, doesn't this mean that we need to change how the image is written to the board?

Quoted 7 lines
Quoted 4 lines

Should we use binman to create a suitable image?

Regards,
Simon

Why do you want at least one board without this option ? for testing that it's still working without back_to_brom ? That's weird because all rk3288-based board has the same limitations regarding the SPL, no ?

Yes, but remember this is a non-standard booting mechanism, and one that I hope we can move away from in future. Also firefly does not *need* this mechanism. If we don't have one board that uses the standard mechanism then it might stop working.

Regards,
Simon

#5 lore raw

PATCH 2/2 rockchip: Enable ETH address randomization for the firefly-rk3288

In reply to Romain Perier

This commit enables ethernet MAC address randomization on the firefly-rk3288. It removes the error at startup 'ethernet at ff290000 address not set'.

---
 configs/firefly-rk3288_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/firefly-rk3288_defconfig +1 -0
index 3aa8bcf..3fe7add 100644
@@ -34,6 +34,7 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
 CONFIG_SPL_OF_PLATDATA=y
+CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_REGMAP=y
 CONFIG_SPL_REGMAP=y
 CONFIG_SYSCON=y
Signature · 1 line
2.9.3
#6 lore raw

PATCH 2/2 rockchip: Enable ETH address randomization for the firefly-rk3288

Quoted 8 lines · Romain Perier

This commit enables ethernet MAC address randomization on the firefly-rk3288. It removes the error at startup 'ethernet at ff290000 address not set'.

---
 configs/firefly-rk3288_defconfig | 1 +
 1 file changed, 1 insertion(+)
#7 lore raw

PATCH 2/2 rockchip: Enable ETH address randomization for the firefly-rk3288

Quoted 11 lines · Simon Glass
Quoted 8 lines · Romain Perier

This commit enables ethernet MAC address randomization on the firefly-rk3288. It removes the error at startup 'ethernet at ff290000 address not set'.

---
 configs/firefly-rk3288_defconfig | 1 +
 1 file changed, 1 insertion(+)

Applied to u-boot-rockchip, thanks!