Skip to contentSkip to conversation

rpmsg: char: add CONFIG_NET dependency

PATCH Applied Arnd Bergmann 2 participants 2 messages Jan 19, 2017 Remote processor messaging (rpmsg)

lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 rpmsg: char: add CONFIG_NET dependency

Without CONFIG_NET, we get a build failure for the new driver:

ERROR: "skb_queue_tail" [drivers/rpmsg/rpmsg_char.ko] undefined!
ERROR: "skb_put" [drivers/rpmsg/rpmsg_char.ko] undefined!
ERROR: "__alloc_skb" [drivers/rpmsg/rpmsg_char.ko] undefined!
ERROR: "kfree_skb" [drivers/rpmsg/rpmsg_char.ko] undefined!
ERROR: "skb_dequeue" [drivers/rpmsg/rpmsg_char.ko] undefined!

This adds a dependency so we don't try to build the broken configuration.

Fixes c0cdc19f84a4 ("rpmsg: Driver for user space endpoint interface")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/rpmsg/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/rpmsg/Kconfig +1 -0
index fa0d582efb3d..f12ac0b28263 100644
@@ -7,6 +7,7 @@ config RPMSG
 config RPMSG_CHAR
 	tristate "RPMSG device interface"
 	depends on RPMSG
+	depends on NET
 	help
 	  Say Y here to export rpmsg endpoints as device files, usually found
 	  in /dev. They make it possible for user-space programs to send and
Signature · 1 line
2.9.0
Applied
#1 lore raw
Quoted 8 lines · Arnd Bergmann

Without CONFIG_NET, we get a build failure for the new driver:

ERROR: "skb_queue_tail" [drivers/rpmsg/rpmsg_char.ko] undefined!
ERROR: "skb_put" [drivers/rpmsg/rpmsg_char.ko] undefined!
ERROR: "__alloc_skb" [drivers/rpmsg/rpmsg_char.ko] undefined!
ERROR: "kfree_skb" [drivers/rpmsg/rpmsg_char.ko] undefined!
ERROR: "skb_dequeue" [drivers/rpmsg/rpmsg_char.ko] undefined!

Quoted 4 lines

This adds a dependency so we don't try to build the broken configuration.

Fixes c0cdc19f84a4 ("rpmsg: Driver for user space endpoint interface")
Signed-off-by Arnd Bergmann <[email protected]>

Applied

Thanks,
Bjorn