x86: make LOAD_FROM_32_BIT visible for platforms
PATCH 1/1 x86: make LOAD_FROM_32_BIT visible for platforms
This option useful not only for development, but for the platforms where U-Boot is run from custom ROM bootloader. For example, Intel Edison is that board.
Make this option visible that platforms can select it if needed.
--- arch/x86/Kconfig | 4 ++++ arch/x86/cpu/start.S | 3 +-- 2 files changed, 5 insertions(+), 2 deletions(-)
arch/x86/Kconfig +4 -0
@@ -89,6 +89,10 @@ config X86_RESET_VECTOR bool default n +config X86_LOAD_FROM_32_BIT + bool + default n + config RESET_SEG_START hex depends on X86_RESET_VECTOR
arch/x86/cpu/start.S +1 -2
@@ -22,9 +22,8 @@ * Define this to boot U-Boot from a 32-bit program which sets the GDT * differently. This can be used to boot directly from any stage of coreboot, * for example, bypassing the normal payload-loading feature. - * This is only useful for development. */ -#undef LOAD_FROM_32_BIT +#define LOAD_FROM_32_BIT CONFIG_X86_LOAD_FROM_32_BIT .section .text .code32
Signature · 1 line
2.11.0
PATCH 1/1 x86: make LOAD_FROM_32_BIT visible for platforms
Quoted 9 lines · Andy Shevchenko
This option useful not only for development, but for the platforms where U-Boot is run from custom ROM bootloader. For example, Intel Edison is that board.
Make this option visible that platforms can select it if needed.
arch/x86/cpu/start.S line 26
Quoted 7 lines
arch/x86/cpu/start.S +1
-2@@ -22,9 +22,8 @@ * Define this to boot U-Boot from a 32-bit program which sets the GDT * differently. This can be used to boot directly from any stage of coreboot, * for example, bypassing the normal payload-loading feature. - * This is only useful for development. */ -#undef LOAD_FROM_32_BIT +#define LOAD_FROM_32_BIT CONFIG_X86_LOAD_FROM_32_BIT
Oops, given one more thought, it should be a bit more verbose
I will fix this later. Any other comments I need to address?
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH 1/1 x86: make LOAD_FROM_32_BIT visible for platforms
In reply to Andy ShevchenkoHi Andy,
Quoted 17 lines · Andy Shevchenko
This option useful not only for development, but for the platforms where U-Boot is run from custom ROM bootloader. For example, Intel Edison is that board.
Make this option visible that platforms can select it if needed.
Signed-off-by Andy Shevchenko <[email protected]>--- arch/x86/Kconfig | 4 ++++ arch/x86/cpu/start.S | 3 +-- 2 files changed, 5 insertions(+), 2 deletions(-)arch/x86/Kconfig +0
-0
arch/x86/Kconfig config X86_RESET_VECTOR · line 93
Quoted 5 lines
arch/x86/Kconfig +2
-0@@ -89,6 +89,10 @@ config X86_RESET_VECTOR bool default n +config X86_LOAD_FROM_32_BIT + bool
Can we add some help text (ie: the comment block below for the LOAD_FROM_32_BIT in start.S) to this option so that it is visible in "make menuconfig"?
Quoted 10 lines
arch/x86/Kconfig +2
-0+ default n + config RESET_SEG_START hex depends on X86_RESET_VECTORarch/x86/cpu/start.S +0
-0
arch/x86/cpu/start.S line 26
Quoted 7 lines
arch/x86/cpu/start.S +1
-2@@ -22,9 +22,8 @@ * Define this to boot U-Boot from a 32-bit program which sets the GDT * differently. This can be used to boot directly from any stage of coreboot, * for example, bypassing the normal payload-loading feature. - * This is only useful for development. */ -#undef LOAD_FROM_32_BIT +#define LOAD_FROM_32_BIT CONFIG_X86_LOAD_FROM_32_BIT
Instead of #defining LOAD_FROM_32_BIT, can we directly use CONFIG_X86_LOAD_FROM_32_BIT in this file?
Regards,
Bin