Skip to contentSkip to conversation

kernel: tracing: use modern function declaration

PATCH Applied Arnd Bergmann 2 participants 2 messages Jan 23, 2017 – Feb 14, 2017 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel: tracing: use modern function declaration

We get a lot of harmless warnings about this header file at W=1 level because of an unusual function declaration:

kernel/trace/trace.h:766:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration]

This moves the inline statement where it normally belongs, avoiding the warning.

Fixes 4046bf023b06 ("ftrace: Expose ftrace_hash_empty and ftrace_lookup_ip")
---
 kernel/trace/trace.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/trace.h +1 -1
index afbec961eab1..6806932f6bd9 100644
@@ -763,7 +763,7 @@ struct ftrace_hash {
 struct ftrace_func_entry *
 ftrace_lookup_ip(struct ftrace_hash *hash, unsigned long ip);
 
-static bool __always_inline ftrace_hash_empty(struct ftrace_hash *hash)
+static __always_inline bool ftrace_hash_empty(struct ftrace_hash *hash)
 {
 	return !hash || !hash->count;
 }
Signature · 1 line
2.9.0
maintainer Applied
#1 lore raw
Quoted 10 lines · On Mon, 23 Jan 2017 13:24:45 +0100 Arnd Bergmann <[email protected]> wrote:

We get a lot of harmless warnings about this header file at W=1 level because of an unusual function declaration:

kernel/trace/trace.h:766:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration]

This moves the inline statement where it normally belongs, avoiding the warning.

Fixes 4046bf023b06 ("ftrace: Expose ftrace_hash_empty and ftrace_lookup_ip")

Applied, Thanks!

-- Steve