net: ethernet: faraday: To support device tree usage.

PATCH Superseded Greentime Hu 4 participants 7 messages Jan 24, 2017 – Feb 10, 2017

Subsystems (3)

Networking Network drivers Device tree bindings

lore

Share & tools

lore

Greentime Hu

author

2017-01-24 08:46 UTC #0 lore raw

PATCH v4 1/1 net: ethernet: faraday: To support device tree usage.

We also use the same binding document to describe the same faraday ethernet controller and add faraday to vendor-prefixes.txt.

Signed-off-by Greentime Hu <[email protected]>

---
Changes in v4:
- Use the same binding document to describe the same faraday ethernet controller and add faraday to vendor-prefixes.txt.
Changes in v3:
- Nothing changed in this patch but I have committed andestech to vendor-prefixes.txt.
Changes in v2:
- Change atmac100_of_ids to ftmac100_of_ids

---
 .../net/{moxa,moxart-mac.txt => faraday,ftmac.txt} |    7 +++++--
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 drivers/net/ethernet/faraday/ftmac100.c            |    7 +++++++
 3 files changed, 13 insertions(+), 2 deletions(-)
 rename Documentation/devicetree/bindings/net/{moxa,moxart-mac.txt => faraday,ftmac.txt} (68%)

Documentation/devicetree/bindings/net/faraday,ftmac.txt renamed from Documentation/devicetree/bindings/net/moxa,moxart-mac.txt +5 -2

similarity index 68%
rename from Documentation/devicetree/bindings/net/moxa,moxart-mac.txt
rename to Documentation/devicetree/bindings/net/faraday,ftmac.txt
index 583418b..be4f55e 100644
@@ -1,8 +1,11 @@
-MOXA ART Ethernet Controller
+Faraday Ethernet Controller
 
 Required properties:
 
-- compatible : Must be "moxa,moxart-mac"
+- compatible : Must contain "faraday,ftmac", as well as one of
+		the SoC specific identifiers:
+		"andestech,atmac100"
+		"moxa,moxart-mac"
 - reg : Should contain register location and length
 - interrupts : Should contain the mac interrupt number

Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0

index 16d3b5e..489c336 100644
@@ -102,6 +102,7 @@ everest	Everest Semiconductor Co. Ltd.
 everspin	Everspin Technologies, Inc.
 excito	Excito
 ezchip	EZchip Semiconductor
+faraday	Faraday Technology Corporation
 fcs	Fairchild Semiconductor
 firefly	Firefly
 focaltech	FocalTech Systems Co.,Ltd

drivers/net/ethernet/faraday/ftmac100.c +7 -0

index dce5f7b..5d70ee9 100644
@@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static const struct of_device_id ftmac100_of_ids[] = {
+	{ .compatible = "andestech,atmac100" },
+	{ }
+};
+
 static struct platform_driver ftmac100_driver = {
 	.probe		= ftmac100_probe,
 	.remove		= __exit_p(ftmac100_remove),
 	.driver		= {
 		.name	= DRV_NAME,
+		.of_match_table = ftmac100_of_ids
 	},
 };

@@ -1200,3 +1206,4 @@ static void __exit ftmac100_exit(void)
 MODULE_AUTHOR("Po-Yu Chuang <[email protected]>");
 MODULE_DESCRIPTION("FTMAC100 driver");
 MODULE_LICENSE("GPL");
+MODULE_DEVICE_TABLE(of, ftmac100_of_ids);

Signature · 6 lines

1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

David Miller

maintainer

2017-01-25 17:34 UTC #1 lore raw

From: Greentime Hu <[email protected]>
Date: Tue, 24 Jan 2017 16:46:14 +0800

Documentation/devicetree/bindings/net/faraday,ftmac.txt

Quoted 23 lines

We also use the same binding document to describe the same faraday ethernet controller and add faraday to vendor-prefixes.txt.
Signed-off-by Greentime Hu <[email protected]>
---
Changes in v4:
- Use the same binding document to describe the same faraday ethernet controller and add faraday to vendor-prefixes.txt.
Changes in v3:
- Nothing changed in this patch but I have committed andestech to vendor-prefixes.txt.
Changes in v2:
- Change atmac100_of_ids to ftmac100_of_ids
---
 .../net/{moxa,moxart-mac.txt => faraday,ftmac.txt} |    7 +++++--
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 drivers/net/ethernet/faraday/ftmac100.c            |    7 +++++++
 3 files changed, 13 insertions(+), 2 deletions(-)
 rename Documentation/devicetree/bindings/net/{moxa,moxart-mac.txt => faraday,ftmac.txt} (68%)
Documentation/devicetree/bindings/net/faraday,ftmac.txt renamed from Documentation/devicetree/bindings/net/moxa,moxart-mac.txt +0 -0
similarity index 68%
rename from Documentation/devicetree/bindings/net/moxa,moxart-mac.txt
rename to Documentation/devicetree/bindings/net/faraday,ftmac.txt

Why are you renaming the MOXA binding file instead of adding a completely new one for faraday? The MOXA one should stick around, I don't see a justification for removing it.

Arnd Bergmann

2017-01-25 21:09 UTC #2 lore raw

Quoted 8 lines · David Miller

From: Greentime Hu <[email protected]>
Date: Tue, 24 Jan 2017 16:46:14 +0800
Quoted 2 lines
We also use the same binding document to describe the same faraday ethernet controller and add faraday to vendor-prefixes.txt.
Why are you renaming the MOXA binding file instead of adding a completely new one for faraday? The MOXA one should stick around, I don't see a justification for removing it.

This was my suggestion, basically fixing the name of the existing binding, which was
accidentally named after one of the users rather than the company that did the hardware.

We can't change the compatible string, but I'd much prefer having only one binding
file for this device rather than two separate ones that could possibly become incompatible in case we add new properties to them. If there is only one of them,
naming it according to the hardware design is the general policy.

Note that we currently have two separate device drivers, but that is more a historic artifact, and if we ever get around to merging them into one driver, that should not impact the binding.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Rob Herring

maintainer

2017-01-27 22:17 UTC #3 lore raw

Quoted 22 lines · Arnd Bergmann

Quoted 8 lines · David Miller
From: Greentime Hu <[email protected]>
Date: Tue, 24 Jan 2017 16:46:14 +0800
Quoted 2 lines
We also use the same binding document to describe the same faraday ethernet controller and add faraday to vendor-prefixes.txt.
Why are you renaming the MOXA binding file instead of adding a completely new one for faraday? The MOXA one should stick around, I don't see a justification for removing it.
This was my suggestion, basically fixing the name of the existing binding, which was
accidentally named after one of the users rather than the company that did the hardware.
We can't change the compatible string, but I'd much prefer having only one binding
file for this device rather than two separate ones that could possibly become incompatible in case we add new properties to them. If there is only one of them,
naming it according to the hardware design is the general policy.

Quoted 3 lines

Note that we currently have two separate device drivers, but that is more a historic artifact, and if we ever get around to merging them into one driver, that should not impact the binding.

The change is fine with me, but the subject and commit message need some work. I'm guessing faraday licensed this to MOXA or something? Why is the new name preferred or better?

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Arnd Bergmann

2017-02-01 15:47 UTC #4 lore raw

Quoted 23 lines · CET Rob Herring

Quoted 22 lines · Arnd Bergmann
Quoted 8 lines · David Miller
From: Greentime Hu <[email protected]>
Date: Tue, 24 Jan 2017 16:46:14 +0800
Quoted 2 lines
We also use the same binding document to describe the same faraday ethernet controller and add faraday to vendor-prefixes.txt.
Why are you renaming the MOXA binding file instead of adding a completely new one for faraday? The MOXA one should stick around, I don't see a justification for removing it.
This was my suggestion, basically fixing the name of the existing binding, which was
accidentally named after one of the users rather than the company that did the hardware.
We can't change the compatible string, but I'd much prefer having only one binding
file for this device rather than two separate ones that could possibly become incompatible in case we add new properties to them. If there is only one of them,
naming it according to the hardware design is the general policy.

Quoted 6 lines

Quoted 3 lines
Note that we currently have two separate device drivers, but that is more a historic artifact, and if we ever get around to merging them into one driver, that should not impact the binding.
The change is fine with me, but the subject and commit message need some work. I'm guessing faraday licensed this to MOXA or something?

Correct, Faraday just produces IP blocks.

Quoted 1 line

Why is the new name preferred or better?

The situation is similar to the designware "dwmac", which for historic reasons is called "stmmac" in Linux, both for the binding and the driver name. I think this should have been dwmac from the start, but changing it earlier is much easier than changing it later.

Arnd

Greentime Hu

author

2017-02-08 11:59 UTC #5 lore raw

In reply to Rob Herring

Quoted 24 lines · Rob Herring

Quoted 22 lines · Arnd Bergmann
Quoted 8 lines · David Miller
From: Greentime Hu <[email protected]>
Date: Tue, 24 Jan 2017 16:46:14 +0800
Quoted 2 lines
We also use the same binding document to describe the same faraday ethernet controller and add faraday to vendor-prefixes.txt.
Why are you renaming the MOXA binding file instead of adding a completely new one for faraday? The MOXA one should stick around, I don't see a justification for removing it.
This was my suggestion, basically fixing the name of the existing binding, which was
accidentally named after one of the users rather than the company that did the hardware.
We can't change the compatible string, but I'd much prefer having only one binding
file for this device rather than two separate ones that could possibly become incompatible in case we add new properties to them. If there is only one of them,
naming it according to the hardware design is the general policy.

Quoted 6 lines

Quoted 3 lines
Note that we currently have two separate device drivers, but that is more a historic artifact, and if we ever get around to merging them into one driver, that should not impact the binding.
The change is fine with me, but the subject and commit message need some work.

Hi, Rob:

Would you please advise me of the proper subject and commit messages? Thanks~
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Rob Herring

maintainer

2017-02-10 15:03 UTC #6 lore raw

Quoted 29 lines · Greentime Hu

Quoted 28 lines · Rob Herring
Quoted 25 lines · Arnd Bergmann
Quoted 8 lines · David Miller
From: Greentime Hu <[email protected]>
Date: Tue, 24 Jan 2017 16:46:14 +0800
Quoted 2 lines
We also use the same binding document to describe the same faraday ethernet controller and add faraday to vendor-prefixes.txt.
Why are you renaming the MOXA binding file instead of adding a completely new one for faraday? The MOXA one should stick around, I don't see a justification for removing it.
This was my suggestion, basically fixing the name of the existing binding, which was
accidentally named after one of the users rather than the company that did the hardware.
We can't change the compatible string, but I'd much prefer having only one binding
file for this device rather than two separate ones that could possibly become incompatible in case we add new properties to them. If there is only one of them,
naming it according to the hardware design is the general policy.
Note that we currently have two separate device drivers, but that is more a historic artifact, and if we ever get around to merging them into one driver, that should not impact the binding.

Quoted 6 lines

Quoted 2 lines
The change is fine with me, but the subject and commit message need some work.
Hi, Rob:
Would you please advise me of the proper subject and commit messages?

Split the binding to a separate commit and summarize the email discussion here. For a subject, something like this:

"dt-bindings: net: generalize moxart-mac to support all faraday based ftmac IP"

Rob