Skip to contentSkip to conversation

lib/drmtest: make DRIVER_ANY match any driver

PATCH NAK Eric Engestrom 5 participants 6 messages Jan 24, 2017 – Jan 31, 2017 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/drmtest: make DRIVER_ANY match any driver

---
Not tested or anything, I just happened to notice this code and it looked wrong, but maybe I misunderstood what it was meant to do.

An alternative would be to just set the bits the the drivers that are defined already, but that would require an update everytime a new DRIVER_* is added (error-prone):

	#define DRIVER_ANY	((1 << 4) - 1)
---
 lib/drmtest.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/drmtest.h +1 -1
index 19d4bd19..1d41df93 100644
@@ -42,7 +42,7 @@
 #define DRIVER_VC4	(1 << 1)
 #define DRIVER_VGEM	(1 << 2)
 #define DRIVER_VIRTIO	(1 << 3)
-#define DRIVER_ANY 	~(DRIVER_VGEM)
+#define DRIVER_ANY	(~0)
 
 #ifdef ANDROID
 #if (!(defined HAVE_MMAP64)) && (!(defined __x86_64__))
Signature · 7 lines
Cheers,
  Eric

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

Thanks Eric,

This does looks like a reasonable change to me.
I don't think there are any legacy reasons for excluding VGEM from testing in DRIVER_ANY compatible tests.

Quoted 19 lines · Eric Engestrom

---
Not tested or anything, I just happened to notice this code and it looked wrong, but maybe I misunderstood what it was meant to do.

An alternative would be to just set the bits the the drivers that are defined already, but that would require an update everytime a new DRIVER_* is added (error-prone):

	#define DRIVER_ANY	((1 << 4) - 1)
---
 lib/drmtest.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/drmtest.h +0 -0
index 19d4bd19..1d41df93 100644

lib/drmtest.h line 48

Quoted 8 lines
lib/drmtest.h +1 -1
@@ -42,7 +42,7 @@
 #define DRIVER_VC4	(1 << 1)
 #define DRIVER_VGEM	(1 << 2)
 #define DRIVER_VIRTIO	(1 << 3)
-#define DRIVER_ANY 	~(DRIVER_VGEM)
+#define DRIVER_ANY	(~0)
 
 #ifdef ANDROID
 #if (!(defined HAVE_MMAP64)) && (!(defined __x86_64__))

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

Hi,

Quoted 5 lines · Petri Latvala

NAK.

DRIVER_VGEM is omitted from DRIVER_ANY intentionally. Vgem is unable to modeset, unable to render, practically it only supports the vgem-specific tests. See also: lib/drmtest.c, __drm_open_driver().

Yeah, I agree with this. It's mostly just there as an auxiliary helper. Opening DRIVER_ANY to vgem means that, if you run on a system with vgem as well as a supported driver, you can end up with a near-100% skip rate if you don't explicitly specify the device, depending on device-load ordering.

Cheers,
Daniel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
Quoted 9 lines · Daniel Stone

Hi,

Quoted 5 lines · Petri Latvala

NAK.

DRIVER_VGEM is omitted from DRIVER_ANY intentionally. Vgem is unable to modeset, unable to render, practically it only supports the vgem-specific tests. See also: lib/drmtest.c, __drm_open_driver().

Quoted 8 lines

Yeah, I agree with this. It's mostly just there as an auxiliary helper. Opening DRIVER_ANY to vgem means that, if you run on a system with vgem as well as a supported driver, you can end up with a near-100% skip rate if you don't explicitly specify the device, depending on device-load ordering.

Cheers,
Daniel

OK. This should probably be documented then (a simple comment next to the #define would go a long way), so that the next guy who see this doesn't make the same mistake I did :)

Cheers,
Eric
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
Quoted 16 lines · Eric Engestrom
Quoted 15 lines · Daniel Stone

Hi,

Quoted 5 lines · Petri Latvala

NAK.

DRIVER_VGEM is omitted from DRIVER_ANY intentionally. Vgem is unable to modeset, unable to render, practically it only supports the vgem-specific tests. See also: lib/drmtest.c, __drm_open_driver().

Yeah, I agree with this. It's mostly just there as an auxiliary helper. Opening DRIVER_ANY to vgem means that, if you run on a system with vgem as well as a supported driver, you can end up with a near-100% skip rate if you don't explicitly specify the device, depending on device-load ordering.

Quoted 6 lines
Quoted 2 lines

Cheers,
Daniel

OK. This should probably be documented then (a simple comment next to the #define would go a long way), so that the next guy who see this doesn't make the same mistake I did :)

Maybe we should rename it to DRIVER_ANY_KMS, and check in the open function that there's at least 1 plane/crtc/encoder/connector there and otherwise skip? I think that would be even better than documenting it, since it'd also catch e.g. tegra+nouveau systems.
-Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx