Skip to contentSkip to conversation

phy: comphy_a3700: Change SD/MMC compatible DT node to match the updates

PATCH New Stefan Roese 2 participants 4 messages Jan 25, 2017 – Jan 31, 2017 Generic PHY framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: comphy_a3700: Change SD/MMC compatible DT node to match the updates

Now that the SD/SDIO/MMC DT properties are updated in the Marvell A3700 and A7/8k DT files, we need to match the checks for compatible node in the PHY driver as well.

Cc Kostya Porotchkin <[email protected]>
Cc Nadav Haklai <[email protected]>
---
 drivers/phy/marvell/comphy_a3700.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/phy/marvell/comphy_a3700.c +3 -4
index faa62f90ae..5afd23c052 100644
@@ -884,11 +884,10 @@ void comphy_dedicated_phys_init(void)
 	}
 
 	node = fdt_node_offset_by_compatible(blob, -1,
-					     "marvell,armada-3700-sdio");
+					     "marvell,armada-8k-sdhci");
 	if (node <= 0) {
-		debug("No SDIO node in DT, looking for MMC one\n");
-		node = fdt_node_offset_by_compatible(blob, -1,
-						     "marvell,xenon-sdhci");
+		node = fdt_node_offset_by_compatible(
+			blob, -1, "marvell,armada-3700-sdhci");
 	}
 
 	if (node > 0) {
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 phy: comphy_a3700: Change SD/MMC compatible DT node to match the updates

Hi Stefan,

Quoted 3 lines · Stefan Roese

Now that the SD/SDIO/MMC DT properties are updated in the Marvell A3700 and A7/8k DT files, we need to match the checks for compatible node in the PHY driver as well.

This patch was delegated to me. But i think right that it might be delegated to you. I will change to you. If there is a problem, let me know, plz.

Best Regards,
Jaehoon Chung

Quoted 28 lines
Cc Kostya Porotchkin <[email protected]>
Cc Nadav Haklai <[email protected]>
---
 drivers/phy/marvell/comphy_a3700.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/phy/marvell/comphy_a3700.c +3 -4
index faa62f90ae..5afd23c052 100644
@@ -884,11 +884,10 @@ void comphy_dedicated_phys_init(void)
 	}
 
 	node = fdt_node_offset_by_compatible(blob, -1,
-					     "marvell,armada-3700-sdio");
+					     "marvell,armada-8k-sdhci");
 	if (node <= 0) {
-		debug("No SDIO node in DT, looking for MMC one\n");
-		node = fdt_node_offset_by_compatible(blob, -1,
-						     "marvell,xenon-sdhci");
+		node = fdt_node_offset_by_compatible(
+			blob, -1, "marvell,armada-3700-sdhci");
 	}
 
 	if (node > 0) {
#2 lore raw

PATCH 1/1 phy: comphy_a3700: Change SD/MMC compatible DT node to match the updates

Hi Jaehoon,

Quoted 7 lines · Jaehoon Chung
Quoted 3 lines · Stefan Roese

Now that the SD/SDIO/MMC DT properties are updated in the Marvell A3700 and A7/8k DT files, we need to match the checks for compatible node in the PHY driver as well.

This patch was delegated to me. But i think right that it might be delegated to you. I will change to you.

Thats just fine.

Quoted 1 line

If there is a problem, let me know, plz.

No problem.

Thanks,
Stefan

#3 lore raw

PATCH 1/1 phy: comphy_a3700: Change SD/MMC compatible DT node to match the updates

Hi Stefan,

Quoted 8 lines · Stefan Roese

Hi Jaehoon,

Quoted 5 lines · Jaehoon Chung
Quoted 3 lines · Stefan Roese

Now that the SD/SDIO/MMC DT properties are updated in the Marvell A3700 and A7/8k DT files, we need to match the checks for compatible node in the PHY driver as well.

Quoted 8 lines
Quoted 2 lines

This patch was delegated to me. But i think right that it might be delegated to you. I will change to you.

Thats just fine.

Quoted 1 line

If there is a problem, let me know, plz.

No problem.

Thanks! Anyway, I have checked this patch, it looks good to me.

Best Regards,
Jaehoon Chung

Quoted 6 lines

Thanks,
Stefan