Skip to contentSkip to conversation

mfd: lpc_ich: enable iTCO on Apollo Lake

PATCH Applied Andy Shevchenko 3 participants 7 messages Jan 28, 2017 – Feb 7, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover mfd: lpc_ich: enable iTCO on Apollo Lake

Enable iTCo watchdog on Apollo Lake.

In v2:
- Fix authorship in patch 1
- rebase on top of ib-mfd-mtd-4.11

Andy Shevchenko (1):
mfd: lpc_ich: Remove useless comments in core part

Tan Jui Nee (1):
mfd: lpc_ich: Enable watchdog on Intel Apollo Lake PCH

 drivers/mfd/lpc_ich.c | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)
Signature · 1 line
2.11.0
#1 lore raw

PATCH v2 1/2 mfd: lpc_ich: Enable watchdog on Intel Apollo Lake PCH

From: Tan Jui Nee <[email protected]>

Assign iTCO_version which effectively enables watchdog device on Intel Apollo Lake PCH.

---
 drivers/mfd/lpc_ich.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mfd/lpc_ich.c +1 -0
index be42957a78e1..b2f234d5ee3b 100644
@@ -567,6 +567,7 @@ static struct lpc_ich_info lpc_chipset_info[] = {
 	},
 	[LPC_APL] = {
 		.name = "Apollo Lake SoC",
+		.iTCO_version = 5,
 		.spi_type = INTEL_SPI_BXT,
 	},
 };
Signature · 1 line
2.11.0
#4 lore raw

PATCH v2 2/2 mfd: lpc_ich: Remove useless comments in core part

In reply to Andy Shevchenko

First of all, remove stalled references to datasheets. If someone knows the document numbers, it would be added later.

Second, remove FSF snail address since it's subject to change. Actual information can be found on FSF site on the internet.

---
 drivers/mfd/lpc_ich.c | 16 ----------------
 1 file changed, 16 deletions(-)
drivers/mfd/lpc_ich.c +0 -16
index b2f234d5ee3b..d98a5d974092 100644
@@ -20,10 +20,6 @@
  *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  *  GNU General Public License for more details.
  *
- *  You should have received a copy of the GNU General Public License
- *  along with this program; see the file COPYING.  If not, write to
- *  the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.
- *
  *  This driver supports the following I/O Controller hubs:
  *	(See the intel documentation on http://developer.intel.com.)
  *	document number 290655-003, 290677-014: 82801AA (ICH), 82801AB (ICHO)
@@ -45,18 +41,6 @@
  *	document number 322169-001, 322170-003: 5 Series, 3400 Series (PCH)
  *	document number 320066-003, 320257-008: EP80597 (IICH)
  *	document number 324645-001, 324646-001: Cougar Point (CPT)
- *	document number TBD : Patsburg (PBG)
- *	document number TBD : DH89xxCC
- *	document number TBD : Panther Point
- *	document number TBD : Lynx Point
- *	document number TBD : Lynx Point-LP
- *	document number TBD : Wellsburg
- *	document number TBD : Avoton SoC
- *	document number TBD : Coleto Creek
- *	document number TBD : Wildcat Point-LP
- *	document number TBD : 9 Series
- *	document number TBD : Lewisburg
- *	document number TBD : Apollo Lake SoC
  */
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Signature · 1 line
2.11.0
Acked-by on v2 2/2
#5 lore raw

Re: [PATCH v2 2/2] mfd: lpc_ich: Remove useless comments in core part

In reply to Andy Shevchenko
Quoted 2 lines · Andy Shevchenko

First of all, remove stalled references to datasheets. If someone knows the document numbers, it would be added later.

Yeah, those are kind of useless without the document number.

Quoted 4 lines

Second, remove FSF snail address since it's subject to change. Actual information can be found on FSF site on the internet.

Applied
#3 lore raw

Re: [PATCH v2 1/2] mfd: lpc_ich: Enable watchdog on Intel Apollo Lake PCH

In reply to Andy Shevchenko
Quoted 10 lines · Andy Shevchenko

From: Tan Jui Nee <[email protected]>

Assign iTCO_version which effectively enables watchdog device on Intel Apollo Lake PCH.

---
 drivers/mfd/lpc_ich.c | 1 +
 1 file changed, 1 insertion(+)

Applied, thanks.

Quoted 12 lines
drivers/mfd/lpc_ich.c +1 -0
index be42957a78e1..b2f234d5ee3b 100644
@@ -567,6 +567,7 @@ static struct lpc_ich_info lpc_chipset_info[] = {
 	},
 	[LPC_APL] = {
 		.name = "Apollo Lake SoC",
+		.iTCO_version = 5,
 		.spi_type = INTEL_SPI_BXT,
 	},
 };
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Applied
#6 lore raw

Re: [PATCH v2 2/2] mfd: lpc_ich: Remove useless comments in core part

In reply to Andy Shevchenko
Quoted 10 lines · Andy Shevchenko

First of all, remove stalled references to datasheets. If someone knows the document numbers, it would be added later.

Second, remove FSF snail address since it's subject to change. Actual information can be found on FSF site on the internet.

---
 drivers/mfd/lpc_ich.c | 16 ----------------
 1 file changed, 16 deletions(-)

Applied, thanks.

Quoted 34 lines
drivers/mfd/lpc_ich.c +0 -16
index b2f234d5ee3b..d98a5d974092 100644
@@ -20,10 +20,6 @@
  *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  *  GNU General Public License for more details.
  *
- *  You should have received a copy of the GNU General Public License
- *  along with this program; see the file COPYING.  If not, write to
- *  the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.
- *
  *  This driver supports the following I/O Controller hubs:
  *	(See the intel documentation on http://developer.intel.com.)
  *	document number 290655-003, 290677-014: 82801AA (ICH), 82801AB (ICHO)
@@ -45,18 +41,6 @@
  *	document number 322169-001, 322170-003: 5 Series, 3400 Series (PCH)
  *	document number 320066-003, 320257-008: EP80597 (IICH)
  *	document number 324645-001, 324646-001: Cougar Point (CPT)
- *	document number TBD : Patsburg (PBG)
- *	document number TBD : DH89xxCC
- *	document number TBD : Panther Point
- *	document number TBD : Lynx Point
- *	document number TBD : Lynx Point-LP
- *	document number TBD : Wellsburg
- *	document number TBD : Avoton SoC
- *	document number TBD : Coleto Creek
- *	document number TBD : Wildcat Point-LP
- *	document number TBD : 9 Series
- *	document number TBD : Lewisburg
- *	document number TBD : Apollo Lake SoC
  */
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog