mfd: lpc_ich: enable iTCO on Apollo Lake
Subsystems (2)
v2 cover mfd: lpc_ich: enable iTCO on Apollo Lake
Enable iTCo watchdog on Apollo Lake.
In v2:
- Fix authorship in patch 1
- rebase on top of ib-mfd-mtd-4.11
Andy Shevchenko (1):
mfd: lpc_ich: Remove useless comments in core part
Tan Jui Nee (1):
mfd: lpc_ich: Enable watchdog on Intel Apollo Lake PCH
drivers/mfd/lpc_ich.c | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-)
Signature · 1 line
2.11.0
PATCH v2 1/2 mfd: lpc_ich: Enable watchdog on Intel Apollo Lake PCH
From: Tan Jui Nee <[email protected]>
Assign iTCO_version which effectively enables watchdog device on Intel Apollo Lake PCH.
--- drivers/mfd/lpc_ich.c | 1 + 1 file changed, 1 insertion(+)
drivers/mfd/lpc_ich.c +1 -0
@@ -567,6 +567,7 @@ static struct lpc_ich_info lpc_chipset_info[] = { }, [LPC_APL ] = { .name ="Apollo Lake SoC" , + .iTCO_version =5 , .spi_type =INTEL_SPI_BXT , }, };
Signature · 1 line
2.11.0
PATCH v2 2/2 mfd: lpc_ich: Remove useless comments in core part
In reply to Andy ShevchenkoFirst of all, remove stalled references to datasheets. If someone knows the document numbers, it would be added later.
Second, remove FSF snail address since it's subject to change. Actual information can be found on FSF site on the internet.
--- drivers/mfd/lpc_ich.c | 16 ---------------- 1 file changed, 16 deletions(-)
drivers/mfd/lpc_ich.c +0 -16
@@ -20,10 +20,6 @@* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * -* You should have received a copy of the GNU General Public License -* along with this program; see the file COPYING. If not, write to -* the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA. -* * This driver supports the following I/O Controller hubs: * (See the intel documentation on http://developer.intel.com.) * document number 290655-003, 290677-014: 82801AA (ICH), 82801AB (ICHO)
@@ -45,18 +41,6 @@* document number 322169-001, 322170-003: 5 Series, 3400 Series (PCH) * document number 320066-003, 320257-008: EP80597 (IICH) * document number 324645-001, 324646-001: Cougar Point (CPT) -* document number TBD : Patsburg (PBG) -* document number TBD : DH89xxCC -* document number TBD : Panther Point -* document number TBD : Lynx Point -* document number TBD : Lynx Point-LP -* document number TBD : Wellsburg -* document number TBD : Avoton SoC -* document number TBD : Coleto Creek -* document number TBD : Wildcat Point-LP -* document number TBD : 9 Series -* document number TBD : Lewisburg -* document number TBD : Apollo Lake SoC */ #define pr_fmt (fmt) KBUILD_MODNAME ": " fmt
Signature · 1 line
2.11.0
Re: [PATCH v2 1/2] mfd: lpc_ich: Enable watchdog on Intel Apollo Lake PCH
In reply to Andy ShevchenkoQuoted 7 lines · Andy Shevchenko
From: Tan Jui Nee <[email protected]>
Assign
iTCO_versionwhich effectively enables watchdog device on Intel Apollo Lake PCH.Signed-off-by Tan Jui Nee <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
Re: [PATCH v2 2/2] mfd: lpc_ich: Remove useless comments in core part
In reply to Andy ShevchenkoQuoted 2 lines · Andy Shevchenko
First of all, remove stalled references to datasheets. If someone knows the document numbers, it would be added later.
Yeah, those are kind of useless without the document number.
Quoted 4 lines
Second, remove FSF snail address since it's subject to change. Actual information can be found on FSF site on the internet.
Signed-off-by Andy Shevchenko <[email protected]>
Lee Jones
AppliedRe: [PATCH v2 1/2] mfd: lpc_ich: Enable watchdog on Intel Apollo Lake PCH
In reply to Andy ShevchenkoQuoted 10 lines · Andy Shevchenko
From: Tan Jui Nee <[email protected]>
Assign
iTCO_versionwhich effectively enables watchdog device on Intel Apollo Lake PCH.Signed-off-by Tan Jui Nee <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- drivers/mfd/lpc_ich.c | 1 + 1 file changed, 1 insertion(+)
Applied, thanks.
Quoted 12 lines
drivers/mfd/lpc_ich.c +1
-0@@ -567,6 +567,7 @@ static struct lpc_ich_info lpc_chipset_info[] = { }, [LPC_APL ] = { .name ="Apollo Lake SoC" , + .iTCO_version =5 , .spi_type =INTEL_SPI_BXT , }, };
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Lee Jones
AppliedRe: [PATCH v2 2/2] mfd: lpc_ich: Remove useless comments in core part
In reply to Andy ShevchenkoQuoted 10 lines · Andy Shevchenko
First of all, remove stalled references to datasheets. If someone knows the document numbers, it would be added later.
Second, remove FSF snail address since it's subject to change. Actual information can be found on FSF site on the internet.
Signed-off-by Andy Shevchenko <[email protected]>--- drivers/mfd/lpc_ich.c | 16 ---------------- 1 file changed, 16 deletions(-)
Applied, thanks.
Quoted 34 lines
drivers/mfd/lpc_ich.c +0
-16@@ -20,10 +20,6 @@* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * -* You should have received a copy of the GNU General Public License -* along with this program; see the file COPYING. If not, write to -* the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA. -* * This driver supports the following I/O Controller hubs: * (See the intel documentation on http://developer.intel.com.) * document number 290655-003, 290677-014: 82801AA (ICH), 82801AB (ICHO) @@ -45,18 +41,6 @@* document number 322169-001, 322170-003: 5 Series, 3400 Series (PCH) * document number 320066-003, 320257-008: EP80597 (IICH) * document number 324645-001, 324646-001: Cougar Point (CPT) -* document number TBD : Patsburg (PBG) -* document number TBD : DH89xxCC -* document number TBD : Panther Point -* document number TBD : Lynx Point -* document number TBD : Lynx Point-LP -* document number TBD : Wellsburg -* document number TBD : Avoton SoC -* document number TBD : Coleto Creek -* document number TBD : Wildcat Point-LP -* document number TBD : 9 Series -* document number TBD : Lewisburg -* document number TBD : Apollo Lake SoC */ #define pr_fmt (fmt) KBUILD_MODNAME ": " fmt
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog