Skip to contentSkip to conversation

iio: distance: add dt binding for devantech-srf04

PATCH Superseded Andreas Klinger 2 participants 2 messages Jan 28, 2017 – Jan 29, 2017

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 iio: distance: add dt binding for devantech-srf04

This patch adds dt binding for devantech ultrasonic ranger srf04.

The vendor "devantech" was already added to the vendor list with
"[PATCH v4 1/3] iio: distance: srf08: add trivial DT binding"

---
 .../bindings/iio/proximity/devantech-srf04.txt          | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt
Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt new file +17 -0
new file mode 100644
index 000000000000..4ea29ef3ff89
@@ -0,0 +1,17 @@
+* Devantech SRF04 ultrasonic range finder
+  Bit-banging driver
+
+Required properties:
+ - compatible:	Should be "devantech,srf04"
+ - trig-gpios:	Definition of the GPIO for the triggering input
+ - echo-gpios:	Definition of the GPIO for the echo
+		needs to be an interrupt input
+		See Documentation/devicetree/bindings/gpio/gpio.txt
+
+Example:
+srf04@0 {
+	compatible = "devantech,srf04";
+	trig-gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>;
+	echo-gpios = <&gpio2  6 GPIO_ACTIVE_HIGH>;
+};
+
Signature · 6 lines
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw
Quoted 1 line · Andreas Klinger

This patch adds dt binding for devantech ultrasonic ranger srf04.

comments below

Quoted 15 lines

The vendor "devantech" was already added to the vendor list with
"[PATCH v4 1/3] iio: distance: srf08: add trivial DT binding"

---
 .../bindings/iio/proximity/devantech-srf04.txt          | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt
Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt new file +0 -0
new file mode 100644
index 000000000000..4ea29ef3ff89

Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt line 7

Quoted 7 lines
Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt new file +7 -0
@@ -0,0 +1,17 @@
+* Devantech SRF04 ultrasonic range finder
+  Bit-banging driver
+
+Required properties:
+ - compatible:	Should be "devantech,srf04"
+ - trig-gpios:	Definition of the GPIO for the triggering input
+ - echo-gpios:	Definition of the GPIO for the echo

"for the echo"
maybe some more explanation? it sounds somewhat incomplete to me

in the driver you have "failed to get echo-gpiod", maybe it should be gpios there?

Quoted 11 lines
Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt new file +10 -0
+		needs to be an interrupt input
+		See Documentation/devicetree/bindings/gpio/gpio.txt
+
+Example:
+srf04@0 {
+	compatible = "devantech,srf04";
+	trig-gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>;
+	echo-gpios = <&gpio2  6 GPIO_ACTIVE_HIGH>;
+};
+
Signature · 2 lines
Peter Meerwald-Stadler
+43-664-2444418 (mobile)