Skip to contentSkip to conversation

ipv6: pointer math error in ip6_tnl_parse_tlv_enc_lim()

PATCH Applied Dan Carpenter 3 participants 3 messages Feb 1, 2017

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipv6: pointer math error in ip6_tnl_parse_tlv_enc_lim()

Casting is a high precedence operation but "off" and "i" are in terms of bytes so we need to have some parenthesis here.

Fixes fbfa743a9d2a ("ipv6: fix ip6_tnl_parse_tlv_enc_lim()")
net/ipv6/ip6_tunnel.c +1 -1
index ff8ee06491c3..75fac933c209 100644
@@ -441,7 +441,7 @@ __u16 ip6_tnl_parse_tlv_enc_lim(struct sk_buff *skb, __u8 *raw)
 				if (i + sizeof(*tel) > optlen)
 					break;
 
-				tel = (struct ipv6_tlv_tnl_enc_lim *) skb->data + off + i;
+				tel = (struct ipv6_tlv_tnl_enc_lim *)(skb->data + off + i);
 				/* return index of option if found and valid */
 				if (tel->type = IPV6_TLV_TNL_ENCAP_LIMIT &&
 				    tel->length = 1)