platform/x86: silead depends on I2C being built-in
PATCH 1/1 platform/x86: silead depends on I2C being built-in
The new driver cannot be a loadable module, so if I2C is loadable, we get this link error:
drivers/platform/built-in.o: In function `silead_ts_dmi_init':
silead_dmi.c:(.init.text+0x2ef): undefined reference to `i2c_bus_type'
This makes the Kconfig dependency stricter to require I2C=y.
--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/Kconfig +1 -1
@@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3 config SILEAD_DMI bool "Tablets with Silead touchscreens" - depends on ACPI && DMI && I2C && INPUT + depends on ACPI && DMI && I2C=y && INPUT ---help--- Certain ACPI based tablets with Silead touchscreens do not have enough data in ACPI tables for the touchscreen driver to handle
Signature · 1 line
2.9.0
Hi,
Quoted 10 lines · Arnd Bergmann
The new driver cannot be a loadable module, so if I2C is loadable, we get this link error:
drivers/platform/built-in.o: In function `silead_ts_dmi_init':
silead_dmi.c:(.init.text+0x2ef): undefined reference to `i2c_bus_type'This makes the
Kconfigdependency stricter to require I2C=y.Fixes 9eeda3897a85 ("platform/x86: add support for devices with Silead touchscreens")Signed-off-by Arnd Bergmann <[email protected]>
Thank you.
Regards.
Hans
Quoted 18 lines
--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/Kconfig +1
-1@@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3 config SILEAD_DMI bool "Tablets with Silead touchscreens" - depends on ACPI && DMI && I2C && INPUT + depends on ACPI && DMI && I2C=y && INPUT ---help--- Certain ACPI based tablets with Silead touchscreens do not have enough data in ACPI tables for the touchscreen driver to handle
Quoted 13 lines · Hans de Goede
Hi,
Quoted 10 lines · Arnd Bergmann
The new driver cannot be a loadable module, so if I2C is loadable, we get this
link error:
drivers/platform/built-in.o: In function `silead_ts_dmi_init':
silead_dmi.c:(.init.text+0x2ef): undefined reference to `i2c_bus_type'This makes the
Kconfigdependency stricter to require I2C=y.
Quoted 8 lines
Quoted 3 lines
Fixes 9eeda3897a85 ("platform/x86: add support for devices with Sileadtouchscreens")
Signed-off-by Arnd Bergmann <[email protected]>Thank you.
Acked-by Hans de Goede <[email protected]>
I'm a bit confused now:
http://www.spinics.net/lists/platform-driver-x86/msg10408.html
Please, clarify.
Quoted 26 lines
Regards.
Hans
Quoted 18 lines
--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/Kconfig +1
-1@@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3 config SILEAD_DMI bool "Tablets with Silead touchscreens" - depends on ACPI && DMI && I2C && INPUT + depends on ACPI && DMI && I2C=y && INPUT ---help--- Certain ACPI based tablets with Silead touchscreens do not have enough data in ACPI tables for the touchscreen driver to handle
Signature · 2 lines
With Best Regards, Andy Shevchenko
Hi,
Quoted 21 lines · Andy Shevchenko
Quoted 20 lines · Hans de Goede
Hi,
Quoted 5 lines · Arnd Bergmann
The new driver cannot be a loadable module, so if I2C is loadable, we get this
link error:Quoted 8 lines
drivers/platform/built-in.o: In function `silead_ts_dmi_init':
silead_dmi.c:(.init.text+0x2ef): undefined reference to `i2c_bus_type'This makes the
Kconfigdependency stricter to require I2C=y.Fixes 9eeda3897a85 ("platform/x86: add support for devices with Sileadtouchscreens")
Signed-off-by Arnd Bergmann <[email protected]>Thank you.
Quoted 7 lines
Quoted 1 line
Acked-by Hans de Goede <[email protected]>I'm a bit confused now:
http://www.spinics.net/lists/platform-driver-x86/msg10408.html
Please, clarify.
The depends on INPUT is not entirely wrong, the module does not need it, but without the SILEAD driver being build the silead_dmi code is of no use. Since multiple people already reported this I thought it would be best to just go ahead with Arnd's version.
Regards,
Hans
Quoted 30 lines
Quoted 27 lines
Regards.
Hans
Quoted 18 lines
--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/Kconfig +1
-1@@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3 config SILEAD_DMI bool "Tablets with Silead touchscreens" - depends on ACPI && DMI && I2C && INPUT + depends on ACPI && DMI && I2C=y && INPUT ---help--- Certain ACPI based tablets with Silead touchscreens do not have enough data in ACPI tables for the touchscreen driver to handle
Quoted 10 lines · Hans de Goede
Quoted 9 lines · Andy Shevchenko
Quoted 3 lines · Hans de Goede
Thank you.
Acked-by Hans de Goede <[email protected]>I'm a bit confused now:
Quoted 8 lines
Quoted 3 lines
http://www.spinics.net/lists/platform-driver-x86/msg10408.html
Please, clarify.
The depends on INPUT is not entirely wrong, the module does not need it, but without the SILEAD driver being build the
silead_dmicode is of no use. Since multiple people already reported this I thought it would be best to just go ahead with Arnd's version.
Thanks, pushed to testing.
Signature · 2 lines
With Best Regards, Andy Shevchenko