Skip to contentSkip to conversation

xfstests-bld: format filesystem with '-O encrypt' in encrypt config

PATCH Applied Eric Biggers 2 participants 2 messages Feb 6, 2017 – Feb 7, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests-bld: format filesystem with '-O encrypt' in encrypt config

From: Eric Biggers <[email protected]>

We were relying on the kernel setting the 'encrypt' feature flag for us. We should just do it in userspace when formatting the filesystem. This will allow us to eventually remove the kernel-side hack to force-set the 'encrypt' flag in the superblock.

---
 kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt +1 -1
index 390e205..320eff0 100644
@@ -1,5 +1,5 @@
 SIZE=small
-export MKFS_OPTIONS=""
+export MKFS_OPTIONS="-O encrypt"
 export EXT_MOUNT_OPTIONS="test_dummy_encryption"
 REQUIRE_FEATURE=encryption
 TESTNAME="Ext4 encryption"
Signature · 1 line
2.11.0.483.g087da7b7c-goog
#1 lore raw
Quoted 8 lines · Eric Biggers

From: Eric Biggers <[email protected]>

We were relying on the kernel setting the 'encrypt' feature flag for us. We should just do it in userspace when formatting the filesystem. This will allow us to eventually remove the kernel-side hack to force-set the 'encrypt' flag in the superblock.

Thanks, applied.

- Ted