Skip to contentSkip to conversation

plugins: telit: send AT&C0 on both channels

PATCH Superseded André Draszik 2 participants 3 messages Feb 7, 2017

lore
Share & tools
lore

André Draszik

author
#0 lore raw

PATCH 1/1 plugins: telit: send AT&C0 on both channels

At least firmware version 12.00.405 on the UE910-EUR otherwise closes the modem channel, and we'd be left in a funny state.

---
 plugins/telit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
plugins/telit.c +2 -1
index 742e06c0..0ae16408 100644
@@ -249,9 +249,10 @@ static void cfun_enable_cb(gboolean ok, GAtResult *result, gpointer user_data)
 	/*
 	 * Switch data carrier detect signal off.
 	 * When the DCD is disabled the modem does not hangup anymore
-	 * after the data connection.
+	 * after the data connection. We need to do that on both channels.
 	 */
 	g_at_chat_send(data->chat, "AT&C0", NULL, NULL, NULL, NULL);
+	g_at_chat_send(data->modem, "AT&C0", NULL, NULL, NULL, NULL);
 
 	data->have_sim = FALSE;
 	data->sms_phonebook_added = FALSE;
Signature · 1 line
2.11.0
author
#1 lore raw

PATCH v2 1/1 plugins: telit: send AT&C0 on both channels

At least firmware version 12.00.405 on the UE910-EUR otherwise closes the AT command port whenever the PPP connection is dropped, and we'd be left in a funny state.

---
Changes in v2: Commit message updated

---
 plugins/telit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
plugins/telit.c +2 -1
index 742e06c0..0ae16408 100644
@@ -249,9 +249,10 @@ static void cfun_enable_cb(gboolean ok, GAtResult *result, gpointer user_data)
 	/*
 	 * Switch data carrier detect signal off.
 	 * When the DCD is disabled the modem does not hangup anymore
-	 * after the data connection.
+	 * after the data connection. We need to do that on both channels.
 	 */
 	g_at_chat_send(data->chat, "AT&C0", NULL, NULL, NULL, NULL);
+	g_at_chat_send(data->modem, "AT&C0", NULL, NULL, NULL, NULL);
 
 	data->have_sim = FALSE;
 	data->sms_phonebook_added = FALSE;
Signature · 1 line
2.11.0
Applied
#2 lore raw

Hi André,

Quoted 10 lines · André Draszik

At least firmware version 12.00.405 on the UE910-EUR otherwise closes the AT command port whenever the PPP connection is dropped, and we'd be left in a funny state.

---
Changes in v2: Commit message updated

---
 plugins/telit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks.

Regards,
-Denis