cpufreq: s3c2416: double free on driver init error path
Subsystems (3)
PATCH 1/1 cpufreq: s3c2416: double free on driver init error path
The "goto err_armclk;" error path already does a clk_put(s3c_freq->hclk); so this is a double free.
drivers/cpufreq/s3c2416-cpufreq.c +0 -1
@@ -400,7 +400,6 @@ static int s3c2416_cpufreq_driver_init(struct cpufreq_policy *policy) rate =clk_get_rate (s3c_freq->hclk);if (rate <133 *1000 *1000 ) {pr_err ("cpufreq: HCLK not at 133MHz\n" ); -clk_put (s3c_freq->hclk); ret = -EINVAL ; goto err_armclk; }
Quoted 6 lines · Dan Carpenter
The "goto
err_armclk;" error path already does aclk_put(s3c_freq->hclk); so this is a double free.Fixes 34ee55075265 ("[CPUFREQ] Add S3C2416/S3C2450 cpufreq driver")Signed-off-by Dan Carpenter <[email protected]>
Best regards,
Krzysztof
Quoted 11 lines · Dan Carpenter
The "goto
err_armclk;" error path already does aclk_put(s3c_freq->hclk); so this is a double free.Fixes 34ee55075265 ("[CPUFREQ] Add S3C2416/S3C2450 cpufreq driver")Signed-off-by Dan Carpenter <[email protected]>drivers/cpufreq/s3c2416-cpufreq.c +0
-0
drivers/cpufreq/s3c2416-cpufreq.c static int s3c2416_cpufreq_driver_init(struct cpufreq_policy *policy) · line 405
Quoted 7 lines
drivers/cpufreq/s3c2416-cpufreq.c +0
-1@@ -400,7 +400,6 @@ static int s3c2416_cpufreq_driver_init(struct cpufreq_policy *policy) rate =clk_get_rate (s3c_freq->hclk);if (rate <133 *1000 *1000 ) {pr_err ("cpufreq: HCLK not at 133MHz\n" ); -clk_put (s3c_freq->hclk); ret = -EINVAL ; goto err_armclk; }
Signature · 1 line
viresh
Hi Dan,
Am Dienstag, 7. Februar 2017, 16:19:06 CET schrieb Dan Carpenter:
Quoted 5 lines
The "goto
err_armclk;" error path already does aclk_put(s3c_freq->hclk); so this is a double free.Fixes 34ee55075265 ("[CPUFREQ] Add S3C2416/S3C2450 cpufreq driver")Signed-off-by Dan Carpenter <[email protected]>
Interesting, you found a mistake I made 5 years ago.
It always amazes me how much time I already spent in kernel-land :-) .
Thanks for finding and fixing this
Heiko
Quoted 12 lines
(quoted diff) +0
-0
b/drivers/cpufreq/s3c2416-cpufreq.cindexd6d425773fa4..5b2db3c6568f100644drivers/cpufreq/s3c2416-cpufreq.c +0
-1@@ -400,7 +400,6 @@ static int s3c2416_cpufreq_driver_init(struct cpufreq_policy *policy) rate = clk_get_rate(s3c_freq->hclk);if (rate <133 *1000 *1000 ) {pr_err ("cpufreq: HCLK not at 133MHz\n" ); -clk_put (s3c_freq->hclk); ret = -EINVAL ; goto err_armclk; }