Skip to contentSkip to conversation

pinctrl: samsung: checking for IS_ERR() instead of NULL

PATCH In review Dan Carpenter 2 participants 2 messages Feb 8, 2017

Subsystems (5)
Kernel janitors GPIO Arm Samsung Exynos Pin control +1 more subsystems
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 pinctrl: samsung: checking for IS_ERR() instead of NULL

devm_ioremap() returns NULL on error. It doesn't return error pointers.

Fixes 8b1bd11c1f8f ("pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank")
Signed-off-by Dan Carpenter <[email protected]>
drivers/pinctrl/samsung/pinctrl-samsung.c +1 -1
index d79eadad6c5f..35b9d400d5c6 100644
@@ -990,7 +990,7 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d,
 		res = platform_get_resource(pdev, IORESOURCE_MEM, i);
 		virt_base[i] = devm_ioremap(&pdev->dev, res->start,
 						resource_size(res));
-		if (IS_ERR(virt_base[i]))
+		if (!virt_base[i])
 			return ERR_PTR(-EIO);
 	}