NFSv4: Fix memory and state leak in _nfs4_open_and_get_state
Subsystems (2)
PATCH 1/1 NFSv4: Fix memory and state leak in _nfs4_open_and_get_state
If we exit because the file access check failed, we currently leak the struct nfs4_state. We need to attach it to the open context before returning.
Fixes 3efb9722475e ("NFSv4: Refactor _nfs4_open_and_get_state..")
Cc [email protected] # 3.10+
Signed-off-by Trond Myklebust <[email protected]>
--- fs/nfs/nfs4proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfs/nfs4proc.c +1 -1
@@ -2730,6 +2730,7 @@ static int _nfs4_open_and_get_state(struct nfs4_opendata *opendata, ret =PTR_ERR (state);if (IS_ERR (state)) goto out; + ctx->state = state;if (server->caps &NFS_CAP_POSIX_LOCK )set_bit (NFS_STATE_POSIX_LOCKS , &state->flags);if (opendata->o_res.rflags &NFS4_OPEN_RESULT_MAY_NOTIFY_LOCK )
@@ -2755,7 +2756,6 @@ static int _nfs4_open_and_get_state(struct nfs4_opendata *opendata,if (ret !=0 ) goto out; - ctx->state = state;if (d_inode (dentry) == state->inode) {nfs_inode_attach_open_context (ctx);if (read_seqcount_retry (&sp->so_reclaim_seqcount, seq))
Signature · 1 line
2.9.3