staging: rtl8192e: Aligning the * on each line in block comments
PATCH v6 1/1 staging: rtl8192e: Aligning the * on each line in block comments
This patch fixes the issue by aligning the * on each line in block comments.
---
[Patch v1] is rejected as the changes done is not correct and is not following the linux kernel coding style in file drivers/staging/speakup/speakup_decpc.c as * on each line in block was not correctly alligned. [Patch v2] is rejected for not to mention the cause of rejection of [Patch v1] but warnings is corrected.
In [Patch v3] mention of the cause was not in the correct format and is not descriptive.
In [Patch v4] didn't send patch message to all the list members so asked to again repatch it.
In [Patch v5] in description is not given with proper line-feeds.
--- drivers/staging/speakup/fakekey.c | 10 +++++----- drivers/staging/speakup/i18n.c | 14 +++++++------- drivers/staging/speakup/main.c | 2 +- drivers/staging/speakup/speakup_acntsa.c | 2 +- drivers/staging/speakup/speakup_apollo.c | 2 +- drivers/staging/speakup/speakup_decext.c | 2 +- drivers/staging/speakup/speakup_decpc.c | 4 ++-- drivers/staging/speakup/speakup_dtlk.c | 2 +- drivers/staging/speakup/speakup_dtlk.h | 10 +++++----- drivers/staging/speakup/speakup_ltlk.c | 2 +- 10 files changed, 25 insertions(+), 25 deletions(-)
drivers/staging/speakup/fakekey.c +5 -5
@@ -63,8 +63,8 @@ void speakup_remove_virtual_keyboard(void) }/* -* Send a simulated down-arrow to the application. -*/ +* Send a simulated down-arrow to the application. +*/ void speakup_fake_down_arrow (void ) {unsigned long flags;
@@ -87,9 +87,9 @@ void speakup_fake_down_arrow(void) }/* -* Are we handling a simulated keypress on the current CPU? -* Returns a boolean. -*/ +* Are we handling a simulated keypress on the current CPU? +* Returns a boolean. +*/ bool speakup_fake_key_pressed (void ) {return this_cpu_read (reporting_keystroke);
drivers/staging/speakup/i18n.c +7 -7
@@ -401,7 +401,7 @@ char *spk_msg_get(enum msg_index_t index)* Finds the start of the next format specifier in the argument string. * Return value: pointer to start of format * specifier, or NULL if no specifier exists. -*/ +*/ static char *next_specifier (char *input) {int found =0 ;
@@ -450,7 +450,7 @@ static char *skip_width(char *input)* Note that this code only accepts a handful of conversion specifiers: * c d s x and ld. Not accidental; these are exactly the ones used in * the default group of formatted messages. -*/ +*/ static char *skip_conversion (char *input) {if ((input[0 ] =='l' ) && (input[1 ] =='d' ))
@@ -463,7 +463,7 @@ static char *skip_conversion(char *input)/* * Function: find_specifier_end * Return a pointer to the end of the format specifier. -*/ +*/ static char *find_specifier_end (char *input) { input++;/* Advance over %. */
@@ -478,7 +478,7 @@ static char *find_specifier_end(char *input)* Compare the format specifiers pointed to by *input1 and *input2. * Return 1 if they are the same, 0 otherwise. Advance *input1 and *input2 * so that they point to the character following the end of the specifier. -*/ +*/ static int compare_specifiers (char **input1,char **input2) {int same =0 ;
@@ -500,7 +500,7 @@ static int compare_specifiers(char **input1, char **input2)* Check that two format strings contain the same number of format specifiers, * and that the order of specifiers is the same in both strings. * Return 1 if the condition holds, 0 if it doesn't. -*/ +*/ static int fmt_validate (char *template,char *user) {int valid =1 ;
@@ -537,7 +537,7 @@ static int fmt_validate(char *template, char *user)* Failure conditions: * -EINVAL - Invalid format specifiers in formatted message or illegal index. * -ENOMEM - Unable to allocate memory. -*/ +*/ ssize_t spk_msg_set (enum msg_index_t index,char *text,size_t length) {int rc =0 ;
@@ -573,7 +573,7 @@ ssize_t spk_msg_set(enum msg_index_t index, char *text, size_t length)/* * Find a message group, given its name. Return a pointer to the structure * if found, or NULL otherwise. -*/ +*/ struct msg_group_t *spk_find_msg_group (const char *group_name) {struct msg_group_t *group =NULL ;
drivers/staging/speakup/main.c +1 -1
@@ -16,7 +16,7 @@* but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. -*/ +*/ #include <linux/kernel.h> #include <linux/vt.h>
drivers/staging/speakup/speakup_acntsa.c +1 -1
@@ -1,6 +1,6 @@/* * originally written by: Kirk Reiser <[email protected]> -* this version considerably modified by David Borowski, [email protected] +* this version considerably modified by David Borowski, [email protected] * * Copyright (C) 1998-99 Kirk Reiser. * Copyright (C) 2003 David Borowski.
drivers/staging/speakup/speakup_apollo.c +1 -1
@@ -1,6 +1,6 @@/* * originally written by: Kirk Reiser <[email protected]> -* this version considerably modified by David Borowski, [email protected] +* this version considerably modified by David Borowski, [email protected] * * Copyright (C) 1998-99 Kirk Reiser. * Copyright (C) 2003 David Borowski.
drivers/staging/speakup/speakup_decext.c +1 -1
@@ -1,6 +1,6 @@/* * originally written by: Kirk Reiser <[email protected]> -* this version considerably modified by David Borowski, [email protected] +* this version considerably modified by David Borowski, [email protected] * * Copyright (C) 1998-99 Kirk Reiser. * Copyright (C) 2003 David Borowski.
drivers/staging/speakup/speakup_decpc.c +2 -2
@@ -85,8 +85,8 @@#define CTRL_io_priority 0x0c00/* change i/o priority */ #define CTRL_free_mem 0x0d00/* get free paragraphs on module */ #define CTRL_get_lang 0x0e00/* return bit mask of loaded -* languages -*/ +* languages +*/ #define CMD_test 0x2000/* self-test request */ #define TEST_mask 0x0F00/* isolate test field */ #define TEST_null 0x0000/* no test requested */
drivers/staging/speakup/speakup_dtlk.c +1 -1
@@ -1,6 +1,6 @@/* * originally written by: Kirk Reiser <[email protected]> -* this version considerably modified by David Borowski, [email protected] +* this version considerably modified by David Borowski, [email protected] * * Copyright (C) 1998-99 Kirk Reiser. * Copyright (C) 2003 David Borowski.
drivers/staging/speakup/speakup_dtlk.h +5 -5
@@ -24,11 +24,11 @@* usec later. */ #define TTS_ALMOST_FULL 0x08/* mask for AF bit: When set to 1, -* indicates that less than 300 bytes -* are available in the TTS input -* buffer. AF is always 0 in the PCM, -* TGN and CVSD modes. -*/ +* indicates that less than 300 bytes +* are available in the TTS input +* buffer. AF is always 0 in the PCM, +* TGN and CVSD modes. +*/ #define TTS_ALMOST_EMPTY 0x04/* mask for AE bit: When set to 1, * indicates that less than 300 bytes * are remaining in DoubleTalk's input
drivers/staging/speakup/speakup_ltlk.c +1 -1
@@ -1,6 +1,6 @@/* * originally written by: Kirk Reiser <[email protected]> -* this version considerably modified by David Borowski, [email protected] +* this version considerably modified by David Borowski, [email protected] * * Copyright (C) 1998-99 Kirk Reiser. * Copyright (C) 2003 David Borowski.
Signature · 1 line
2.11.0
Greg KH
maintainerQuoted 3 lines · Arushi
This patch fixes the issue by aligning the * on each line in block comments.
Signed-off-by Arushi Singhal <[email protected]>
Your "From:" line in your email does not match this name here, please fix up and try again.
Also, please properly wrap your changelog lines at 72 columns.
Quoted 6 lines
---
[Patch v1] is rejected as the changes done is not correct and is not following the linux kernel coding style in filedrivers/staging/speakup/speakup_decpc.cas * on each line in block was not correctly alligned. [Patch v2] is rejected for not to mention the cause of rejection of [Patch v1] but warnings is corrected.
In [Patch v3] mention of the cause was not in the correct format and is not descriptive.
In [Patch v4] didn't send patch message to all the list members so asked to again repatch it.
In [Patch v5] in description is not given with proper line-feeds.
Also wrap these properly.
thanks,
greg k-h