Skip to contentSkip to conversation

staging:vt6656:channel.h: fix function definition argument without identifier name issue

PATCH In review Arushi Singhal 2 participants 3 messages Feb 9, 2017 – Feb 11, 2017 3 messages not in the archive Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging:vt6656:channel.h: fix function definition argument without identifier name issue

Function definitions arguments should also have an identifier name as reported by checkpatch.pl.

---
 drivers/staging/vt6656/channel.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6656/channel.h +1 -1
index fcea6995fe26..62f18a959098 100644
@@ -28,6 +28,6 @@
 
 #include "device.h"
 
-void vnt_init_bands(struct vnt_private *);
+void vnt_init_bands(struct vnt_private *priv);
 
 #endif  /* _CHANNEL_H_ */
Signature · 1 line
2.11.0
maintainer
#1 lore raw
Quoted 7 lines · Arushi Singhal

Function definitions arguments should also have an identifier name as reported by checkpatch.pl.

---
 drivers/staging/vt6656/channel.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Does not apply to my tree :(

A message that is not in the archive (sent off-list or not yet received): CA+XqjF-+8p6uzzs-s1pWH39vg-UppnO-aCmEKQjqDeYd1c+nmA@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CA+XqjF9ATSxEj4hYbE47ZswPokmGdCWgi7w6PWh5o9jw6_VYoQ@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CA+XqjF-vMtXqNEi+B-2by+fuFXA4H+kCPypWK5pwQvNnKSidqw@mail.gmail.com

maintainer
#5 lore raw
Quoted 2 lines · Arushi Singhal

Hi
Sorry Greg but how this not applying to your mailing list.

Your patch did not apply to my staging-next git tree. Probably because soemone else already did this same work before you did. Try rebasing your patch on my staging-next branch of staging.git on git.kernel.org and see for yourself.

thanks,

greg k-h