Skip to contentSkip to conversation

drm/exynos/decon5433: & vs | typo

PATCH In review Dan Carpenter 2 participants 2 messages Feb 14, 2017 – Feb 20, 2017

Subsystems (4)
DRM drivers Kernel janitors Arm Samsung Exynos DRM drivers for Exynos
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 drm/exynos/decon5433: & vs | typo

"&" was obviously intended instead of "|". The original condition is always true.

Fixes b93c2e8b5d9d ("drm/exynos/decon5433: configure sysreg in case of hardware trigger")
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/exynos/exynos5433_drm_decon.c +1 -1
index 0fd6f7a18364..cca32a4fdab3 100644
@@ -678,7 +678,7 @@ static int exynos5433_decon_probe(struct platform_device *pdev)
 		ctx->out_type |= IFTYPE_I80;
 	}
 
-	if (ctx->out_type | I80_HW_TRG) {
+	if (ctx->out_type & I80_HW_TRG) {
 		ctx->sysreg = syscon_regmap_lookup_by_phandle(dev->of_node,
 							"samsung,disp-sysreg");
 		if (IS_ERR(ctx->sysreg)) {
maintainer
#1 lore raw

Merged.

Thanks,
Inki Dae

2017년 02월 14일 16:46에 Dan Carpenter 이(가) 쓴 글:

Quoted 25 lines

"&" was obviously intended instead of "|". The original condition is always true.

Fixes b93c2e8b5d9d ("drm/exynos/decon5433: configure sysreg in case of hardware trigger")
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/exynos/exynos5433_drm_decon.c +1 -2
index 0fd6f7a18364..cca32a4fdab3 100644
@@ -678,7 +678,7 @@ static int exynos5433_decon_probe(struct platform_device *pdev)
 		ctx->out_type |= IFTYPE_I80;
 	}
 
-	if (ctx->out_type | I80_HW_TRG) {
+	if (ctx->out_type & I80_HW_TRG) {
 		ctx->sysreg = syscon_regmap_lookup_by_phandle(dev->of_node,
 							"samsung,disp-sysreg");
 		if (IS_ERR(ctx->sysreg)) {
--

To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html