Skip to contentSkip to conversation

dt-bindings: net: generalize moxart-mac to support all faraday based ftmac IP

PATCH Superseded Greentime Hu 3 participants 3 messages Feb 14, 2017 – Feb 22, 2017

Subsystems (2)
Network drivers Device tree bindings

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Greentime Hu

author
#0 lore raw

PATCH 1/1 dt-bindings: net: generalize moxart-mac to support all faraday based ftmac IP

Andestech and moxa use the same faraday mac IP, so we use faraday,ftmac.txt to describe it.

Signed-off-by Greentime Hu <[email protected]>
---
 .../net/{moxa,moxart-mac.txt => faraday,ftmac.txt} |    7 +++++--
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 2 files changed, 6 insertions(+), 2 deletions(-)
 rename Documentation/devicetree/bindings/net/{moxa,moxart-mac.txt => faraday,ftmac.txt} (68%)
Documentation/devicetree/bindings/net/faraday,ftmac.txt renamed from Documentation/devicetree/bindings/net/moxa,moxart-mac.txt +5 -2
similarity index 68%
rename from Documentation/devicetree/bindings/net/moxa,moxart-mac.txt
rename to Documentation/devicetree/bindings/net/faraday,ftmac.txt
index 583418b..be4f55e 100644
@@ -1,8 +1,11 @@
-MOXA ART Ethernet Controller
+Faraday Ethernet Controller
 
 Required properties:
 
-- compatible : Must be "moxa,moxart-mac"
+- compatible : Must contain "faraday,ftmac", as well as one of
+		the SoC specific identifiers:
+		"andestech,atmac100"
+		"moxa,moxart-mac"
 - reg : Should contain register location and length
 - interrupts : Should contain the mac interrupt number
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index 16d3b5e..489c336 100644
@@ -102,6 +102,7 @@ everest	Everest Semiconductor Co. Ltd.
 everspin	Everspin Technologies, Inc.
 excito	Excito
 ezchip	EZchip Semiconductor
+faraday	Faraday Technology Corporation
 fcs	Fairchild Semiconductor
 firefly	Firefly
 focaltech	FocalTech Systems Co.,Ltd
Signature · 6 lines
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw
Quoted 17 lines · Greentime Hu

Andestech and moxa use the same faraday mac IP, so we use faraday,ftmac.txt to describe it.

Signed-off-by Greentime Hu <[email protected]>
---
 .../net/{moxa,moxart-mac.txt => faraday,ftmac.txt} |    7 +++++--
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 2 files changed, 6 insertions(+), 2 deletions(-)
 rename Documentation/devicetree/bindings/net/{moxa,moxart-mac.txt => faraday,ftmac.txt} (68%)
Documentation/devicetree/bindings/net/faraday,ftmac.txt renamed from Documentation/devicetree/bindings/net/moxa,moxart-mac.txt +0 -0
similarity index 68%
rename from Documentation/devicetree/bindings/net/moxa,moxart-mac.txt
rename to Documentation/devicetree/bindings/net/faraday,ftmac.txt
index 583418b..be4f55e 100644

Documentation/devicetree/bindings/net/faraday,ftmac.txt line 8

Quoted 10 lines
Documentation/devicetree/bindings/net/faraday,ftmac.txt renamed from Documentation/devicetree/bindings/net/moxa,moxart-mac.txt +5 -2
@@ -1,8 +1,11 @@
-MOXA ART Ethernet Controller
+Faraday Ethernet Controller
 
 Required properties:
 
-- compatible : Must be "moxa,moxart-mac"
+- compatible : Must contain "faraday,ftmac", as well as one of
+               the SoC specific identifiers:
+               "andestech,atmac100"
+               "moxa,moxart-mac"

Looks right to me.

Documentation/devicetree/bindings/net/faraday,ftmac.txt line 9

Quoted 1 line
Documentation/devicetree/bindings/net/faraday,ftmac.txt renamed from Documentation/devicetree/bindings/net/moxa,moxart-mac.txt +1 -0
+faraday        Faraday Technology Corporation

I think Rob already has this part on queue.

Yours,
Linus Walleij

maintainer
#2 lore raw
In reply to Greentime Hu
Quoted 1 line · Greentime Hu

Andestech and moxa use the same faraday mac IP, so we use faraday,ftmac.txt to describe it.

Please wrap your lines.

Quoted 33 lines
Signed-off-by Greentime Hu <[email protected]>
---
 .../net/{moxa,moxart-mac.txt => faraday,ftmac.txt} |    7 +++++--
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 2 files changed, 6 insertions(+), 2 deletions(-)
 rename Documentation/devicetree/bindings/net/{moxa,moxart-mac.txt => faraday,ftmac.txt} (68%)
Documentation/devicetree/bindings/net/faraday,ftmac.txt renamed from Documentation/devicetree/bindings/net/moxa,moxart-mac.txt +5 -2
similarity index 68%
rename from Documentation/devicetree/bindings/net/moxa,moxart-mac.txt
rename to Documentation/devicetree/bindings/net/faraday,ftmac.txt
index 583418b..be4f55e 100644
@@ -1,8 +1,11 @@
-MOXA ART Ethernet Controller
+Faraday Ethernet Controller
 
 Required properties:
 
-- compatible : Must be "moxa,moxart-mac"
+- compatible : Must contain "faraday,ftmac", as well as one of
+		the SoC specific identifiers:
+		"andestech,atmac100"
+		"moxa,moxart-mac"
 - reg : Should contain register location and length
 - interrupts : Should contain the mac interrupt number
Documentation/devicetree/bindings/vendor-prefixes.txt +0 -0
index 16d3b5e..489c336 100644

Documentation/devicetree/bindings/vendor-prefixes.txt everest Everest Semiconductor Co. Ltd. · line 105

Quoted 4 lines
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
@@ -102,6 +102,7 @@ everest	Everest Semiconductor Co. Ltd.
 everspin	Everspin Technologies, Inc.
 excito	Excito
 ezchip	EZchip Semiconductor
+faraday	Faraday Technology Corporation

As Linus mentioned, I did apply the same thing already, so drop this hunk.

Quoted 6 lines
Documentation/devicetree/bindings/vendor-prefixes.txt +0 -0
 fcs	Fairchild Semiconductor
 firefly	Firefly
 focaltech	FocalTech Systems Co.,Ltd
Signature · 1 line
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html