Staging: bcm2835-audio: && vs & typo

PATCH New Dan Carpenter 1 participant 1 message Feb 14, 2017

Subsystems (4)

Staging Kernel janitors Broadcom BCM2711/BCM2835 Arm architecture Broadcom BCM281XX/BCM11XXX/BCM216XX Arm architecture

lore

Share & tools

lore

Dan Carpenter

author

2017-02-14 23:10 UTC #0 lore raw

PATCH 1/1 Staging: bcm2835-audio: && vs & typo

We intended to mask away the upper bits but there is a "&&" vs "&" typo so it's broken.

Fixes 23b028c871e1 ("staging: bcm2835-audio: initial staging submission")

Signed-off-by Dan Carpenter <[email protected]>

drivers/staging/bcm2835-audio/bcm2835-ctl.c +1 -0

index bfb7e9f74176..a4ffa1bf53e5 100644
@@ -209,7 +209,7 @@ static int snd_bcm2835_spdif_default_get(struct snd_kcontrol *kcontrol,
 
 	for (i = 0; i < 4; i++)
 		ucontrol->value.iec958.status[i] -		(chip->spdif_status >> (i * 8)) && 0xff;
+			(chip->spdif_status >> (i * 8)) & 0xff;
 
 	mutex_unlock(&chip->audio_mutex);
 	return 0;