remoteproc: qcom: mdt_loader: Use signed type for offset
PATCH 1/1 remoteproc: qcom: mdt_loader: Use signed type for offset
In the transition from using rproc_da_to_va(), the type of the load offset became unsigned. This causes the subsequent check to let negative values less than p_memsz + mem_size through and we write outside of the buffer.
Change the type back to a signed value to catch this.
Fixes 7f0dd07a9b29 ("remoteproc: qcom: mdt_loader: Refactor MDT loader")
Fixes e7fd25226295 ("remoteproc: qcom: q6v5: Decouple driver from MDT loader")
Reported-by Dan Carpenter <[email protected]>
Reported-by Stanimir Varbanov <[email protected]>
Signed-off-by Bjorn Andersson <[email protected]>
--- drivers/remoteproc/qcom_q6v5_pil.c | 2 +- drivers/soc/qcom/mdt_loader.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/remoteproc/qcom_q6v5_pil.c +1 -1
@@ -502,7 +502,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc)phys_addr_t max_addr =0 ;bool relocate = false;char seg_name[10 ]; -size_t offset; +ssize_t offset;size_t size;void *ptr;int ret;
drivers/soc/qcom/mdt_loader.c +1 -1
@@ -98,7 +98,7 @@ int qcom_mdt_load(struct device *dev, const struct firmware *fw,phys_addr_t min_addr = (phys_addr_t )ULLONG_MAX ;phys_addr_t max_addr =0 ;size_t fw_name_len; -size_t offset; +ssize_t offset;char *fw_name;bool relocate = false;void *ptr;
Signature · 1 line
2.11.0
Quoted 5 lines · Bjorn Andersson
In the transition from using
rproc_da_to_va(), the type of the load offset became unsigned. This causes the subsequent check to let negative values less thanp_memsz+mem_sizethrough and we write outside of the buffer.
Quoted 7 lines
Change the type back to a signed value to catch this.
Fixes 7f0dd07a9b29 ("remoteproc: qcom: mdt_loader: Refactor MDT loader")Fixes e7fd25226295 ("remoteproc: qcom: q6v5: Decouple driver from MDT loader")Reported-by Dan Carpenter <[email protected]>Reported-by Stanimir Varbanov <[email protected]>Signed-off-by Bjorn Andersson <[email protected]>
Acked-by Andy Gross <[email protected]>