Skip to contentSkip to conversation

dpaa_eth: small leak on error

PATCH Applied Dan Carpenter 2 participants 2 messages Feb 16, 2017 – Feb 17, 2017

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dpaa_eth: small leak on error

This should be >= instead of > here. It means that we don't increment the free count enough so it becomes off by one.

Fixes 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet")

---
Applies to -net tree.

drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +1 -1
index 25a14a3fe784..bc5a3347fd4a 100644
@@ -1666,7 +1666,7 @@ static struct sk_buff *sg_fd_to_skb(const struct dpaa_priv *priv,
 
 free_buffers:
 	/* compensate sw bpool counter changes */
-	for (i--; i > 0; i--) {
+	for (i--; i >= 0; i--) {
 		dpaa_bp = dpaa_bpid2pool(sgt[i].bpid);
 		if (dpaa_bp) {
 			count_ptr = this_cpu_ptr(dpaa_bp->percpu_count);
maintainer Applied
#1 lore raw

From: Dan Carpenter <[email protected]>
Date: Thu, 16 Feb 2017 12:56:10 +0300

Quoted 7 lines

This should be >= instead of > here. It means that we don't increment the free count enough so it becomes off by one.

Fixes 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet")

---
Applies to -net tree.

Applied, thanks Dan.