Skip to contentSkip to conversation

staging: rtl8712: Moved logical OR operator to previous line.

PATCH In review Varsha Rao 2 participants 3 messages Feb 17, 2017 Staging

lore
Share & tools
lore

Varsha Rao

author
#0 lore raw

PATCH v2 1/1 staging: rtl8712: Moved logical OR operator to previous line.

Moved logical OR operator to previous line to fix the following checkpatch issue:

CHECK: Logical continuations should be on the previous line.

---
v2:

-Edited commit message.
-Fixed the warning of line over 80 characters.

 drivers/staging/rtl8712/ieee80211.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/rtl8712/ieee80211.c +3 -2
index d84da2b..f35121e 100644
@@ -288,8 +288,9 @@ int r8712_parse_wpa_ie(u8 *wpa_ie, int wpa_ie_len, int *group_cipher,
 		/* No WPA IE - fail silently */
 		return _FAIL;
 	}
-	if ((*wpa_ie != _WPA_IE_ID_) || (*(wpa_ie + 1) != (u8)(wpa_ie_len - 2))
-	     || (memcmp(wpa_ie + 2, (void *)WPA_OUI_TYPE, WPA_SELECTOR_LEN)))
+	if ((*wpa_ie != _WPA_IE_ID_) ||
+	    (*(wpa_ie + 1) != (u8)(wpa_ie_len - 2)) ||
+	    (memcmp(wpa_ie + 2, (void *)WPA_OUI_TYPE, WPA_SELECTOR_LEN)))
 		return _FAIL;
 	pos = wpa_ie;
 	pos += 8;
Signature · 1 line
2.9.3
Acked-by drivers/staging/rtl8712/ieee80211.c on v2 1/1
#1 lore raw
Quoted 4 lines · Varsha Rao

Moved logical OR operator to previous line to fix the following checkpatch issue:

CHECK: Logical continuations should be on the previous line.

Acked-by drivers/staging/rtl8712/ieee80211.c
Quoted 36 lines

---
v2:

-Edited commit message.
-Fixed the warning of line over 80 characters.

 drivers/staging/rtl8712/ieee80211.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/rtl8712/ieee80211.c +3 -3
index d84da2b..f35121e 100644
@@ -288,8 +288,9 @@ int r8712_parse_wpa_ie(u8 *wpa_ie, int wpa_ie_len, int *group_cipher,
 		/* No WPA IE - fail silently */
 		return _FAIL;
 	}
-	if ((*wpa_ie != _WPA_IE_ID_) || (*(wpa_ie + 1) != (u8)(wpa_ie_len - 2))
-	     || (memcmp(wpa_ie + 2, (void *)WPA_OUI_TYPE, WPA_SELECTOR_LEN)))
+	if ((*wpa_ie != _WPA_IE_ID_) ||
+	    (*(wpa_ie + 1) != (u8)(wpa_ie_len - 2)) ||
+	    (memcmp(wpa_ie + 2, (void *)WPA_OUI_TYPE, WPA_SELECTOR_LEN)))
 		return _FAIL;
 	pos = wpa_ie;
 	pos += 8;
--

2.9.3

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170217051238.GA3213%40euri.
For more options, visit https://groups.google.com/d/optout.

Acked-by
#2 lore raw
Quoted 10 lines · Julia Lawall
Quoted 4 lines · Varsha Rao

Moved logical OR operator to previous line to fix the following checkpatch issue:

CHECK: Logical continuations should be on the previous line.

Acked-by drivers/staging/rtl8712/ieee80211.c

Sorry!

Quoted 38 lines
Quoted 37 lines

---
v2:

-Edited commit message.
-Fixed the warning of line over 80 characters.

 drivers/staging/rtl8712/ieee80211.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/rtl8712/ieee80211.c +3 -3
index d84da2b..f35121e 100644
@@ -288,8 +288,9 @@ int r8712_parse_wpa_ie(u8 *wpa_ie, int wpa_ie_len, int *group_cipher,
 		/* No WPA IE - fail silently */
 		return _FAIL;
 	}
-	if ((*wpa_ie != _WPA_IE_ID_) || (*(wpa_ie + 1) != (u8)(wpa_ie_len - 2))
-	     || (memcmp(wpa_ie + 2, (void *)WPA_OUI_TYPE, WPA_SELECTOR_LEN)))
+	if ((*wpa_ie != _WPA_IE_ID_) ||
+	    (*(wpa_ie + 1) != (u8)(wpa_ie_len - 2)) ||
+	    (memcmp(wpa_ie + 2, (void *)WPA_OUI_TYPE, WPA_SELECTOR_LEN)))
 		return _FAIL;
 	pos = wpa_ie;
 	pos += 8;
--

2.9.3

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170217051238.GA3213%40euri.
For more options, visit https://groups.google.com/d/optout.