staging: rtl8192e: Fix block comments warning
PATCH 3/6 staging: rtl8192e: Fix block comments warning
Align * on a line, to conform to the kernal coding style for block comments.
--- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtl819x_HT.h +1 -1
@@ -11,7 +11,7 @@* * Contact Information: * wlanfae <[email protected]> -******************************************************************************/ +******************************************************************************/ #ifndef _RTL819XU_HTTYPE_H_#define _RTL819XU_HTTYPE_H_
Signature · 1 line
2.7.4
Quoted 2 lines · simran singhal
Align * on a line, to conform to the kernal coding style for block comments.
It is not clear what is means to align * on a line. What line?
What has been done is to add a space at the beginning of the line. But then the line goes over 80 characters and doesn't line up any more on the right side. I would guess that you should have gotten a new warning by having gone over 80 characters. Fixing one warning should not introduce a new one, especially for something purely decorative, like this.
julia
Quoted 29 lines
Signed-off-by simran singhal <[email protected]>--- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8192e/rtl819x_HT.h +1
-2@@ -11,7 +11,7 @@* * Contact Information: * wlanfae <[email protected]> -******************************************************************************/ +******************************************************************************/ #ifndef _RTL819XU_HTTYPE_H_#define _RTL819XU_HTTYPE_H_ --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218152351.GA28908%40singhal-Inspiron-5558.
For more options, visit https://groups.google.com/d/optout.
Quoted 16 lines · Julia Lawall
Quoted 2 lines · simran singhal
Align * on a line, to conform to the kernal coding style for block comments.
It is not clear what is means to align * on a line. What line?
What has been done is to add a space at the beginning of the line. But then the line goes over 80 characters and doesn't line up any more on the right side. I would guess that you should have gotten a new warning by having gone over 80 characters. Fixing one warning should not introduce a new one, especially for something purely decorative, like this.
Quoted 3 lines
julia
Julia, I am not getting any new warning. It's not gone over 80
characters.
Quoted 39 lines
Review
Quoted 7 lines
Signed-off-by simran singhal <[email protected]>---
drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/staging/rtl8192e/rtl819x_HT.hdrivers/staging/rtl8192e/rtl819x_HT.h line 14
Quoted 8 lines
index 6eb018f..48d101a 100644
drivers/staging/rtl8192e/rtl819x_HT.h +0
-0@@ -11,7 +11,7 @@* * Contact Information: * wlanfae <[email protected]> -******************************************************************************/
drivers/staging/rtl8192e/rtl819x_HT.h line 15
Quoted 1 line
drivers/staging/rtl8192e/rtl819x_HT.h +1
-0+******************************************************************************/
Quoted 8 lines
drivers/staging/rtl8192e/rtl819x_HT.h +0
-0#ifndef _RTL819XU_HTTYPE_H_#define _RTL819XU_HTTYPE_H_Signature · 5 lines
-- 2.7.4 -- You received this message because you are subscribed to the GoogleGroups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
Quoted 2 lines
To post to this group, send email to [email protected]. To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/20170218152351.GA28908%40singhal-Inspiron-5558.
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.
Quoted 22 lines · SIMRAN SINGHAL
On Saturday, February 18, 2017 at 9:00:51 PM UTC+5:30, Julia Lawall wrote:
On Sat, 18 Feb 2017, simran singhal wrote:
> Align * on a line, to conform to the kernal coding > style for block comments.
It is not clear what is means to align * on a line. ᅵWhat line?
What has been done is to add a space at the beginning of the line. ᅵBut
then the line goes over 80 characters and doesn't line up any more on the
right side. ᅵI would guess that you should have gotten a new warning by
having gone over 80 characters. Fixing one warning should not introduce a
new one, especially for something purely decorative, like this.
Quoted 3 lines
julia
ᅵJulia, I am not getting any new warning. It's not gone over 80 characters.
OK, it looked like it would be too long on my screen.
Are the right sides of the * lines lined up after the change?
julia
Quoted 49 lines
ᅵ
> > Signed-off-by: simran singhal <[email protected]> > --- > ᅵdrivers/staging/rtl8192e/rtl819x_HT.h | 2 +- > ᅵ1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h > index 6eb018f..48d101a 100644 > --- a/drivers/staging/rtl8192e/rtl819x_HT.h > +++ b/drivers/staging/rtl8192e/rtl819x_HT.h > @@ -11,7 +11,7 @@ > ᅵ * > ᅵ * Contact Information: > ᅵ * wlanfae <[email protected]> >-************************************************************************** ****/ > +*************************************************************************** ***/ > ᅵ#ifndef _RTL819XU_HTTYPE_H_ > ᅵ#define _RTL819XU_HTTYPE_H_ > > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170218152351.GA28908%4 0singhal-Inspiron-5558. > For more options, visit https://groups.google.com/d/optout. >--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/5192275f-5b36-4e1d-8d66- afc735f3a8f6%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Quoted 99 lines · Julia Lawall
Quoted 3 lines · SIMRAN SINGHAL
On Saturday, February 18, 2017 at 9:00:51 PM UTC+5:30, Julia Lawall
Quoted 19 lines · wrote:
On Sat, 18 Feb 2017, simran singhal wrote:
> Align * on a line, to conform to the kernal coding > style for block comments.
It is not clear what is means to align * on a line. What line?
What has been done is to add a space at the beginning of the line. But
then the line goes over 80 characters and doesn't line up any more on the
right side. I would guess that you should have gotten a new warning by
having gone over 80 characters. Fixing one warning should not introduce a
new one, especially for something purely decorative, like this.Quoted 3 lines
julia
Julia, I am not getting any new warning. It's not gone over 80
characters.
OK, it looked like it would be too long on my screen.
Are the right sides of the * lines lined up after the change?
julia
In the right sides of the * lines, stars are lined up.
Quoted 17 lines
> > Signed-off-by: simran singhal <[email protected]> > --- > drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h > index 6eb018f..48d101a 100644 > --- a/drivers/staging/rtl8192e/rtl819x_HT.h > +++ b/drivers/staging/rtl8192e/rtl819x_HT.h > @@ -11,7 +11,7 @@ > * > * Contact Information: > * wlanfae <[email protected]>Quoted 4 lines
-**************************************************************************
****/ >+***************************************************************************
Quoted 7 lines
***/ > #ifndef _RTL819XU_HTTYPE_H_ > #define _RTL819XU_HTTYPE_H_ > > -- > 2.7.4 >Quoted 8 lines
> -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170218152351.GA28908%4
Quoted 6 lines
0singhal-Inspiron-5558. > For more options, visit https://groups.google.com/d/optout. >Signature · 1 line
You received this message because you are subscribed to the GoogleGroups
Quoted 2 lines
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, sendan
Quoted 2 lines
email to [email protected] <javascript:>. To post to this group, send email to [email protected]
<javascript:>.
Quoted 1 line
To view this discussion on the web visithttps://
groups.google.com/d/msgid/outreachy-kernel/5192275f-5b36-4e1d-8d66-
Quoted 4 lines
afc735f3a8f6%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Quoted 41 lines · SIMRAN SINGHAL
On Saturday, February 18, 2017 at 9:46:48 PM UTC+5:30, Julia Lawall wrote:
On Sat, 18 Feb 2017, SIMRAN SINGHAL wrote:
>
>
> On Saturday, February 18, 2017 at 9:00:51 PM UTC+5:30, Julia Lawall wrote:
>
>
> On Sat, 18 Feb 2017, simran singhal wrote:
>
> > Align * on a line, to conform to the kernal coding > > style for block comments.
>
> It is not clear what is means to align * on a line. What line?
>
> What has been done is to add a space at the beginning of the
> line. But
> then the line goes over 80 characters and doesn't line up any
> more on the
> right side. I would guess that you should have gotten a new
> warning by
> having gone over 80 characters. Fixing one warning should not
> introduce a
> new one, especially for something purely decorative, like this.
>
> julia
>
> Julia, I am not getting any new warning. It's not gone over 80 characters.
Quoted 7 lines
OK, it looked like it would be too long on my screen.
Are the right sides of the * lines lined up after the change?
julia
In the right sides of the * lines, stars are lined up.
OK, thanks.
julia
Quoted 71 lines
>
> >
> > Signed-off-by: simran singhal <[email protected]>
> > ---
> > drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --gita/drivers/staging/rtl8192e/rtl819x_HT.h
>b/drivers/staging/rtl8192e/rtl819x_HT.h
> > index 6eb018f..48d101a 100644
> > ---a/drivers/staging/rtl8192e/rtl819x_HT.h
> > +++b/drivers/staging/rtl8192e/rtl819x_HT.h
> > @@ -11,7 +11,7 @@
> > *
> > * Contact Information:
> > * wlanfae <[email protected]>
> >-*************************************************************************
*
> ****/
> >+**************************************************************************
*
> ***/
> > #ifndef _RTL819XU_HTTYPE_H_
> > #define _RTL819XU_HTTYPE_H_
> >
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed
to the
> Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving
emails from
> it, send an email to [email protected].
> > To post to this group, send email to
> [email protected].
> > To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/20170218152351.GA28 908%4
> 0singhal-Inspiron-5558.
> > For more options, visit
https://groups.google.com/d/optout.
> >
>
> --
> You received this message because you are subscribed to the
Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from
it, send an
> email to [email protected].
> To post to this group, send email to
[email protected].
> To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/5192275f-5b36-4e1d- 8d66-
> afc735f3a8f6%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/da5a9bc2-9a49-4fac-b7e8- eb686d14ad1e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.