sunrpc: silence uninitialized variable warning

PATCH New Dan Carpenter 1 participant 1 message Feb 18, 2017

Subsystems (5)

Networking Network drivers Kernel janitors NFS client +1 more subsystems

lore

Share & tools

lore

Dan Carpenter

author

2017-02-18 21:34 UTC #0 lore raw

PATCH 1/1 sunrpc: silence uninitialized variable warning

kstrtouint() can return a couple different error codes so the check for "ret = -EINVAL" is wrong and static analysis tools correctly complain that we can use "num" without initializing it. It's not super harmful because we check the bounds. But it's also easy enough to fix.

Signed-off-by Dan Carpenter <[email protected]>

net/sunrpc/xprtsock.c +3 -1

index 956c7bce80d1..311ce92384b7 100644
@@ -3209,7 +3209,9 @@ static int param_set_uint_minmax(const char *val,
 	if (!val)
 		return -EINVAL;
 	ret = kstrtouint(val, 0, &num);
-	if (ret = -EINVAL || num < min || num > max)
+	if (ret)
+		return ret;
+	if (num < min || num > max)
 		return -EINVAL;
 	*((unsigned int *)kp->arg) = num;
 	return 0;