Skip to contentSkip to conversation

sigprocmask.2: do not specify an exact value of rt_sigprocmask's 4th argument

PATCH Superseded Dmitry V. Levin 3 participants 5 messages Feb 19, 2017 – Mar 24, 2017 3 messages not in the archive Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sigprocmask.2: do not specify an exact value of rt_sigprocmask's 4th argument

As sizeof(kernel_sigset_t) is not the same for all architectures, it would be better not to mention any numbers as its value.

---
 man2/sigprocmask.2 | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
man2/sigprocmask.2 +5 -4
index 8388340..6379a4d 100644
@@ -202,10 +202,11 @@ which specifies the size in bytes of the signal sets in
 .IR set
 and
 .IR oldset .
-This argument is currently required to have the value 8
-(
-.IR sizeof(kernel_sigset_t)
-).
+This argument is currently required to have a fixed value
+(equal to
+.IR sizeof(kernel_sigset_t) ).
+.\" sizeof(kernel_sigset_t) == _NSIG / 8,
+.\" which equals to 8 on most architectures, but e.g. on MIPS it's 16.
 
 The glibc
 .BR sigprocmask ()
Signature · 6 lines
ldv

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20170219211302.GA30235-u2l5PoMzF/[email protected]

#2 lore raw

Am 19.02.2017 22:13, schrieb Dmitry V. Levin:

Quoted 18 lines

As sizeof(kernel_sigset_t) is not the same for all architectures, it would be better not to mention any numbers as its value.

---
 man2/sigprocmask.2 | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
man2/sigprocmask.2 +0 -2
index 8388340..6379a4d 100644
@@ -202,10 +202,11 @@ which specifies the size in bytes of the signal sets in
 .IR set
 and
 .IR oldset .
-This argument is currently required to have the value 8
-(

man2/sigprocmask.2 which specifies the size in bytes of the signal sets in · line 212

Quoted 10 lines
man2/sigprocmask.2 +5 -2
-.IR sizeof(kernel_sigset_t)
-).
+This argument is currently required to have a fixed value
+(equal to
+.IR sizeof(kernel_sigset_t) ).
+.\" sizeof(kernel_sigset_t) == _NSIG / 8,
+.\" which equals to 8 on most architectures, but e.g. on MIPS it's 16.
 
 The glibc
 .BR sigprocmask ()

why not add this information like:
Note: sizeof(kernel_sigset_t) is not the same for all architectures

re,
wh
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw

PATCH v2 1/1 sigprocmask.2: do not specify an exact value of rt_sigprocmask's 4th argument

As sizeof(kernel_sigset_t) is not the same for all architectures, it would be better not to mention any numbers as its value.

---
v2: mention that sizeof(kernel_sigset_t) is architecture specific.

 man2/sigprocmask.2 | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
man2/sigprocmask.2 +5 -4
index 8388340..499fd0c 100644
@@ -202,10 +202,11 @@ which specifies the size in bytes of the signal sets in
 .IR set
 and
 .IR oldset .
-This argument is currently required to have the value 8
-(
-.IR sizeof(kernel_sigset_t)
-).
+This argument is currently required to have a fixed architecture specific value
+(equal to
+.IR sizeof(kernel_sigset_t) ).
+.\" sizeof(kernel_sigset_t) == _NSIG / 8,
+.\" which equals to 8 on most architectures, but e.g. on MIPS it's 16.
 
 The glibc
 .BR sigprocmask ()
Signature · 6 lines
ldv

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20170220154327.GA9511-u2l5PoMzF/[email protected]

#6 lore raw

PATCH v2 1/1 sigprocmask.2: do not specify an exact value of rt_sigprocmask's 4th argument

As sizeof(kernel_sigset_t) is not the same for all architectures, it would be better not to mention any numbers as its value.

---
v2: mention that sizeof(kernel_sigset_t) is architecture specific.

 man2/sigprocmask.2 | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
man2/sigprocmask.2 +5 -4
index 8388340..499fd0c 100644
@@ -202,10 +202,11 @@ which specifies the size in bytes of the signal sets in
 .IR set
 and
 .IR oldset .
-This argument is currently required to have the value 8
-(
-.IR sizeof(kernel_sigset_t)
-).
+This argument is currently required to have a fixed architecture specific value
+(equal to
+.IR sizeof(kernel_sigset_t) ).
+.\" sizeof(kernel_sigset_t) == _NSIG / 8,
+.\" which equals to 8 on most architectures, but e.g. on MIPS it's 16.
 
 The glibc
 .BR sigprocmask ()
Signature · 5 lines
ldv
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#7 lore raw
In reply to a message not in the archive

Hello Dmitry

Quoted 2 lines · Dmitry V. Levin

As sizeof(kernel_sigset_t) is not the same for all architectures, it would be better not to mention any numbers as its value.

Thanks! Applied.

Cheers,

Michael

Quoted 28 lines

---
v2: mention that sizeof(kernel_sigset_t) is architecture specific.

 man2/sigprocmask.2 | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
man2/sigprocmask.2 +5 -4
index 8388340..499fd0c 100644
@@ -202,10 +202,11 @@ which specifies the size in bytes of the signal sets in
 .IR set
 and
 .IR oldset .
-This argument is currently required to have the value 8
-(
-.IR sizeof(kernel_sigset_t)
-).
+This argument is currently required to have a fixed architecture specific value
+(equal to
+.IR sizeof(kernel_sigset_t) ).
+.\" sizeof(kernel_sigset_t) == _NSIG / 8,
+.\" which equals to 8 on most architectures, but e.g. on MIPS it's 16.
 
 The glibc
 .BR sigprocmask ()
Signature · 7 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html