Skip to contentSkip to conversation

media: pci: saa7164: remove unnecessary code

PATCH In review Gustavo A. R. Silva 2 participants 4 messages Feb 21, 2017 Media (V4L/DVB)

lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/2 media: pci: saa7164: remove unnecessary code

Remove unnecessary variable 'loop'.

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/media/pci/saa7164/saa7164-cmd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/media/pci/saa7164/saa7164-cmd.c +1 -2
index 45951b3..169c90a 100644
@@ -134,14 +134,13 @@ int saa7164_irq_dequeue(struct saa7164_dev *dev)
  * -bus/c running buffer. */
 static int saa7164_cmd_dequeue(struct saa7164_dev *dev)
 {
-	int loop = 1;
 	int ret;
 	u32 timeout;
 	wait_queue_head_t *q = NULL;
 	u8 tmp[512];
 	dprintk(DBGLVL_CMD, "%s()\n", __func__);
 
-	while (loop) {
+	while (true) {
 
 		struct tmComResInfo tRsp = { 0, 0, 0, 0, 0, 0 };
 		ret = saa7164_bus_get(dev, &tRsp, NULL, 1);
Signature · 1 line
2.5.0
author
#1 lore raw

PATCH 2/2 media: pci: saa7164: remove dead code

Remove dead code. The following line of code is never reached:
return SAA_OK;

Addresses-Coverity-ID: 114283

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/media/pci/saa7164/saa7164-cmd.c | 2 --
 1 file changed, 2 deletions(-)
drivers/media/pci/saa7164/saa7164-cmd.c +0 -2
index 169c90a..fb19498 100644
@@ -181,8 +181,6 @@ static int saa7164_cmd_dequeue(struct saa7164_dev *dev)
 		wake_up(q);
 		return SAA_OK;
 	}
-
-	return SAA_OK;
 }
 
 static int saa7164_cmd_set(struct saa7164_dev *dev, struct tmComResInfo *msg,
Signature · 1 line
2.5.0
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] media: pci: saa7164: remove dead code

Quoted 4 lines · Gustavo A. R. Silva

Remove dead code. The following line of code is never reached:
return SAA_OK;

Addresses-Coverity-ID: 114283

Reviewed-by Peter Senna Tschudin <[email protected]>
Quoted 21 lines
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/media/pci/saa7164/saa7164-cmd.c | 2 --
 1 file changed, 2 deletions(-)
drivers/media/pci/saa7164/saa7164-cmd.c +0 -2
index 169c90a..fb19498 100644
@@ -181,8 +181,6 @@ static int saa7164_cmd_dequeue(struct saa7164_dev *dev)
 		wake_up(q);
 		return SAA_OK;
 	}
-
-	return SAA_OK;
 }
 
 static int saa7164_cmd_set(struct saa7164_dev *dev, struct tmComResInfo *msg,
Signature · 1 line
2.5.0
Reviewed-by on v1 1/2
#3 lore raw
In reply to Gustavo A. R. Silva
Quoted 2 lines · Gustavo A. R. Silva

Remove unnecessary variable 'loop'.

Reviewed-by Peter Senna Tschudin <[email protected]>
Quoted 28 lines
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/media/pci/saa7164/saa7164-cmd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/media/pci/saa7164/saa7164-cmd.c +1 -2
index 45951b3..169c90a 100644
@@ -134,14 +134,13 @@ int saa7164_irq_dequeue(struct saa7164_dev *dev)
  * -bus/c running buffer. */
 static int saa7164_cmd_dequeue(struct saa7164_dev *dev)
 {
-	int loop = 1;
 	int ret;
 	u32 timeout;
 	wait_queue_head_t *q = NULL;
 	u8 tmp[512];
 	dprintk(DBGLVL_CMD, "%s()\n", __func__);
 
-	while (loop) {
+	while (true) {
 
 		struct tmComResInfo tRsp = { 0, 0, 0, 0, 0, 0 };
 		ret = saa7164_bus_get(dev, &tRsp, NULL, 1);
Signature · 1 line
2.5.0