Skip to contentSkip to conversation

ALSA: x86: hdmi: select CONFIG_SND_PCM

PATCH Applied Arnd Bergmann 2 participants 2 messages Feb 21, 2017 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: x86: hdmi: select CONFIG_SND_PCM

The newly added driver uses the PCM helpers and fails to link if they are disabled:

sound/built-in.o: In function `hdmi_lpe_audio_runtime_suspend':
intel_hdmi_audio.c:(.text+0x15906): undefined reference to snd_pcm_suspend' sound/built-in.o: In function had_pcm_hw_params':
intel_hdmi_audio.c:(.text+0x15ac7): undefined reference to snd_pcm_lib_malloc_pages' sound/built-in.o: In function had_pcm_open':
intel_hdmi_audio.c:(.text+0x15d49): undefined reference to `snd_pcm_hw_constraint_integer'

This uses a Kconfig 'select' statement to make sure they are enabled.

Fixes 5dab11d89777 ("ALSA: x86: hdmi: Add audio support for BYT and CHT")
---
 sound/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)
sound/x86/Kconfig +1 -0
index 30d066e4885e..84c8f8fc597c 100644
@@ -9,6 +9,7 @@ if SND_X86
 config HDMI_LPE_AUDIO
 	tristate "HDMI audio without HDaudio on Intel Atom platforms"
 	depends on DRM_I915
+	select SND_PCM
 	help
 	 Choose this option to support HDMI LPE Audio mode
 
Signature · 1 line
2.9.0
Applied
#1 lore raw
Quoted 10 lines · Arnd Bergmann

The newly added driver uses the PCM helpers and fails to link if they are disabled:

sound/built-in.o: In function `hdmi_lpe_audio_runtime_suspend':
intel_hdmi_audio.c:(.text+0x15906): undefined reference to snd_pcm_suspend' sound/built-in.o: In function had_pcm_hw_params':
intel_hdmi_audio.c:(.text+0x15ac7): undefined reference to snd_pcm_lib_malloc_pages' sound/built-in.o: In function had_pcm_open':
intel_hdmi_audio.c:(.text+0x15d49): undefined reference to `snd_pcm_hw_constraint_integer'

Quoted 4 lines

This uses a Kconfig 'select' statement to make sure they are enabled.

Fixes 5dab11d89777 ("ALSA: x86: hdmi: Add audio support for BYT and CHT")

Thanks, applied.

Takashi