staging: wilc1000: renames struct tstrRSSI and its members u8Index, u8Full
PATCH 1/1 staging: wilc1000: renames struct tstrRSSI and its members u8Index, u8Full
Fixes multiple camel case checks on struct tstrRSSI from checkpatch.pl:
Avoid CamelCase: <tstrRSSI>
Avoid CamelCase: <u8Full>
Avoid CamelCase: <u8Index>
--- drivers/staging/wilc1000/coreconfigurator.h | 8 ++++---- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +++++----- 2 files changed, 9 insertions(+), 9 deletions(-)
drivers/staging/wilc1000/coreconfigurator.h +4 -4
@@ -70,9 +70,9 @@ enum connect_status { CONNECT_STS_FORCE_16_BIT = 0xFFFF }; -struct tstrRSSI { -u8 u8Full; -u8 u8Index; +struct tstr_RSSI { +u8 u8_full; +u8 u8_index;s8 as8RSSI[NUM_RSSI ]; };
@@ -93,7 +93,7 @@ struct network_info {u8 *ies;u16 ies_len;void *join_params; -struct tstrRSSI str_rssi; +struct tstr_RSSI str_rssi;u64 tsf_hi; };
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +5 -5
@@ -205,8 +205,8 @@ static u32 get_rssi_avg(struct network_info *network_info) {u8 i;int rssi_v =0 ; -u8 num_rssi = (network_info->str_rssi.u8Full) ? -NUM_RSSI : (network_info->str_rssi.u8Index); +u8 num_rssi = (network_info->str_rssi.u8_full) ? +NUM_RSSI : (network_info->str_rssi.u8_index);for (i =0 ; i < num_rssi; i++) rssi_v += network_info->str_rssi.as8RSSI[i];
@@ -346,13 +346,13 @@ static void add_network_to_shadow(struct network_info *pstrNetworkInfo, }else { ap_index = ap_found; } - rssi_index = last_scanned_shadow[ap_index].str_rssi.u8Index; + rssi_index = last_scanned_shadow[ap_index].str_rssi.u8_index; last_scanned_shadow[ap_index].str_rssi.as8RSSI[rssi_index++] = pstrNetworkInfo->rssi;if (rssi_index ==NUM_RSSI ) { rssi_index =0 ; - last_scanned_shadow[ap_index].str_rssi.u8Full =1 ; + last_scanned_shadow[ap_index].str_rssi.u8_full =1 ; } - last_scanned_shadow[ap_index].str_rssi.u8Index = rssi_index; + last_scanned_shadow[ap_index].str_rssi.u8_index = rssi_index; last_scanned_shadow[ap_index].rssi = pstrNetworkInfo->rssi; last_scanned_shadow[ap_index].cap_info = pstrNetworkInfo->cap_info; last_scanned_shadow[ap_index].ssid_len = pstrNetworkInfo->ssid_len;
Signature · 1 line
2.7.4
Quoted 17 lines · Tahia Khan
Fixes multiple camel case checks on struct tstrRSSI from checkpatch.pl:
Avoid CamelCase: <tstrRSSI>
Avoid CamelCase: <u8Full>
Avoid CamelCase: <u8Index>Signed-off-by Tahia Khan <[email protected]>--- drivers/staging/wilc1000/coreconfigurator.h | 8 ++++---- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +++++----- 2 files changed, 9 insertions(+), 9 deletions(-)drivers/staging/wilc1000/coreconfigurator.h +0
-0
drivers/staging/wilc1000/coreconfigurator.h enum connect_status { · line 75
Quoted 9 lines
drivers/staging/wilc1000/coreconfigurator.h +3
-3@@ -70,9 +70,9 @@ enum connect_status {CONNECT_STS_FORCE_16_BIT =0xFFFF }; -struct tstrRSSI { -u8 u8Full; -u8 u8Index; +struct tstr_RSSI { +u8 u8_full; +u8 u8_index;
The kernel doesn't use variable names that incorporate types. These could just be full and index.
julia
Quoted 54 lines
drivers/staging/wilc1000/coreconfigurator.h +1
-1s8 as8RSSI[NUM_RSSI ]; };@@ -93,7 +93,7 @@ struct network_info {u8 *ies;u16 ies_len;void *join_params; -struct tstrRSSI str_rssi; +struct tstr_RSSI str_rssi;u64 tsf_hi; };drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +5
-6@@ -205,8 +205,8 @@ static u32 get_rssi_avg(struct network_info *network_info) {u8 i;int rssi_v =0 ; -u8 num_rssi = (network_info->str_rssi.u8Full) ? -NUM_RSSI : (network_info->str_rssi.u8Index); +u8 num_rssi = (network_info->str_rssi.u8_full) ? +NUM_RSSI : (network_info->str_rssi.u8_index);for (i =0 ; i < num_rssi; i++) rssi_v += network_info->str_rssi.as8RSSI[i];@@ -346,13 +346,13 @@ static void add_network_to_shadow(struct network_info *pstrNetworkInfo, }else { ap_index = ap_found; } - rssi_index = last_scanned_shadow[ap_index].str_rssi.u8Index; + rssi_index = last_scanned_shadow[ap_index].str_rssi.u8_index; last_scanned_shadow[ap_index].str_rssi.as8RSSI[rssi_index++] = pstrNetworkInfo->rssi;if (rssi_index ==NUM_RSSI ) { rssi_index =0 ; - last_scanned_shadow[ap_index].str_rssi.u8Full =1 ; + last_scanned_shadow[ap_index].str_rssi.u8_full =1 ; } - last_scanned_shadow[ap_index].str_rssi.u8Index = rssi_index; + last_scanned_shadow[ap_index].str_rssi.u8_index = rssi_index; last_scanned_shadow[ap_index].rssi = pstrNetworkInfo->rssi; last_scanned_shadow[ap_index].cap_info = pstrNetworkInfo->cap_info; last_scanned_shadow[ap_index].ssid_len = pstrNetworkInfo->ssid_len; --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170222045543.GA27847%40coolbox.
For more options, visit https://groups.google.com/d/optout.