Skip to contentSkip to conversation

aacraid: Fixed expander hotplug for SMART family

PATCH Applied Raghava Aditya Renukunta 3 participants 3 messages Feb 22, 2017 – Feb 23, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 aacraid: Fixed expander hotplug for SMART family

Current driver Hotplug processing code skips over Enclosure channel, therefore any addition/removal of expander enclosure is not processed. Additionally device addition code relies on older device type, which prevents the hotplug of adapter expanders.

Fixed by removing code that skips over Enclosure channels and using the latest device type for addition or removal or enclosure expanders.

Fixes 6223a39fe6fbbeef (scsi: aacraid: Added support for hotplug)
---
 drivers/scsi/aacraid/commsup.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/scsi/aacraid/commsup.c +1 -4
index a2ea70d..1994c74 100644
@@ -1908,9 +1908,6 @@ static void aac_resolve_luns(struct aac_dev *dev)
 	for (bus = 0; bus < AAC_MAX_BUSES; bus++) {
 		for (target = 0; target < AAC_MAX_TARGETS; target++) {
 
-			if (aac_phys_to_logical(bus) == ENCLOSURE_CHANNEL)
-				continue;
-
 			if (bus == CONTAINER_CHANNEL)
 				channel = CONTAINER_CHANNEL;
 			else
@@ -1922,7 +1919,7 @@ static void aac_resolve_luns(struct aac_dev *dev)
 			sdev = scsi_device_lookup(dev->scsi_host_ptr, channel,
 					target, 0);
 
-			if (!sdev && devtype)
+			if (!sdev && new_devtype)
 				scsi_add_device(dev->scsi_host_ptr, channel,
 						target, 0);
 			else if (sdev && new_devtype != devtype)
Signature · 1 line
2.7.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines

-----Original Message-----
From: Raghava Aditya Renukunta [mailto:[email protected]]
Sent: Wednesday, February 22, 2017 8:23 AM
To: [email protected]; [email protected]; linux- [email protected]
Cc: Dave Carroll; Gana Sridaran; Scott Benesh
Subject: [PATCH] aacraid: Fixed expander hotplug for SMART family

Current driver Hotplug processing code skips over Enclosure channel, therefore any addition/removal of expander enclosure is not processed. Additionally device addition code relies on older device type, which prevents the hotplug of adapter expanders.

Fixed by removing code that skips over Enclosure channels and using the latest device type for addition or removal or enclosure expanders.

Quoted 6 lines
Fixes 6223a39fe6fbbeef (scsi: aacraid: Added support for hotplug)
Signed-off-by Raghava Aditya Renukunta

<[email protected]>

---
 drivers/scsi/aacraid/commsup.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
#2 lore raw
In reply to Raghava Aditya Renukunta
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Raghava" == Raghava Aditya Renukunta <[email protected]> writes:

Raghava> Current driver Hotplug processing code skips over Enclosure Raghava> channel, therefore any addition/removal of expander enclosure Raghava> is not processed. Additionally device addition code relies on Raghava> older device type, which prevents the hotplug of adapter Raghava> expanders.

Raghava> Fixed by removing code that skips over Enclosure channels and Raghava> using the latest device type for addition or removal or Raghava> enclosure expanders.

Applied to 4.11/scsi-fixes.

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering