Skip to contentSkip to conversation

drm/radeon/dp_auxch: Ratelimit aux transfer debug messages

PATCH Applied Lyude 2 participants 2 messages Feb 22, 2017 – Feb 23, 2017

Subsystems (2)
lore
Share & tools
lore

Lyude

author
#0 lore raw

PATCH 1/1 drm/radeon/dp_auxch: Ratelimit aux transfer debug messages

Aux transfers always fail with non-zero status flags when there's nothing connected on the port, so we don't usually need to see all of the debugging information from it. Also, we try reprobing a -lot-, so without ratelimiting most of the kernel log is filled up with messages from radeon_dp_aux_transfer_native.

---
 drivers/gpu/drm/radeon/radeon_dp_auxch.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/radeon/radeon_dp_auxch.c +2 -1
index 474a8a18..12eac4e 100644
@@ -168,7 +168,8 @@ radeon_dp_aux_transfer_native(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg
 		goto done;
 	}
 	if (tmp & AUX_RX_ERROR_FLAGS) {
-		DRM_DEBUG_KMS("dp_aux_ch flags not zero: %08x\n", tmp);
+		DRM_DEBUG_KMS_RATELIMITED("dp_aux_ch flags not zero: %08x\n",
+					  tmp);
 		ret = -EIO;
 		goto done;
 	}
Signature · 1 line
2.9.3
Applied
#1 lore raw
Quoted 7 lines · Lyude

Aux transfers always fail with non-zero status flags when there's nothing connected on the port, so we don't usually need to see all of the debugging information from it. Also, we try reprobing a -lot-, so without ratelimiting most of the kernel log is filled up with messages from radeon_dp_aux_transfer_native.

Applied. thanks!

Alex

Quoted 25 lines
---
 drivers/gpu/drm/radeon/radeon_dp_auxch.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/radeon/radeon_dp_auxch.c +2 -2
index 474a8a18..12eac4e 100644
@@ -168,7 +168,8 @@ radeon_dp_aux_transfer_native(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg
                goto done;
        }
        if (tmp & AUX_RX_ERROR_FLAGS) {
-               DRM_DEBUG_KMS("dp_aux_ch flags not zero: %08x\n", tmp);
+               DRM_DEBUG_KMS_RATELIMITED("dp_aux_ch flags not zero: %08x\n",
+                                         tmp);
                ret = -EIO;
                goto done;
        }
--

2.9.3

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx