staging: ks7010: codes in the comments are removed
PATCH 1/1 staging: ks7010: codes in the comments are removed
Commenting Code Is a Bad Idea.
Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them.
So in thos patch codes in the comments are removed.
--- drivers/staging/ks7010/ks7010_sdio.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/staging/ks7010/ks7010_sdio.c +0 -4
@@ -495,10 +495,6 @@ static void ks7010_rw_function(struct work_struct *work)/* wiat after WAKEUP */ while (time_after (priv->last_wakeup + ((30 *HZ ) /1000 ), jiffies)) {DPRINTK (4 ,"wait after WAKEUP\n" ); -/* -* queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq, -* (priv->last_wakeup + ((30*HZ)/1000) - jiffies)); -*/ dev_info(&priv->ks_wlan_hw.sdio_card->func->dev, "wake: %lu %lu\n", priv->last_wakeup + (30 * HZ) / 1000,
Signature · 1 line
2.11.0
Remember to use the imperative and to make your subject lines as short as possible. Here the subject line could be "remove code in comments".
julia
Quoted 36 lines · Arushi Singhal
Commenting Code Is a Bad Idea.
Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them.
So in thos patch codes in the comments are removed.Signed-off-by Arushi Singhal <[email protected]>--- drivers/staging/ks7010/ks7010_sdio.c | 4 ---- 1 file changed, 4 deletions(-)drivers/staging/ks7010/ks7010_sdio.c +0
-5@@ -495,10 +495,6 @@ static void ks7010_rw_function(struct work_struct *work)/* wiat after WAKEUP */ while (time_after (priv->last_wakeup + ((30 *HZ ) /1000 ), jiffies)) {DPRINTK (4 ,"wait after WAKEUP\n" ); -/* -* queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq, -* (priv->last_wakeup + ((30*HZ)/1000) - jiffies)); -*/ dev_info(&priv->ks_wlan_hw.sdio_card->func->dev, "wake: %lu %lu\n", priv->last_wakeup + (30 * HZ) / 1000, --2.11.0
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170224231154.GA32083%40arushi-HP-Pavilion-Notebook.
For more options, visit https://groups.google.com/d/optout.